From nobody Mon Feb 9 14:33:28 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1586441767; cv=none; d=zohomail.com; s=zohoarc; b=Tu7/zav6FcWk2B1gOTAfJ1zhmt+56LdAsPDrFugyn40BpDYLx2LaDiQgILF4kNWE7dHD8CA4I608K03jG3H75RmLdbwUwycqtoEfotQDl15JdbnB1GguywZrO+tG/aoEGMIyhEn4Yr0umbmfDWM1Yqy1OZhOnsKBt9WvYXOkRHw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1586441767; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=iVR+Iq+GfqWh1TEmEOhKSnVCaGz6FBy3UY7jDcO8MZs=; b=RJSkBAVnqRRLKa6Pl1PJWwT93+9clPP2pHc9Ui7RHY+Z5tqyiwQGrHCzT+bxtYlo1ZHHRCTu1Ab/VAAMeuuQRZTSyftFzz3gs50b2InjvTfa+ZzrvFm7dOhvruxo8SaGra8XYLHUNnsGXhAX78PTXQ8Ya2pcf2rwebZtmhfQyzk= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1586441767360409.3444046702069; Thu, 9 Apr 2020 07:16:07 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jMXvK-0002oV-Ca; Thu, 09 Apr 2020 14:12:54 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jMXvI-0002oI-RA for xen-devel@lists.xenproject.org; Thu, 09 Apr 2020 14:12:52 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 2efc5962-7a6c-11ea-82d6-12813bfff9fa; Thu, 09 Apr 2020 14:12:45 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id E6972AD72; Thu, 9 Apr 2020 14:12:43 +0000 (UTC) X-Inumbo-ID: 2efc5962-7a6c-11ea-82d6-12813bfff9fa X-Virus-Scanned: by amavisd-new at test-mx.suse.de From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Subject: [PATCH 1/3] mini-os: fix double free() in netfront Date: Thu, 9 Apr 2020 16:12:38 +0200 Message-Id: <20200409141240.28876-2-jgross@suse.com> X-Mailer: git-send-email 2.16.4 In-Reply-To: <20200409141240.28876-1-jgross@suse.com> References: <20200409141240.28876-1-jgross@suse.com> X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , samuel.thibault@ens-lyon.org, wl@xen.org Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Commit d225f4012d69a19 ("Save/Restore Support: Add suspend/restore support for netfront") introduced a regression in form of freeing a netfront device structure twice. Fix that. Coverity-ID: 1433637 Fixes: d225f4012d69a19 ("Save/Restore Support: Add suspend/restore support = for netfront") Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault --- netfront.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/netfront.c b/netfront.c index 50b3a57..fe7bb62 100644 --- a/netfront.c +++ b/netfront.c @@ -584,8 +584,6 @@ void shutdown_netfront(struct netfront_dev *dev) list->refcount--; if (list->refcount =3D=3D 0) { _shutdown_netfront(dev); - free(dev->nodename); - free(dev); =20 to_del =3D list; if (to_del =3D=3D dev_list) { --=20 2.16.4