From nobody Mon Feb 9 14:50:30 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1586273024; cv=none; d=zohomail.com; s=zohoarc; b=jBLtWzMJt7Vsg4pjTJk2eZeg69XbV3+tTmMdc1rXwLZNQdXW9oaR13ehcUE3O/oIGjBEPhuu/fPOPOpxr/NylY4gfjiwovbj+tR8SgN4miziBLtCdeYZzJ3kAxXOD6XAzNViDOy+HuYDCcQI0q/MRfvgw+GL0F1iqT+nAsPmPIc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1586273024; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=k0pxFS+9SbTqMlmNO2mMerIrf4NDBJ4jp+8MG1PRWs8=; b=dOsIr47CqqeZ2FZb4flzoSZNik5gqwSjj9GzFIZZvPLM8bfhx949qxox5ovLQ2X7/DNHEIoaY+BNLynzWTLnO3B/PpbsnVsdeRXJk8XlGtamJfDdsOZ0EVrD4HUJMTOe5sR1/FLYBsIpq2UOL4STVjOb/qn7JqC4KJGfw6y2968= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1586273024673478.89332509594; Tue, 7 Apr 2020 08:23:44 -0700 (PDT) Received: from localhost ([::1]:49170 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jLq4l-0000qS-8e for importer@patchew.org; Tue, 07 Apr 2020 11:23:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38715) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jLq3u-00083E-KY for qemu-devel@nongnu.org; Tue, 07 Apr 2020 11:22:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jLq3t-0000QX-Oj for qemu-devel@nongnu.org; Tue, 07 Apr 2020 11:22:50 -0400 Received: from esa4.hc3370-68.iphmx.com ([216.71.155.144]:15905) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jLq3t-0000Ov-GM for qemu-devel@nongnu.org; Tue, 07 Apr 2020 11:22:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1586272969; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Qg827KIvdKEzs6jvNwGqMNXyL08iW2Xpsw7/s+ZIo+U=; b=V8o7vYc51hqOZDOa1Gg4S5mY2soj2zTUTUK6aXiAhU+IwVM61h72ZOhV eTp6R/vXIMDIfriIwFU4MzTR1jRJCTsf063qWPdSTF2xBkEpzSQCRadS5 vZ/cSmeAEIXIvQEv6Z/ULywPlb7VUJlt7PpCLy4a8tplEuMXmqA/t5MfW I=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=anthony.perard@citrix.com; spf=Pass smtp.mailfrom=anthony.perard@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: None (esa4.hc3370-68.iphmx.com: no sender authenticity information available from domain of anthony.perard@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa4.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa4.hc3370-68.iphmx.com: domain of anthony.perard@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa4.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa4.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa4.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: kEEUF3m5QJdGP+nVunsvGYsRB0qPKBIMKb/0kGJ3Ad5qvTmdLxzqw07ltbH+HjkMS71Lrl6qAZ yaqI6F3eG7Ljvf+RIJ4y5SPiYNj2f/YSQoguctmkfywB1hHd8dYISMCx2YiySk4t6THD2BQCLP knLe7MnbkruiyE3zrnKMGimmjyRfL/DuVm0FlJIL58nV+zkLXePqoukx+rwJVM+fHTfww1YqlB xHvSG8Zx8+xBzBZrflAGWY1Q724URub+FE+lbwk29Fg0NiOIHzB4pSav/fbtBaxYHZbvF4WFqP 4ps= X-SBRS: 2.7 X-MesageID: 15974527 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.72,355,1580792400"; d="scan'208";a="15974527" From: Anthony PERARD To: Subject: [PULL 2/3] xen-block: Fix uninitialized variable Date: Tue, 7 Apr 2020 16:22:36 +0100 Message-ID: <20200407152237.1468704-3-anthony.perard@citrix.com> X-Mailer: git-send-email 2.26.0 In-Reply-To: <20200407152237.1468704-1-anthony.perard@citrix.com> References: <20200407152237.1468704-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-Received-From: 216.71.155.144 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , xen-devel@lists.xenproject.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Since 7f5d9b206d1e ("object-add: don't create return value if failed"), qmp_object_add() don't write any value in 'ret_data', thus has random data. Then qobject_unref() fails and abort(). Fix by initialising 'ret_data' properly. Fixes: 5f07c4d60d09 ("qapi: Flatten object-add") Signed-off-by: Anthony PERARD Reviewed-by: Markus Armbruster Message-Id: <20200406164207.1446817-1-anthony.perard@citrix.com> --- hw/block/xen-block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/block/xen-block.c b/hw/block/xen-block.c index 07bb32e22b51..99cb4c67cb09 100644 --- a/hw/block/xen-block.c +++ b/hw/block/xen-block.c @@ -860,7 +860,7 @@ static XenBlockIOThread *xen_block_iothread_create(cons= t char *id, XenBlockIOThread *iothread =3D g_new(XenBlockIOThread, 1); Error *local_err =3D NULL; QDict *opts; - QObject *ret_data; + QObject *ret_data =3D NULL; =20 iothread->id =3D g_strdup(id); =20 --=20 Anthony PERARD