From nobody Tue Feb 10 09:57:11 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1585996056; cv=none; d=zohomail.com; s=zohoarc; b=PhkWcnAHrrtpkaDE5q/Jmz8c+DpVBWACGqgw8VYtfw3BSq33/E/wP5vB90fIA10N1c42KxAXY8l3fsDDYfx04qwvpFxzI53oosSTTyvZgQmFWnoTG+atvBEqaBy9lsn1D0f0n3owyFX7wejXT0Mm8vZqrHAH9zdei2pwEKS/1OY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1585996056; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=O8qi6CyUcG6jB4s0EzoV2dMvYHGdJrUt2FlFqXtPOl8=; b=B8gIIgQhqz0NP2nDbdBhoacEnypoUqhoW/iP+hU68JLM0WZa63CBn1vU1+9XkoYiPT42ePo7R7oQOWp2EY5mYPdRN8hdYJ+X9JVMqEsOl9zozsdJzCyprDkik8t0+EJmmnuzYKb4QV1tajM/54HXXrRNIvxpcOnLkffrwmNekvQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1585996056245148.84571131905864; Sat, 4 Apr 2020 03:27:36 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jKg15-00008D-QQ; Sat, 04 Apr 2020 10:27:07 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jKg13-00007y-V8 for xen-devel@lists.xenproject.org; Sat, 04 Apr 2020 10:27:05 +0000 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id d21e80dc-765e-11ea-be07-12813bfff9fa; Sat, 04 Apr 2020 10:27:01 +0000 (UTC) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jKg0y-0005A3-Or; Sat, 04 Apr 2020 10:27:00 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1jKg0y-0005h7-FD; Sat, 04 Apr 2020 10:27:00 +0000 X-Inumbo-ID: d21e80dc-765e-11ea-be07-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=O8qi6CyUcG6jB4s0EzoV2dMvYHGdJrUt2FlFqXtPOl8=; b=YlH0HS7iY7bQCuXO+2W9jQewuq 9DBzxuGAVlalJMPEKMMvBaMGojlJDJXFcseVSdRSadg7AjhSDt6P+gUKexJ4kGxx62OyBkYpmOrDg BSQ1IC0EkeiC7dbc+SQetgs/mzoi0hVZL5zY/Jx9n5YBFtmYpjr3obwlrRTeIULJ5gs8=; From: Julien Grall To: xen-devel@lists.xenproject.org Subject: [PATCH v2 1/3] xen/x86: ioapic: Use true/false in bad_ioapic_register() Date: Sat, 4 Apr 2020 11:26:54 +0100 Message-Id: <20200404102656.29730-2-julien@xen.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200404102656.29730-1-julien@xen.org> References: <20200404102656.29730-1-julien@xen.org> X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: julien@xen.org, Wei Liu , Andrew Cooper , Julien Grall , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Julien Grall bad_ioapic_register() is returning a bool, so we should switch to true/false. Signed-off-by: Julien Grall Reviewed-by: Wei Liu Acked-by: Jan Beulich --- Changes in v2: - Add Wei's reviewed-by - Fix typo - Add Jan's acked-by --- xen/arch/x86/io_apic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/io_apic.c b/xen/arch/x86/io_apic.c index e98e08e9c8..9868933287 100644 --- a/xen/arch/x86/io_apic.c +++ b/xen/arch/x86/io_apic.c @@ -2531,10 +2531,10 @@ static __init bool bad_ioapic_register(unsigned int= idx) { printk(KERN_WARNING "I/O APIC %#x registers return all ones, skipp= ing!\n", mp_ioapics[idx].mpc_apicaddr); - return 1; + return true; } =20 - return 0; + return false; } =20 void __init init_ioapic_mappings(void) --=20 2.17.1