From nobody Sun May 5 20:12:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1585457804; cv=none; d=zohomail.com; s=zohoarc; b=Nt7CNXwyg46ExIwr4//FjSgXoYIawsmrJjMKFTYtg6Lhyqofzr03y4DWIg76bRlostTDoibwgo3mPCteNvWYgKhFQWZ6671Kv9VknqhhoD9udqmMzT7v7LWRMS9ZqZ15eVE9RkN3k2R2PGjUzWUHV2f8ii7CDmtPNqiiOLSE0Gg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1585457804; h=Content-Type:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=AYt3QUMaPQajEDhDFhKC4mL4Ue+J22qPFzeC1zApcAA=; b=bNhSrqiPw43DIYlLNmomLRrKx56Vn8rxO78EOWU9su8+dz+2N0YRqoToG5Z5ZsZF++zctNx4yv+RV3xxi7rLCsq+bbQnB8jYsQeapqLAy6V7m6POXK8bbn5U1JEE2n5YcviFcKxG/CJ6BWhjyLur9fVZx3j68QW1YW/wlilGZXM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1585457804773868.2621991164254; Sat, 28 Mar 2020 21:56:44 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jIPyk-0002pw-TK; Sun, 29 Mar 2020 04:55:22 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jIPyj-0002pq-1w for xen-devel@lists.xenproject.org; Sun, 29 Mar 2020 04:55:21 +0000 Received: from mail-pl1-x644.google.com (unknown [2607:f8b0:4864:20::644]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 7d801822-7179-11ea-a6c1-bc764e2007e4; Sun, 29 Mar 2020 04:55:20 +0000 (UTC) Received: by mail-pl1-x644.google.com with SMTP id e1so5268262plt.9 for ; Sat, 28 Mar 2020 21:55:20 -0700 (PDT) Received: from simran-Inspiron-5558 ([2409:4052:2ea9:879:e86a:3263:71b5:b71b]) by smtp.gmail.com with ESMTPSA id i26sm7294020pfk.176.2020.03.28.21.55.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Mar 2020 21:55:18 -0700 (PDT) X-Inumbo-ID: 7d801822-7179-11ea-a6c1-bc764e2007e4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=AYt3QUMaPQajEDhDFhKC4mL4Ue+J22qPFzeC1zApcAA=; b=L98V1ab1ggWto2Hy3vBijNUCP+NjNltCQZRkhQMQtoHBPXd8iHTB3yv+TE3UU4bfYU IGlo0ogmWCe2lkXKVcIBCEHk2T0CgZU0p61GlfbpaPX7DAP8zIVaYKcOcMie1UhoNyyJ nETP4XcCVcKfbWnt7NOwpVXXqWaSSkOvgiiznWeBJ+0KgR5E7aSIaos+4Zrnu08F2wiJ 0breV0rL43sJ8g0BhEGLfAfqGFQ2ZqYElZCgQ+YmOTa0haIeqrKtzPgIKr2bEy0S6HWF 7TNVywLurtVjwZn2TkYi+TIGVyGYhXqIQVJHU4lAAlzDFgvKU3GWF3YgvLLdzXbwpzNO HIZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=AYt3QUMaPQajEDhDFhKC4mL4Ue+J22qPFzeC1zApcAA=; b=NXEaD1Z1jtrTfYA2f01McgXl8IEGNs0Zu1DEbjse0+OXBtOZku1irpP1Px5PJ1ukx2 mIM9hke1rBUWIs/PAFdzBw4887BHzJwGeE020X77ca6UYZHRQ57IUcGv4WxblReuUuPr dgRXbBPOs2vzNh8uwzr6o/DSparsvzC52+xPr4PTO73Oto1LLa6Hoxii/kk8usXl3P5D ubXlsL2QhPtyE18JAjLMwVcbt76K6diJthGW9OCuvn234oQRfrVwf1sdPtoWLuYDBYgH LVMBbid2Ax2hQEj9ocXIsWZPYt50aZ5pMdhLPupPo/zhLmx47JazcMX7kxpH70Vi38LI ZDjQ== X-Gm-Message-State: ANhLgQ3gp4kRWsv21ytetr+3/gWXZkIMgIgrDklgzgeSkxQDQZMknTYL xDj/xNB9OWnJVkdE5t9oHv4= X-Google-Smtp-Source: ADFU+vtiQSlpgxEhFqMeb/Zn2Fn7CaEyXcyySIozdQoyBmYXQ7ZSx6VDhBx4Bb2q99jnGdH1Z9CBfw== X-Received: by 2002:a17:902:ba97:: with SMTP id k23mr6134480pls.46.1585457719327; Sat, 28 Mar 2020 21:55:19 -0700 (PDT) Date: Sun, 29 Mar 2020 10:25:12 +0530 From: Simran Singhal To: xen-devel@lists.xenproject.org Message-ID: <20200329045512.GA28203@simran-Inspiron-5558> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.9.4 (2018-02-28) Subject: [Xen-devel] [PATCH v2] xen/x86: Remove unnecessary cast on void pointer X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Kevin Tian , Jan Beulich , Wei Liu , Andrew Cooper , Jun Nakajima , Roger Pau =?iso-8859-1?Q?Monn=E9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Assignment to a typed pointer is sufficient in C. No cast is needed. Also, changed some u64/u32 to uint64_t/uint32_t. Signed-off-by: Simran Singhal Acked-by: Jan Beulich Reviewed-by: Roger Pau Monn=C3=A9 --- Changes in v2: - Took the chance to change some uintX to uintX_t. xen/arch/x86/acpi/cpufreq/powernow.c | 2 +- xen/arch/x86/cpu/vpmu.c | 2 +- xen/arch/x86/hpet.c | 2 +- xen/arch/x86/hvm/save.c | 2 +- xen/arch/x86/hvm/vmx/vvmx.c | 12 ++++++------ 5 files changed, 10 insertions(+), 10 deletions(-) diff --git a/xen/arch/x86/acpi/cpufreq/powernow.c b/xen/arch/x86/acpi/cpufr= eq/powernow.c index 3cf9c6cd05..f620bebc7e 100644 --- a/xen/arch/x86/acpi/cpufreq/powernow.c +++ b/xen/arch/x86/acpi/cpufreq/powernow.c @@ -58,7 +58,7 @@ static void transition_pstate(void *pstate) =20 static void update_cpb(void *data) { - struct cpufreq_policy *policy =3D (struct cpufreq_policy *)data; + struct cpufreq_policy *policy =3D data; =20 if (policy->turbo !=3D CPUFREQ_TURBO_UNSUPPORTED) { uint64_t msr_content; diff --git a/xen/arch/x86/cpu/vpmu.c b/xen/arch/x86/cpu/vpmu.c index e50d478d23..1ed39ef03f 100644 --- a/xen/arch/x86/cpu/vpmu.c +++ b/xen/arch/x86/cpu/vpmu.c @@ -337,7 +337,7 @@ void vpmu_do_interrupt(struct cpu_user_regs *regs) =20 static void vpmu_save_force(void *arg) { - struct vcpu *v =3D (struct vcpu *)arg; + struct vcpu *v =3D arg; struct vpmu_struct *vpmu =3D vcpu_vpmu(v); =20 if ( !vpmu_is_set(vpmu, VPMU_CONTEXT_LOADED) ) diff --git a/xen/arch/x86/hpet.c b/xen/arch/x86/hpet.c index 86929b9ba1..c46e7cf4ee 100644 --- a/xen/arch/x86/hpet.c +++ b/xen/arch/x86/hpet.c @@ -215,7 +215,7 @@ again: static void hpet_interrupt_handler(int irq, void *data, struct cpu_user_regs *regs) { - struct hpet_event_channel *ch =3D (struct hpet_event_channel *)data; + struct hpet_event_channel *ch =3D data; =20 this_cpu(irq_count)--; =20 diff --git a/xen/arch/x86/hvm/save.c b/xen/arch/x86/hvm/save.c index 0fc59d3487..a2c56fbc1e 100644 --- a/xen/arch/x86/hvm/save.c +++ b/xen/arch/x86/hvm/save.c @@ -417,7 +417,7 @@ void _hvm_read_entry(struct hvm_domain_context *h, void= *dest, memcpy(dest, &h->data[h->cur], d->length); =20 if ( d->length < dest_len ) - memset((char *)dest + d->length, 0, dest_len - d->length); + memset(dest + d->length, 0, dest_len - d->length); =20 h->cur +=3D d->length; } diff --git a/xen/arch/x86/hvm/vmx/vvmx.c b/xen/arch/x86/hvm/vmx/vvmx.c index f049920196..2edb103205 100644 --- a/xen/arch/x86/hvm/vmx/vvmx.c +++ b/xen/arch/x86/hvm/vmx/vvmx.c @@ -253,12 +253,12 @@ static int vvmcs_offset(u32 width, u32 type, u32 inde= x) return offset; } =20 -u64 get_vvmcs_virtual(void *vvmcs, u32 vmcs_encoding) +uint64_t get_vvmcs_virtual(void *vvmcs, uint32_t vmcs_encoding) { union vmcs_encoding enc; - u64 *content =3D (u64 *) vvmcs; + uint64_t *content =3D vvmcs; int offset; - u64 res; + uint64_t res; =20 enc.word =3D vmcs_encoding; offset =3D vvmcs_offset(enc.width, enc.type, enc.index); @@ -307,12 +307,12 @@ enum vmx_insn_errno get_vvmcs_real_safe(const struct = vcpu *v, u32 encoding, return virtual_vmcs_vmread_safe(v, encoding, val); } =20 -void set_vvmcs_virtual(void *vvmcs, u32 vmcs_encoding, u64 val) +void set_vvmcs_virtual(void *vvmcs, uint32_t vmcs_encoding, uint64_t val) { union vmcs_encoding enc; - u64 *content =3D (u64 *) vvmcs; + uint64_t *content =3D vvmcs; int offset; - u64 res; + uint64_t res; =20 enc.word =3D vmcs_encoding; offset =3D vvmcs_offset(enc.width, enc.type, enc.index); --=20 2.17.1