From nobody Sun May 5 18:24:41 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1585305209; cv=none; d=zohomail.com; s=zohoarc; b=Z1Ouszo30dn/VLyU05vlungVZGH5ITxrSPXrBlmUi1U1ZaXTjhhgS6I5q46XRmIyshNI1Jd9HhzTPDIasgVI3HZtEWMqIe5XX14pBe0s9tLuo+RN4FNwW1ZvTaLlU4TQgWyI2XHqEfy5wEBSLu1sZpNa6bD8DK2GFLN1Hvbdg7I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1585305209; h=Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:Message-ID:Sender:Subject:To; bh=CcesUj9UmbVgOvU2DTnikOghFN7QcMmOTPXxVIvan5U=; b=K12aXs+edqOtPbxS/oxn97oaH53gqIORH/Sveifcn/8V1UZFDPvbfvvVfaAxmCoaLy32GSe0OB85Asj1/AIMnS77s93LhoUAp5svurnWtUlp3rHd1e651JZUJiGcyo9nVq3QtZbDY97APDd3eeECMD3dY5uCMkx6LDkiSoXC0ic= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1585305209717747.0605928055974; Fri, 27 Mar 2020 03:33:29 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jHmHH-0004Xk-0n; Fri, 27 Mar 2020 10:31:51 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jHmHF-0004XJ-Jp for xen-devel@lists.xenproject.org; Fri, 27 Mar 2020 10:31:49 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 29ca194f-7016-11ea-893a-12813bfff9fa; Fri, 27 Mar 2020 10:31:48 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 1AD2AAE07; Fri, 27 Mar 2020 10:31:47 +0000 (UTC) X-Inumbo-ID: 29ca194f-7016-11ea-893a-12813bfff9fa X-Virus-Scanned: by amavisd-new at test-mx.suse.de From: Juergen Gross To: xen-devel@lists.xenproject.org Date: Fri, 27 Mar 2020 11:31:44 +0100 Message-Id: <20200327103144.19914-1-jgross@suse.com> X-Mailer: git-send-email 2.16.4 Subject: [Xen-devel] [PATCH] xen/softirq: adjust comment X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , Stefano Stabellini , Julien Grall , Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , Jan Beulich Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" With commit cef21210fb133 ("rcu: don't process callbacks when holding a rcu_read_lock()") the comment in process_pending_softirqs() about not entering the scheduler should have been moved. Signed-off-by: Juergen Gross Acked-by: Jan Beulich --- xen/common/softirq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/common/softirq.c b/xen/common/softirq.c index eba65c5fc0..063e93cbe3 100644 --- a/xen/common/softirq.c +++ b/xen/common/softirq.c @@ -56,6 +56,7 @@ static void __do_softirq(unsigned long ignore_mask) =20 void process_pending_softirqs(void) { + /* Do not enter scheduler as it can preempt the calling context. */ unsigned long ignore_mask =3D (1ul << SCHEDULE_SOFTIRQ) | (1ul << SCHED_SLAVE_SOFTIRQ); =20 @@ -64,7 +65,6 @@ void process_pending_softirqs(void) ignore_mask |=3D 1ul << RCU_SOFTIRQ; =20 ASSERT(!in_irq() && local_irq_is_enabled()); - /* Do not enter scheduler as it can preempt the calling context. */ __do_softirq(ignore_mask); } =20 --=20 2.16.4