From nobody Fri May 3 17:31:26 2024 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1582126433; cv=none; d=zohomail.com; s=zohoarc; b=Dc57DzWDHXKZzwi83NEzOsGo6NzxqCHX1yPAOupui+GfhiB5zqxUW2EHO/+RE4IJgmJPiwwfX/83f0mWmUJ4PEYmr5beQXN9xpegzHXk7ilVIhcrlTD5Yu4fUivDZDFuYKP6ve+4LI3DAT6CPXZxI40K7G7AP66ehTtMv1PpFSc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582126433; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=bNxrYD5ftfczAS7w73Pho7ifJDbOpk3PKJVp0ExF4JI=; b=EovFp7cayREZGjAwAb9SRAGeXoAPi3akKrK+du0M8I/RSg/xTgE6SVbsIdVLcGvW06Uwfk19Ilju/lccS/A/1jmJdiyhlxtbgCNOY8kc5IB5ZBprTneStBdUA0gT9GpRDCzrwX8cdRUT5oUZb8Zf91sbOTml/BsI9xG6mHXtOQA= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 158212643350860.68210617052341; Wed, 19 Feb 2020 07:33:53 -0800 (PST) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1j4RLV-0003eh-JH; Wed, 19 Feb 2020 15:33:05 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1j4RLU-0003ec-Bu for xen-devel@lists.xenproject.org; Wed, 19 Feb 2020 15:33:04 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1def40d2-532d-11ea-ade5-bc764e2007e4; Wed, 19 Feb 2020 15:33:03 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 85045B415; Wed, 19 Feb 2020 15:33:02 +0000 (UTC) X-Inumbo-ID: 1def40d2-532d-11ea-ade5-bc764e2007e4 X-Virus-Scanned: by amavisd-new at test-mx.suse.de From: Juergen Gross To: xen-devel@lists.xenproject.org Date: Wed, 19 Feb 2020 16:33:00 +0100 Message-Id: <20200219153300.10679-1-jgross@suse.com> X-Mailer: git-send-email 2.16.4 Subject: [Xen-devel] [PATCH] xen/sched: don't disable interrupts all the time when dumping run-queues X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , George Dunlap , Dario Faggioli MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Having interrupts disabled all the time when running dump_runq() is not necessary. All the called functions are doing proper locking and disable interrupts if needed. Signed-off-by: Juergen Gross Reviewed-by: Dario Faggioli --- xen/common/sched/cpupool.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/xen/common/sched/cpupool.c b/xen/common/sched/cpupool.c index 476916c6ea..b7721b5d02 100644 --- a/xen/common/sched/cpupool.c +++ b/xen/common/sched/cpupool.c @@ -889,12 +889,10 @@ const cpumask_t *cpupool_valid_cpus(const struct cpup= ool *pool) =20 void dump_runq(unsigned char key) { - unsigned long flags; s_time_t now =3D NOW(); struct cpupool **c; =20 spin_lock(&cpupool_lock); - local_irq_save(flags); =20 printk("sched_smt_power_savings: %s\n", sched_smt_power_savings? "enabled":"disabled"); @@ -914,7 +912,6 @@ void dump_runq(unsigned char key) schedule_dump(*c); } =20 - local_irq_restore(flags); spin_unlock(&cpupool_lock); } =20 --=20 2.16.4 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel