From nobody Mon Feb 9 00:00:07 2026 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 15814143605901021.2013774966907; Tue, 11 Feb 2020 01:46:00 -0800 (PST) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1j1S5e-0000xV-Jq; Tue, 11 Feb 2020 09:44:22 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1j1S5d-0000xQ-8B for xen-devel@lists.xenproject.org; Tue, 11 Feb 2020 09:44:21 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 13bf5aaa-4cb3-11ea-b53d-12813bfff9fa; Tue, 11 Feb 2020 09:44:20 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id D58E0AC77; Tue, 11 Feb 2020 09:44:19 +0000 (UTC) X-Inumbo-ID: 13bf5aaa-4cb3-11ea-b53d-12813bfff9fa X-Virus-Scanned: by amavisd-new at test-mx.suse.de From: Juergen Gross To: xen-devel@lists.xenproject.org Date: Tue, 11 Feb 2020 10:44:18 +0100 Message-Id: <20200211094418.7500-1-jgross@suse.com> X-Mailer: git-send-email 2.16.4 Subject: [Xen-devel] [PATCH v2] xen/sched: remove pointless BUG_ON() in credit2 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , George Dunlap , Dario Faggioli MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" The BUG_ON() at the top of csched2_context_saved() is completely pointless, as the ASSERT() just following it catches the same problem already. Signed-off-by: Juergen Gross Reviewed-by: Dario Faggioli --- xen/common/sched/credit2.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/xen/common/sched/credit2.c b/xen/common/sched/credit2.c index b965cd1c7b..7d104f15d0 100644 --- a/xen/common/sched/credit2.c +++ b/xen/common/sched/credit2.c @@ -2167,8 +2167,6 @@ csched2_context_saved(const struct scheduler *ops, st= ruct sched_unit *unit) s_time_t now =3D NOW(); LIST_HEAD(were_parked); =20 - BUG_ON( !is_idle_unit(unit) && - svc->rqd !=3D c2rqd(ops, sched_unit_master(unit))); ASSERT(is_idle_unit(unit) || svc->rqd =3D=3D c2rqd(ops, sched_unit_master(unit))); =20 --=20 2.16.4 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel