From nobody Thu Apr 18 04:14:36 2024 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1581353183907100.90148064948858; Mon, 10 Feb 2020 08:46:23 -0800 (PST) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1j1CBm-0002SD-N1; Mon, 10 Feb 2020 16:45:38 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1j1CBl-0002S8-2M for xen-devel@lists.xenproject.org; Mon, 10 Feb 2020 16:45:37 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c2ee34ae-4c24-11ea-ab50-bc764e2007e4; Mon, 10 Feb 2020 16:45:36 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id A18EAB077; Mon, 10 Feb 2020 16:45:35 +0000 (UTC) X-Inumbo-ID: c2ee34ae-4c24-11ea-ab50-bc764e2007e4 X-Virus-Scanned: by amavisd-new at test-mx.suse.de From: Juergen Gross To: xen-devel@lists.xenproject.org Date: Mon, 10 Feb 2020 17:45:33 +0100 Message-Id: <20200210164533.29549-1-jgross@suse.com> X-Mailer: git-send-email 2.16.4 Subject: [Xen-devel] [PATCH] xen/sched: remove pointless ASSERT() in credit2 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , George Dunlap , Dario Faggioli MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" The ASSERT() at the top of csched2_context_saved() is completely pointless, as the BUG_ON() just in front of it catches the same problem already. While at it remove a bogus space in the BUG_ON(). Signed-off-by: Juergen Gross --- xen/common/sched/credit2.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/xen/common/sched/credit2.c b/xen/common/sched/credit2.c index b965cd1c7b..78467b772c 100644 --- a/xen/common/sched/credit2.c +++ b/xen/common/sched/credit2.c @@ -2167,10 +2167,8 @@ csched2_context_saved(const struct scheduler *ops, s= truct sched_unit *unit) s_time_t now =3D NOW(); LIST_HEAD(were_parked); =20 - BUG_ON( !is_idle_unit(unit) && - svc->rqd !=3D c2rqd(ops, sched_unit_master(unit))); - ASSERT(is_idle_unit(unit) || - svc->rqd =3D=3D c2rqd(ops, sched_unit_master(unit))); + BUG_ON(!is_idle_unit(unit) && + svc->rqd !=3D c2rqd(ops, sched_unit_master(unit))); =20 /* This unit is now eligible to be put on the runqueue again */ __clear_bit(__CSFLAG_scheduled, &svc->flags); --=20 2.16.4 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel