From nobody Thu Apr 18 07:33:40 2024 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1581003726632371.4432445502674; Thu, 6 Feb 2020 07:42:06 -0800 (PST) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1izjHO-0007Ip-Rq; Thu, 06 Feb 2020 15:41:22 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1izjHO-0007Ik-4u for xen-devel@lists.xenproject.org; Thu, 06 Feb 2020 15:41:22 +0000 Received: from mail-wm1-f68.google.com (unknown [209.85.128.68]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 1f69c404-48f7-11ea-afe4-12813bfff9fa; Thu, 06 Feb 2020 15:41:21 +0000 (UTC) Received: by mail-wm1-f68.google.com with SMTP id t14so505270wmi.5 for ; Thu, 06 Feb 2020 07:41:21 -0800 (PST) Received: from ufe34d9ed68d054.ant.amazon.com (54-240-197-235.amazon.com. [54.240.197.235]) by smtp.gmail.com with ESMTPSA id 25sm4044833wmi.32.2020.02.06.07.41.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Feb 2020 07:41:19 -0800 (PST) X-Inumbo-ID: 1f69c404-48f7-11ea-afe4-12813bfff9fa X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=6WsSAKWHEMNimo+aRtpQMsM0oX26fM+2iIzDc9TGohU=; b=hz110ZOYYyZ9DpFOT7Usym3TCutE1Qrjdx2EHkoCRUEWqOlkt0dEAiLp0VfG+GmzZ+ qAh8yCBPb0t3ctfsoMNkNiqrf9Vd5sqmPghIZP1ASxiezt32Xu3kSuMghNW6ZEWzSTBo hPQ2eRSe15YmKvuB7T4EyI9oMtCuXqgL7Wk0ZRE8WkGFxouoyOi4oas6OfP/Z6EcBTr3 x5aMSQK0htooJNIU7x3ROQklZ6toGzsJ9oHf3/mG+/CPi4Kg+/jG7Fn+/tPKud+nm2DQ 7NUKwabpEE18kc0lKsl3tsgw/Wv7TMG3AbmV/ZmaBpb2K1Z9VtN8vQj1OGzUFjm6KMjG FclA== X-Gm-Message-State: APjAAAUGX4xA9h1X/hijMT1OBgFnaYppFMjquVgGS2CzgbxbC2GsMMJS PAvv+eu92iOE6U1V54bRaTB9e49sQgQ= X-Google-Smtp-Source: APXvYqy2p+FAppOav1iDlbrO5tYs7FvlSVeZ1jo9pinWdP/jHEsRxTLqxaJoH6H0YuT7EYoWl/bfVw== X-Received: by 2002:a1c:4d03:: with SMTP id o3mr5033510wmh.164.1581003680390; Thu, 06 Feb 2020 07:41:20 -0800 (PST) From: Julien Grall To: xen-devel@lists.xenproject.org Date: Thu, 6 Feb 2020 15:41:18 +0000 Message-Id: <20200206154118.31451-1-julien@xen.org> X-Mailer: git-send-email 2.17.1 Subject: [Xen-devel] [PATCH] xen/include: public: Document the padding in struct xen_hvm_param X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , Konrad Rzeszutek Wilk , George Dunlap , Andrew Cooper , Julien Grall , Ian Jackson , Jan Beulich MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Julien Grall There is an implicit padding of 2 bytes in struct xen_hvm_param between the field domid and index. Make it explicit by introduce a padding field. This can also serve as documentation. Note that I don't think we can mandate it to be zero because a guest may not have initialized the padding. Signed-off-by: Julien Grall Acked-by: Jan Beulich Acked-by: Wei Liu --- xen/include/public/hvm/hvm_op.h | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/include/public/hvm/hvm_op.h b/xen/include/public/hvm/hvm_o= p.h index 610e020a62..b599d3cbd0 100644 --- a/xen/include/public/hvm/hvm_op.h +++ b/xen/include/public/hvm/hvm_op.h @@ -32,6 +32,7 @@ #define HVMOP_get_param 1 struct xen_hvm_param { domid_t domid; /* IN */ + uint16_t pad; uint32_t index; /* IN */ uint64_t value; /* IN/OUT */ }; --=20 2.17.1 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel