From nobody Mon Feb 9 23:57:57 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail(p=none dis=none) header.from=citrix.com Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1580732408045553.51992334039; Mon, 3 Feb 2020 04:20:08 -0800 (PST) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iyahY-0007wj-6g; Mon, 03 Feb 2020 12:19:40 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iyahX-0007wJ-Eh for xen-devel@lists.xenproject.org; Mon, 03 Feb 2020 12:19:39 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 6f5af14e-467f-11ea-8e54-12813bfff9fa; Mon, 03 Feb 2020 12:19:34 +0000 (UTC) X-Inumbo-ID: 6f5af14e-467f-11ea-8e54-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1580732374; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=cwqcxcjbNmV5kHDMCXn9CishPL2oIgFCUnW0A+7RXmo=; b=HAFW4fYCKk5BFMiDj2YPDvP0Ijr7pOa1qcWkkQEbN5YotslG6GQjwT5A xyVawTwhEsNx/5JPbHZGJtpi1RhARLxv3CMP5GqoJe5sF7ryZ2wtbV+i6 lr8QYXve5VCxM7yj40a4sYHmi3Ugvo7vcLTVrNYsFjqvixfQdNiXVLbGc g=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=roger.pau@citrix.com; spf=Pass smtp.mailfrom=roger.pau@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: None (esa4.hc3370-68.iphmx.com: no sender authenticity information available from domain of roger.pau@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa4.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="roger.pau@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa4.hc3370-68.iphmx.com: domain of roger.pau@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa4.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="roger.pau@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa4.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa4.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: g8lPMXfP71FJSK0mnk4sOAnmHS7WmfPIDdqiYlK9xwwK2YakuUbZ8hgRfuqmq37eg+eJ9Hebrc bx7lkcBsFLSe0rMnU2ufSwsDU5rvk07ulQJBcV8zFDrIbtQs2BcN2JWDhjJNmtTJr9iFZN7cGY i8GMwBu8R2x2zqPbVLWDZjS1bpcT10QW1Z3qm6/MS/Bqvw0LdQWXJjNAn78wAkViHz3GRku9Lx YwbH1uVZMBmyzUR/VKknzC6/aGJ0MaPf1tFC6gumgZ3KcUKQxV1z5Y2Geg+KN0be0BjX4bPBMK JgA= X-SBRS: 2.7 X-MesageID: 12457221 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.70,397,1574139600"; d="scan'208";a="12457221" From: Roger Pau Monne To: Date: Mon, 3 Feb 2020 13:19:18 +0100 Message-ID: <20200203121919.15748-4-roger.pau@citrix.com> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200203121919.15748-1-roger.pau@citrix.com> References: <20200203121919.15748-1-roger.pau@citrix.com> MIME-Version: 1.0 Subject: [Xen-devel] [PATCH v2 3/4] x86/vvmx: don't enable interrupt window when using virt intr delivery X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Kevin Tian , Jun Nakajima , Wei Liu , Andrew Cooper , Roger Pau Monne Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) If virtual interrupt delivery is used to inject the interrupt to the guest the interrupt window shouldn't be enabled, as the interrupt is already injected using the GUEST_INTR_STATUS vmcs field. Reported-by: Kevin Tian Signed-off-by: Roger Pau Monn=C3=A9 Reviewed-by: Kevin Tian --- Changes since v1: - New in this version. --- xen/arch/x86/hvm/vmx/intr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/hvm/vmx/intr.c b/xen/arch/x86/hvm/vmx/intr.c index 2eaf3f8d36..49a1295f09 100644 --- a/xen/arch/x86/hvm/vmx/intr.c +++ b/xen/arch/x86/hvm/vmx/intr.c @@ -209,7 +209,7 @@ static int nvmx_intr_intercept(struct vcpu *v, struct h= vm_intack intack) if ( unlikely(intack.source !=3D hvm_intsrc_none) ) vmx_enable_intr_window(v, intack); } - else + else if ( !cpu_has_vmx_virtual_intr_delivery ) vmx_enable_intr_window(v, intack); =20 return 1; --=20 2.25.0 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel