[Xen-devel] [PATCH v1] x86/domctl: fix typo in comment

Olaf Hering posted 1 patch 4 years, 2 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/xen tags/patchew/20200128154614.30572-1-olaf@aepfle.de
xen/include/public/domctl.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[Xen-devel] [PATCH v1] x86/domctl: fix typo in comment
Posted by Olaf Hering 4 years, 2 months ago
The array is named msr_policy.

Fixes commit 60529dfeca1

Signed-off-by: Olaf Hering <olaf@aepfle.de>
---
 xen/include/public/domctl.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
index e313da499f..2bb7397923 100644
--- a/xen/include/public/domctl.h
+++ b/xen/include/public/domctl.h
@@ -675,7 +675,7 @@ struct xen_domctl_cpu_policy {
     uint32_t nr_leaves; /* IN/OUT: Number of leaves in/written to
                          * 'cpuid_policy'. */
     uint32_t nr_msrs;   /* IN/OUT: Number of MSRs in/written to
-                         * 'msr_domain_policy' */
+                         * 'msr_policy' */
     XEN_GUEST_HANDLE_64(xen_cpuid_leaf_t) cpuid_policy; /* IN/OUT */
     XEN_GUEST_HANDLE_64(xen_msr_entry_t) msr_policy;    /* IN/OUT */
 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] [PATCH v1] x86/domctl: fix typo in comment
Posted by Wei Liu 4 years, 2 months ago
On Tue, Jan 28, 2020 at 04:46:14PM +0100, Olaf Hering wrote:
> The array is named msr_policy.
> 
> Fixes commit 60529dfeca1
> 
> Signed-off-by: Olaf Hering <olaf@aepfle.de>

Acked-by: Wei Liu <wl@xen.org>
Backport: 4.12+

> ---
>  xen/include/public/domctl.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
> index e313da499f..2bb7397923 100644
> --- a/xen/include/public/domctl.h
> +++ b/xen/include/public/domctl.h
> @@ -675,7 +675,7 @@ struct xen_domctl_cpu_policy {
>      uint32_t nr_leaves; /* IN/OUT: Number of leaves in/written to
>                           * 'cpuid_policy'. */
>      uint32_t nr_msrs;   /* IN/OUT: Number of MSRs in/written to
> -                         * 'msr_domain_policy' */
> +                         * 'msr_policy' */
>      XEN_GUEST_HANDLE_64(xen_cpuid_leaf_t) cpuid_policy; /* IN/OUT */
>      XEN_GUEST_HANDLE_64(xen_msr_entry_t) msr_policy;    /* IN/OUT */
>  

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] [PATCH v1] x86/domctl: fix typo in comment
Posted by Jan Beulich 4 years, 2 months ago
On 28.01.2020 17:59, Wei Liu wrote:
> On Tue, Jan 28, 2020 at 04:46:14PM +0100, Olaf Hering wrote:
>> The array is named msr_policy.
>>
>> Fixes commit 60529dfeca1
>>
>> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> 
> Acked-by: Wei Liu <wl@xen.org>
> Backport: 4.12+

Why? This kind of a change hardly warrants a backport imo.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] [PATCH v1] x86/domctl: fix typo in comment
Posted by Wei Liu 4 years, 2 months ago
On Tue, Jan 28, 2020 at 06:00:45PM +0100, Jan Beulich wrote:
> On 28.01.2020 17:59, Wei Liu wrote:
> > On Tue, Jan 28, 2020 at 04:46:14PM +0100, Olaf Hering wrote:
> >> The array is named msr_policy.
> >>
> >> Fixes commit 60529dfeca1
> >>
> >> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> > 
> > Acked-by: Wei Liu <wl@xen.org>
> > Backport: 4.12+
> 
> Why? This kind of a change hardly warrants a backport imo.
> 

I think it would be good if we can keep it in sync, but of course it is
fine to not backport such fix.

Wei.

> Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel