From nobody Mon Feb 9 10:12:27 2026 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1579522913; cv=none; d=zohomail.com; s=zohoarc; b=fYHwEK+0M/IqIFMw0+wFr5C64mKsSiqC4s5SAjsF29axfqVhaD7Pop8BRlCZ6X461Fip1bJPiuuQv65g+t0zswuxkt6QcWiFjjXQjDSAlD8Sv7+IkZRpvD9Gc0vbByiRuKrEtBdyluBg3W3PuVvQxugYrUxE72Poaoa1uWtIf/c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1579522913; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=WnOOIzIaeXEyf+LeaQql17iDcI5wQpPKmNCqU4CbLX0=; b=AgfyWvzroZXseRPU793LfzBivIu2nAj5ChoUObdj9qAZ6aMx5KH9LkgL43tRdTvsC8+/8chJ5jbTXxsjhCVPDF+Gf5s9iRhVW3pqThVadD7wvLHNEnfdFlJynY9HthlTl/l1sqgugbgnXxtOoLQAbaNj1iIHktzeYQTsKGB2GA8= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1579522913052560.286202147746; Mon, 20 Jan 2020 04:21:53 -0800 (PST) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1itW3R-0001Fc-Tg; Mon, 20 Jan 2020 12:21:17 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1itW3P-0001Ek-Qo for xen-devel@lists.xenproject.org; Mon, 20 Jan 2020 12:21:15 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 4eff4ea9-3b7f-11ea-b95e-12813bfff9fa; Mon, 20 Jan 2020 12:20:56 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 9CA52ADB5; Mon, 20 Jan 2020 12:20:55 +0000 (UTC) X-Inumbo-ID: 4eff4ea9-3b7f-11ea-b95e-12813bfff9fa X-Virus-Scanned: by amavisd-new at test-mx.suse.de From: Thomas Zimmermann To: airlied@linux.ie, daniel@ffwll.ch, kraxel@redhat.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, hdegoede@redhat.com, david@lechnology.com, noralf@tronnes.org, sean@poorly.run, oleksandr_andrushchenko@epam.com, sam@ravnborg.org, laurent.pinchart@ideasonboard.com, emil.velikov@collabora.com Date: Mon, 20 Jan 2020 13:20:51 +0100 Message-Id: <20200120122051.25178-5-tzimmermann@suse.de> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200120122051.25178-1-tzimmermann@suse.de> References: <20200120122051.25178-1-tzimmermann@suse.de> MIME-Version: 1.0 Subject: [Xen-devel] [PATCH v3 4/4] drm/udl: Don't set struct drm_crtc_state.no_vblank explictly X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, Thomas Zimmermann , dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" As udl does not initialize vblanking, atomic helpers initialize the value of struct drm_crtc_state.no_vblank to be true. No need to set it from within the driver. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/udl/udl_modeset.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/drivers/gpu/drm/udl/udl_modeset.c b/drivers/gpu/drm/udl/udl_mo= deset.c index 22af17959053..d59ebac70b15 100644 --- a/drivers/gpu/drm/udl/udl_modeset.c +++ b/drivers/gpu/drm/udl/udl_modeset.c @@ -375,8 +375,6 @@ udl_simple_display_pipe_enable(struct drm_simple_displa= y_pipe *pipe, char *wrptr; int color_depth =3D UDL_COLOR_DEPTH_16BPP; =20 - crtc_state->no_vblank =3D true; - buf =3D (char *)udl->mode_buf; =20 /* This first section has to do with setting the base address on the @@ -428,14 +426,6 @@ udl_simple_display_pipe_disable(struct drm_simple_disp= lay_pipe *pipe) udl_submit_urb(dev, urb, buf - (char *)urb->transfer_buffer); } =20 -static int -udl_simple_display_pipe_check(struct drm_simple_display_pipe *pipe, - struct drm_plane_state *plane_state, - struct drm_crtc_state *crtc_state) -{ - return 0; -} - static void udl_simple_display_pipe_update(struct drm_simple_display_pipe *pipe, struct drm_plane_state *old_plane_state) @@ -457,7 +447,6 @@ struct drm_simple_display_pipe_funcs udl_simple_display= _pipe_funcs =3D { .mode_valid =3D udl_simple_display_pipe_mode_valid, .enable =3D udl_simple_display_pipe_enable, .disable =3D udl_simple_display_pipe_disable, - .check =3D udl_simple_display_pipe_check, .update =3D udl_simple_display_pipe_update, .prepare_fb =3D drm_gem_fb_simple_display_pipe_prepare_fb, }; --=20 2.24.1 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel