From nobody Sat May 4 11:11:43 2024 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1579103839; cv=none; d=zohomail.com; s=zohoarc; b=O/+MhsNSEHfgEheQRdIbm8FiqPxaw9mCp5xY6R7mV0r+aBt+DZVpa9lremi/Z8uV2BCUOIAkTurhlMUAzRkojSXCmv03FRVkrm4wxfPm2BYv6GBRMhI4O8q1UP+txphp4JZRk2foydKQ00rn1QdnVMnc5+qjxpNcd0o8WdNEgFw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1579103839; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=Iy1w7cQ0k8Ukl2WGjGrXmzXJmV1ITgQTw/fi+II4D+M=; b=N/PTy3b27B2pgBzsTod861V7yT5kfeM1Fx9p14e5ZeCL9xCaSHOfjZxfM3zqwUbR9tpJzOck2CABfGVoJfQJvp5ezTWlMaZ1BYpgE+Y0XX2b5MTnC8amBciuvqdJpG4SKQviTIiqoBNaOKC2w+/o6QKWKPSRzqQMjl0nZ7KXr/w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 157910383968997.01364996996665; Wed, 15 Jan 2020 07:57:19 -0800 (PST) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1irl29-00014f-91; Wed, 15 Jan 2020 15:56:41 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1irl27-00014a-C5 for xen-devel@lists.xenproject.org; Wed, 15 Jan 2020 15:56:39 +0000 Received: from mail-pf1-x442.google.com (unknown [2607:f8b0:4864:20::442]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 9d23ef90-37af-11ea-b89f-bc764e2007e4; Wed, 15 Jan 2020 15:56:38 +0000 (UTC) Received: by mail-pf1-x442.google.com with SMTP id w62so8712102pfw.8 for ; Wed, 15 Jan 2020 07:56:38 -0800 (PST) Received: from madhuparna-HP-Notebook.nitk.ac.in ([2402:3a80:1ee8:ed72:75ba:e01f:bdbc:c547]) by smtp.gmail.com with ESMTPSA id b8sm22755599pfr.64.2020.01.15.07.56.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jan 2020 07:56:37 -0800 (PST) X-Inumbo-ID: 9d23ef90-37af-11ea-b89f-bc764e2007e4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=HwV9sGACUDknSqn3rZRjdfv8PQfY2jtJrBDpPLg25bE=; b=pfZQgYjBcjyCtn6E2E//UIWWV7YF8uAjc6ggh4p5mbPc/GNDh/t8TClwCoKqEY9iKm 31WcNv/TU4fwcs85/hvITBoBQwLVXKXc/pq1wY9AFtXF2yclNcKLougfpxo4Rk7HthPf JKGNTLguhyvB97/Am9L/CUP3MrCj/46w4fxjcRfkXO25T4sy6vMUxLTAtfX+DvZ+ztaN 0TJinWp2KwiFxkOa5ztbYrQZYs73Hv1EuT6dgymCzvzr+fdm6LEZUH2G+6yYELu7EAOO KM6yEegZ79mbzuNRVufVKJ2z4+wCZyjhs7MRMvV9HWkgyOvBGAQgQiMD9SVbFGb4EqZn upRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=HwV9sGACUDknSqn3rZRjdfv8PQfY2jtJrBDpPLg25bE=; b=FSwen/eE0jIsoCBDlP7QVB+d2Q3exsL723sTA5nVezBsjU5/RXTxK4HyCOKPuvD+Fk 2pklKs+LsJz7fRGbEBtt+cFbeDCFUWLih75SC/UCIxg9G7Dr5gRSi97jEZq6ICPcQY/1 3oiAd8JOOD87f1AdxvMXEEq6HEI0qahBO8TQXiv9THTbkF0pJQ9iO0EUUwPOB5dI0Un7 3sdi7ZmrojkiIKHWJHtPht/8e+982E8DqaS6dQBhD7JnFYIDmg1S5pd37hRixVd8e7AX RLKUIHfpUdC9XYqDf+Zx9BgWAKD5vOrfa41/WW2Ts7Yyyz7/qb/lpQidfqdrp2uH+2df FnSQ== X-Gm-Message-State: APjAAAVzNKwo10zWny8vKUBPshM2A6Cia6Idj8q/kbl5KoI4yatiNtOL 0uI+i2EJrwFPoe+zVWefI48= X-Google-Smtp-Source: APXvYqwfBfFNxEYPBk1P4r0u33EcwZqChtsYsDBcPVXmULzU6XIoKIK5xPGRQ8bZGAylr4brUje92g== X-Received: by 2002:a63:4b50:: with SMTP id k16mr34152524pgl.386.1579103797712; Wed, 15 Jan 2020 07:56:37 -0800 (PST) From: madhuparnabhowmik04@gmail.com To: wei.liu@kernel.org, paul@xen.org Date: Wed, 15 Jan 2020 21:25:53 +0530 Message-Id: <20200115155553.13471-1-madhuparnabhowmik04@gmail.com> X-Mailer: git-send-email 2.17.1 Subject: [Xen-devel] [PATCH] net: xen-netback: hash.c: Use built-in RCU list checking X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: paulmck@kernel.org, frextrite@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, joel@joelfernandes.org, xen-devel@lists.xenproject.org, linux-kernel-mentees@lists.linuxfoundation.org, Madhuparna Bhowmik MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Madhuparna Bhowmik list_for_each_entry_rcu has built-in RCU and lock checking. Pass cond argument to list_for_each_entry_rcu. Signed-off-by: Madhuparna Bhowmik Acked-by: Wei Liu --- drivers/net/xen-netback/hash.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/xen-netback/hash.c b/drivers/net/xen-netback/hash.c index 10d580c3dea3..6b7532f7c936 100644 --- a/drivers/net/xen-netback/hash.c +++ b/drivers/net/xen-netback/hash.c @@ -51,7 +51,8 @@ static void xenvif_add_hash(struct xenvif *vif, const u8 = *tag, =20 found =3D false; oldest =3D NULL; - list_for_each_entry_rcu(entry, &vif->hash.cache.list, link) { + list_for_each_entry_rcu(entry, &vif->hash.cache.list, link, + lockdep_is_held(&vif->hash.cache.lock)) { /* Make sure we don't add duplicate entries */ if (entry->len =3D=3D len && memcmp(entry->tag, tag, len) =3D=3D 0) @@ -102,7 +103,8 @@ static void xenvif_flush_hash(struct xenvif *vif) =20 spin_lock_irqsave(&vif->hash.cache.lock, flags); =20 - list_for_each_entry_rcu(entry, &vif->hash.cache.list, link) { + list_for_each_entry_rcu(entry, &vif->hash.cache.list, link, + lockdep_is_held(&vif->hash.cache.lock)) { list_del_rcu(&entry->link); vif->hash.cache.count--; kfree_rcu(entry, rcu); --=20 2.17.1 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel