From nobody Tue Apr 23 15:28:04 2024 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1578911989; cv=none; d=zohomail.com; s=zohoarc; b=XgBbQwzsWcOYLE2m8MWx/MsKyHv4hjjx4auwbGTSR8nKuxCCNu1CGeHK0+QFl1gKFuEUzfQMVGgbhTSdO3SGVL2AGAK16V6UrglV3AZR/tZLafCVcv8tKAhTuY0nhg197U3lCFI0kdnLu+b+oDn21g7e9zJ12dLIBrl5r0lmVkA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1578911989; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=nqfYNXglE59xvFuQztuXn+STmu3o4ZZhx4ehNVUudDQ=; b=G/eUSJ08thuXya13wwakMmHiite6tL0ejHxXEzWuYTOq87ayBTlCRcV4hrHLRffOg5aaNCay9xYi973m/1SRFPMA5wczCF8WCLtis5tnE7fWsm2h5AcVfdjTk6JJl4WM/dxNQf7k0B3/Lz7JNdeLFzkU6oHRrp9l5StLgEAcxBc= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1578911989032353.8943659656443; Mon, 13 Jan 2020 02:39:49 -0800 (PST) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iqx7s-0007bw-7f; Mon, 13 Jan 2020 10:39:16 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iqx7M-0007aA-5i for xen-devel@lists.xenproject.org; Mon, 13 Jan 2020 10:38:44 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d771ebd6-35f0-11ea-b89f-bc764e2007e4; Mon, 13 Jan 2020 10:38:31 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id BC818B167; Mon, 13 Jan 2020 10:38:29 +0000 (UTC) X-Inumbo-ID: d771ebd6-35f0-11ea-b89f-bc764e2007e4 X-Virus-Scanned: by amavisd-new at test-mx.suse.de From: Thomas Zimmermann To: airlied@linux.ie, daniel@ffwll.ch, kraxel@redhat.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, hdegoede@redhat.com, david@lechnology.com, noralf@tronnes.org, sean@poorly.run, oleksandr_andrushchenko@epam.com, sam@ravnborg.org, laurent.pinchart@ideasonboard.com, emil.velikov@collabora.com Date: Mon, 13 Jan 2020 11:38:19 +0100 Message-Id: <20200113103822.24473-2-tzimmermann@suse.de> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200113103822.24473-1-tzimmermann@suse.de> References: <20200113103822.24473-1-tzimmermann@suse.de> MIME-Version: 1.0 X-Mailman-Approved-At: Mon, 13 Jan 2020 10:39:14 +0000 Subject: [Xen-devel] [PATCH v2 1/4] drm: Document struct drm_crtc_state.no_vblank for faking VBLANK events X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, dri-devel@lists.freedesktop.or, Thomas Zimmermann , virtualization@lists.linux-foundation.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Drivers for CRTC hardware without support for VBLANK interrupts can set struct drm_crtc_state.no_vblank and let DRM's atomic commit helpers generate the VBLANK events automatically. Document this in order to make it official. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_atomic_helper.c | 4 +++- include/drm/drm_crtc.h | 9 +++++++-- include/drm/drm_simple_kms_helper.h | 7 +++++-- 3 files changed, 15 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atom= ic_helper.c index 4511c2e07bb9..ce30a37971e4 100644 --- a/drivers/gpu/drm/drm_atomic_helper.c +++ b/drivers/gpu/drm/drm_atomic_helper.c @@ -2215,7 +2215,9 @@ EXPORT_SYMBOL(drm_atomic_helper_wait_for_dependencies= ); * when a job is queued, and any change to the pipeline that does not touc= h the * connector is leading to timeouts when calling * drm_atomic_helper_wait_for_vblanks() or - * drm_atomic_helper_wait_for_flip_done(). + * drm_atomic_helper_wait_for_flip_done(). In addition to writeback + * connectors, this function can also fake VBLANK events for CRTCs without + * VBLANK interrupt. * * This is part of the atomic helper support for nonblocking commits, see * drm_atomic_helper_setup_commit() for an overview. diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h index 5e9b15a0e8c5..01caf5160596 100644 --- a/include/drm/drm_crtc.h +++ b/include/drm/drm_crtc.h @@ -179,7 +179,9 @@ struct drm_crtc_state { * In this case the VBLANK event is only generated when a job is queued * to the writeback connector, and we want the core to fake VBLANK * events when this part of the pipeline hasn't changed but others had - * or when the CRTC and connectors are being disabled. + * or when the CRTC and connectors are being disabled. In addition to + * writeback connectors, this function can also fake VBLANK events for + * CRTCs without VBLANK interrupt. * * __drm_atomic_helper_crtc_duplicate_state() will not reset the value * from the current state, the CRTC driver is then responsible for @@ -335,7 +337,10 @@ struct drm_crtc_state { * - Events for disabled CRTCs are not allowed, and drivers can ignore * that case. * - * This can be handled by the drm_crtc_send_vblank_event() function, + * For very simple hardware without VBLANK interrupt, enabling + * &struct drm_crtc_state.no_vblank makes DRM's atomic commit helpers + * send the event at an appropriate time. For more complex hardware this + * can be handled by the drm_crtc_send_vblank_event() function, * which the driver should call on the provided event upon completion of * the atomic commit. Note that if the driver supports vblank signalling * and timestamping the vblank counters and timestamps must agree with diff --git a/include/drm/drm_simple_kms_helper.h b/include/drm/drm_simple_k= ms_helper.h index 15afee9cf049..e253ba7bea9d 100644 --- a/include/drm/drm_simple_kms_helper.h +++ b/include/drm/drm_simple_kms_helper.h @@ -100,8 +100,11 @@ struct drm_simple_display_pipe_funcs { * This is the function drivers should submit the * &drm_pending_vblank_event from. Using either * drm_crtc_arm_vblank_event(), when the driver supports vblank - * interrupt handling, or drm_crtc_send_vblank_event() directly in case - * the hardware lacks vblank support entirely. + * interrupt handling, or drm_crtc_send_vblank_event() for more + * complex case. In case the hardware lacks vblank support entirely, + * drivers can set &struct drm_crtc_state.no_vblank in + * &struct drm_simple_display_pipe_funcs.check and let DRM's + * atomic helper fake a vblank event. */ void (*update)(struct drm_simple_display_pipe *pipe, struct drm_plane_state *old_plane_state); --=20 2.24.1 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel From nobody Tue Apr 23 15:28:04 2024 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1578911988; cv=none; d=zohomail.com; s=zohoarc; b=cp07rbE/R+B6JEa1wMLt74al25fo48jQ14EdoNgyvU+gn+VJ9emHHiaj45MqdLg37m8yT6Ap0LGC1zsE7fw90fD+0ABLcVYsGPihpqsaOFVIrysIg5cJI4Nyyqu/yzIRq7KbFUT3CTHhtrbSawSEbvAr2/7CS39afJV4po4RsHs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1578911988; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=/rwjOsGgo0dD0KmKaTdtvs7gDR3su/5qp2pjlvWX5Bg=; b=fEYXdh8okBUpjOvUmCWk6o5i8/NFAyCNiV+lTRfXqE809eEg0n52b373Kl6xHJh+2u375wwG7y028nA8dCbuHG/4l0lj4B875wYrDP+uWAU/yh8+GXOkjRWYv4GcpJJ/85B1PQ6gRj0JIqOWgFBJlG/HMlgl/q6iOLHQSRRlwUk= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1578911988971363.33063230898995; Mon, 13 Jan 2020 02:39:48 -0800 (PST) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iqx7r-0007bY-1M; Mon, 13 Jan 2020 10:39:15 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iqx7A-0007Z6-JM for xen-devel@lists.xenproject.org; Mon, 13 Jan 2020 10:38:32 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id d74f3e4c-35f0-11ea-8249-12813bfff9fa; Mon, 13 Jan 2020 10:38:31 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id BC65CAD5C; Mon, 13 Jan 2020 10:38:29 +0000 (UTC) X-Inumbo-ID: d74f3e4c-35f0-11ea-8249-12813bfff9fa X-Virus-Scanned: by amavisd-new at test-mx.suse.de From: Thomas Zimmermann To: airlied@linux.ie, daniel@ffwll.ch, kraxel@redhat.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, hdegoede@redhat.com, david@lechnology.com, noralf@tronnes.org, sean@poorly.run, oleksandr_andrushchenko@epam.com, sam@ravnborg.org, laurent.pinchart@ideasonboard.com, emil.velikov@collabora.com Date: Mon, 13 Jan 2020 11:38:20 +0100 Message-Id: <20200113103822.24473-3-tzimmermann@suse.de> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200113103822.24473-1-tzimmermann@suse.de> References: <20200113103822.24473-1-tzimmermann@suse.de> MIME-Version: 1.0 X-Mailman-Approved-At: Mon, 13 Jan 2020 10:39:14 +0000 Subject: [Xen-devel] [PATCH v2 2/4] drm/ast: Set struct drm_crtc_state.no_vblank in atomic_check() X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, dri-devel@lists.freedesktop.or, Thomas Zimmermann , virtualization@lists.linux-foundation.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" CRTC state properties should be computed in atomic_check(). Do so for the no_vblank field. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_mode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c index 34608f0499eb..ef7a0b08cc05 100644 --- a/drivers/gpu/drm/ast/ast_mode.c +++ b/drivers/gpu/drm/ast/ast_mode.c @@ -800,6 +800,8 @@ static int ast_crtc_helper_atomic_check(struct drm_crtc= *crtc, return -EINVAL; } =20 + state->no_vblank =3D true; + ast_state =3D to_ast_crtc_state(state); =20 format =3D ast_state->format; @@ -833,8 +835,6 @@ static void ast_crtc_helper_atomic_flush(struct drm_crt= c *crtc, struct ast_vbios_mode_info *vbios_mode_info; struct drm_display_mode *adjusted_mode; =20 - crtc->state->no_vblank =3D true; - ast_state =3D to_ast_crtc_state(crtc->state); =20 format =3D ast_state->format; --=20 2.24.1 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel From nobody Tue Apr 23 15:28:04 2024 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1578911987; cv=none; d=zohomail.com; s=zohoarc; b=K/l7FpRsLxoqXNh642wEnKcxIhx6cxcowELgGKyzQiLstbgExp4pu5ycFwZhUHkzEh53y9C9G/hYrLbBCN4aB2uJpCeeUe3VmpgmZ7iEGmYa1p0fxm+obE5PZYLSWfVKC2mPKHLtBofzO85M6+k/SCt6slA9ZopmC/7yY5TbjW4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1578911987; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ntCGX6oVymCmnDTkqz+6QIBp1dVx4l0B0TIEJuamBN8=; b=jnl4YWaZ0Iwumg/6bA+RJQCx+xctOc/R7pVjjHA6CSul789lX9emzGZSpeRuLX9Jbr+/ogVcYP1CNmr8Q4aC524gHAkgRbLNfS1Xj2iIX877oD1dmAD+7plJYUwLI9mfctatDS4Dcod1jme8kWK3HsAZO5kynJQfetJIXKtQj1k= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1578911987071930.5958736678988; Mon, 13 Jan 2020 02:39:47 -0800 (PST) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iqx7r-0007bk-L0; Mon, 13 Jan 2020 10:39:15 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iqx7I-0007Zt-6Z for xen-devel@lists.xenproject.org; Mon, 13 Jan 2020 10:38:40 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d74f2484-35f0-11ea-b89f-bc764e2007e4; Mon, 13 Jan 2020 10:38:31 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id BC717B150; Mon, 13 Jan 2020 10:38:29 +0000 (UTC) X-Inumbo-ID: d74f2484-35f0-11ea-b89f-bc764e2007e4 X-Virus-Scanned: by amavisd-new at test-mx.suse.de From: Thomas Zimmermann To: airlied@linux.ie, daniel@ffwll.ch, kraxel@redhat.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, hdegoede@redhat.com, david@lechnology.com, noralf@tronnes.org, sean@poorly.run, oleksandr_andrushchenko@epam.com, sam@ravnborg.org, laurent.pinchart@ideasonboard.com, emil.velikov@collabora.com Date: Mon, 13 Jan 2020 11:38:21 +0100 Message-Id: <20200113103822.24473-4-tzimmermann@suse.de> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200113103822.24473-1-tzimmermann@suse.de> References: <20200113103822.24473-1-tzimmermann@suse.de> MIME-Version: 1.0 X-Mailman-Approved-At: Mon, 13 Jan 2020 10:39:14 +0000 Subject: [Xen-devel] [PATCH v2 3/4] drm/cirrus: Let DRM core send VBLANK events X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, dri-devel@lists.freedesktop.or, Thomas Zimmermann , virtualization@lists.linux-foundation.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" In drm_atomic_helper_fake_vblank(), the DRM core sends out VBLANK events if struct drm_crtc_state.no_vblank is enabled. Replace cirrus' VBLANK events with the DRM core's functionality. v2: * set struct_drm_crtc_state.no_vblank in cirrus_pipe_check() Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/cirrus/cirrus.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/cirrus/cirrus.c b/drivers/gpu/drm/cirrus/cirru= s.c index 248c9f765c45..5ff15e8a2a0a 100644 --- a/drivers/gpu/drm/cirrus/cirrus.c +++ b/drivers/gpu/drm/cirrus/cirrus.c @@ -38,7 +38,6 @@ #include #include #include -#include =20 #define DRIVER_NAME "cirrus" #define DRIVER_DESC "qemu cirrus vga" @@ -404,6 +403,8 @@ static int cirrus_pipe_check(struct drm_simple_display_= pipe *pipe, { struct drm_framebuffer *fb =3D plane_state->fb; =20 + crtc_state->no_vblank =3D true; + if (!fb) return 0; return cirrus_check_size(fb->width, fb->height, fb); @@ -434,13 +435,6 @@ static void cirrus_pipe_update(struct drm_simple_displ= ay_pipe *pipe, =20 if (drm_atomic_helper_damage_merged(old_state, state, &rect)) cirrus_fb_blit_rect(pipe->plane.state->fb, &rect); - - if (crtc->state->event) { - spin_lock_irq(&crtc->dev->event_lock); - drm_crtc_send_vblank_event(crtc, crtc->state->event); - crtc->state->event =3D NULL; - spin_unlock_irq(&crtc->dev->event_lock); - } } =20 static const struct drm_simple_display_pipe_funcs cirrus_pipe_funcs =3D { --=20 2.24.1 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel From nobody Tue Apr 23 15:28:04 2024 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1578911990; cv=none; d=zohomail.com; s=zohoarc; b=R1vv0OJf1sN3hA8n8HXRBgAMmnlA18Duf1LFjAnhoOIqyVUoTd/KOkBR7EmE1A6uY0KLrVcWcRJXiz1KIesihuWZylOIGcwEIsaenwCrDog13oqQ2s7lg5iUaxEoe95W2ZX60a3ZG8yRMFlCxmpqxNr91SLUB6uQv5QsaY1la7c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1578911990; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=KwqPP/DqeeImL9d/xGblBNYiu8i38+PU/Jg1RZoqlCA=; b=hJ93H7+ytLQNuYtg7ZSjZf9dsPxhwOdtWgH6DJ+p8f25LhKRbPiallON37kgS4nX6W/+oC1+DXAbUBFmnQkBDjimQCq17SxZcpsYj5CbUM40lR8yyXq2FMzF5631g1u8Gd45545SHvrXWeUjx3gFxcLbMyYSNNqKAo4CchB89yo= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1578911990711375.3492828297226; Mon, 13 Jan 2020 02:39:50 -0800 (PST) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iqx7r-0007bq-UP; Mon, 13 Jan 2020 10:39:15 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iqx7K-0007Zy-Hs for xen-devel@lists.xenproject.org; Mon, 13 Jan 2020 10:38:42 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id d74f4253-35f0-11ea-8249-12813bfff9fa; Mon, 13 Jan 2020 10:38:31 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id C3522B18C; Mon, 13 Jan 2020 10:38:29 +0000 (UTC) X-Inumbo-ID: d74f4253-35f0-11ea-8249-12813bfff9fa X-Virus-Scanned: by amavisd-new at test-mx.suse.de From: Thomas Zimmermann To: airlied@linux.ie, daniel@ffwll.ch, kraxel@redhat.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, hdegoede@redhat.com, david@lechnology.com, noralf@tronnes.org, sean@poorly.run, oleksandr_andrushchenko@epam.com, sam@ravnborg.org, laurent.pinchart@ideasonboard.com, emil.velikov@collabora.com Date: Mon, 13 Jan 2020 11:38:22 +0100 Message-Id: <20200113103822.24473-5-tzimmermann@suse.de> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200113103822.24473-1-tzimmermann@suse.de> References: <20200113103822.24473-1-tzimmermann@suse.de> MIME-Version: 1.0 X-Mailman-Approved-At: Mon, 13 Jan 2020 10:39:14 +0000 Subject: [Xen-devel] [PATCH v2 4/4] drm/simple-kms: Let DRM core send VBLANK events by default X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, dri-devel@lists.freedesktop.or, Thomas Zimmermann , virtualization@lists.linux-foundation.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" In drm_atomic_helper_fake_vblank() the DRM core sends out VBLANK events if struct drm_crtc_state.no_vblank is enabled in the check() callbacks. For drivers that have neither an enable_vblank() callback nor a check() callback, the simple-KMS helpers enable VBLANK generation by default. This simplifies bochs, udl, several tiny drivers, and drivers based upon MIPI DPI helpers. The driver for Xen explicitly disables no_vblank, as it has its own logic for sending these events. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/bochs/bochs_kms.c | 9 --------- drivers/gpu/drm/drm_mipi_dbi.c | 9 --------- drivers/gpu/drm/drm_simple_kms_helper.c | 19 +++++++++++++++---- drivers/gpu/drm/tiny/gm12u320.c | 9 --------- drivers/gpu/drm/tiny/ili9225.c | 9 --------- drivers/gpu/drm/tiny/repaper.c | 9 --------- drivers/gpu/drm/tiny/st7586.c | 9 --------- drivers/gpu/drm/udl/udl_modeset.c | 11 ----------- drivers/gpu/drm/xen/xen_drm_front_kms.c | 13 +++++++++++++ 9 files changed, 28 insertions(+), 69 deletions(-) diff --git a/drivers/gpu/drm/bochs/bochs_kms.c b/drivers/gpu/drm/bochs/boch= s_kms.c index 3f0006c2470d..ff275faee88d 100644 --- a/drivers/gpu/drm/bochs/bochs_kms.c +++ b/drivers/gpu/drm/bochs/bochs_kms.c @@ -7,7 +7,6 @@ #include #include #include -#include =20 #include "bochs.h" =20 @@ -57,16 +56,8 @@ static void bochs_pipe_update(struct drm_simple_display_= pipe *pipe, struct drm_plane_state *old_state) { struct bochs_device *bochs =3D pipe->crtc.dev->dev_private; - struct drm_crtc *crtc =3D &pipe->crtc; =20 bochs_plane_update(bochs, pipe->plane.state); - - if (crtc->state->event) { - spin_lock_irq(&crtc->dev->event_lock); - drm_crtc_send_vblank_event(crtc, crtc->state->event); - crtc->state->event =3D NULL; - spin_unlock_irq(&crtc->dev->event_lock); - } } =20 static const struct drm_simple_display_pipe_funcs bochs_pipe_funcs =3D { diff --git a/drivers/gpu/drm/drm_mipi_dbi.c b/drivers/gpu/drm/drm_mipi_dbi.c index 16bff1be4b8a..13b753cb3f67 100644 --- a/drivers/gpu/drm/drm_mipi_dbi.c +++ b/drivers/gpu/drm/drm_mipi_dbi.c @@ -24,7 +24,6 @@ #include #include #include -#include #include