From nobody Mon Feb 9 12:43:28 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail(p=none dis=none) header.from=eu.citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1578662987; cv=none; d=zohomail.com; s=zohoarc; b=cXLx6r1BQBx6kidAyPAtbhKDbqI96vUefd+DAds6oBeg4eo7xki+bl//I27zr7RSxgh7QBc/i6NGkhES9RYDrqppSafa6bl25QwTLiFJwTTwe/JbJWmBTbmD8FknFWNFKMl/4GrKCMvwCCJm+UOHtjUdV0nD5A5jSVTBBSTCaQs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1578662987; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=oF9HSi/wErUPS9iJzowXf8NBtKTj23pEyJ5kOO+OR4c=; b=Y6AXmNGQ4e05SrEzo2If4Lu+rRivO2OZRb/SNkdQ5q87NRmsv8RoJAF12ZJJh3DxNmJS7ZKrv+LVtYcqPC3bSgz1QEnTqrED8m7gDad1MV288xmMAJi0ri3+TvCEGWIEx54TfxRjpr9qQSleZ4T3nlMH6FX855jrkGC1EWe32yA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1578662987820543.7320758967373; Fri, 10 Jan 2020 05:29:47 -0800 (PST) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1ipuLk-0001yc-B9; Fri, 10 Jan 2020 13:29:16 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1ipuLi-0001yV-EB for xen-devel@lists.xenproject.org; Fri, 10 Jan 2020 13:29:14 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 2de1f9fe-33ad-11ea-bf0f-12813bfff9fa; Fri, 10 Jan 2020 13:29:09 +0000 (UTC) X-Inumbo-ID: 2de1f9fe-33ad-11ea-bf0f-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1578662950; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=QeHPkOUBfk70JdbVTXptof0PmHLZHWYWptt6avVA7Sg=; b=an9QWLM9gP4evbdV0hKk+vrpWNdpE4wsL5JUP8Bpn0Hu4E1Avcfjkvw8 KmTbznnmC8qrV8bn/gwrBs2r0C1yI0iJ8MasVnJ94GSIlXuSGiVg7JCX+ m3QVNXScXELg9pZrp4KHiB9gKAk0L6hbJo40zXj7HdRTfJJvjKEZQJMPT o=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=ian.jackson@eu.citrix.com; spf=Pass smtp.mailfrom=Ian.Jackson@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of ian.jackson@eu.citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="Ian.Jackson@citrix.com"; x-sender="ian.jackson@eu.citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa2.hc3370-68.iphmx.com: domain of Ian.Jackson@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="Ian.Jackson@citrix.com"; x-sender="Ian.Jackson@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="Ian.Jackson@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: 6CpU5zRGaaHI+VT/w5qCQ3Bt27sYC3t1yoTqNoBW3RBLNJyomcRBsGRbHgnsmJR7cyMBojRaZt a4BNULAAQ5UsAv8Zu27Nfc3h5gzfT0Ap2zClQD3iP5ycj3srgoOCjjFs0+i4ShLM/yKJ9K12MA JDk3rW1TrJLQ/R4RA42QZzmz8lEuLyyPQ46JT+R4I/gqWrmmSobjjvCBdhQl20V9P/3EkzuF4G mOKc+H5lPSqeareMgTfTpVrGZmpsVOvRSqIVKrjsXGXVAbjxfVfRSKYoz+NVazY4rjCZ0HzGLF DWs= X-SBRS: 2.7 X-MesageID: 10756442 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.69,417,1571716800"; d="scan'208";a="10756442" From: Ian Jackson To: Date: Fri, 10 Jan 2020 13:28:55 +0000 Message-ID: <20200110132902.29295-2-ian.jackson@eu.citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20200110132902.29295-1-ian.jackson@eu.citrix.com> References: <20200110132902.29295-1-ian.jackson@eu.citrix.com> MIME-Version: 1.0 Subject: [Xen-devel] [PATCH 1/8] libxl: event: Rename poller.fds_changed to .fds_deregistered X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Anthony PERARD , Ian Jackson , George Dunlap , Wei Liu Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) This is only for deregistration. We are going to add another variable for new events, with different semantics, and this overly-general name will become confusing. Signed-off-by: Ian Jackson --- tools/libxl/libxl_event.c | 8 ++++---- tools/libxl/libxl_internal.h | 6 +++--- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/tools/libxl/libxl_event.c b/tools/libxl/libxl_event.c index aa8b7d1945..1210c1bfb3 100644 --- a/tools/libxl/libxl_event.c +++ b/tools/libxl/libxl_event.c @@ -239,7 +239,7 @@ void libxl__ev_fd_deregister(libxl__gc *gc, libxl__ev_f= d *ev) ev->fd =3D -1; =20 LIBXL_LIST_FOREACH(poller, &CTX->pollers_fds_changed, fds_changed_entr= y) - poller->fds_changed =3D 1; + poller->fds_deregistered =3D 1; =20 out: CTX_UNLOCK; @@ -1120,7 +1120,7 @@ static int beforepoll_internal(libxl__gc *gc, libxl__= poller *poller, =20 *nfds_io =3D used; =20 - poller->fds_changed =3D 0; + poller->fds_deregistered =3D 0; =20 libxl__ev_time *etime =3D LIBXL_TAILQ_FIRST(&CTX->etimes); if (etime) { @@ -1186,7 +1186,7 @@ static int afterpoll_check_fd(libxl__poller *poller, /* again, stale slot entry */ continue; =20 - assert(poller->fds_changed || !(fds[slot].revents & POLLNVAL)); + assert(poller->fds_deregistered || !(fds[slot].revents & POLLNVAL)= ); =20 /* we mask in case requested events have changed */ int slot_revents =3D fds[slot].revents & events; @@ -1626,7 +1626,7 @@ int libxl__poller_init(libxl__gc *gc, libxl__poller *= p) int rc; p->fd_polls =3D 0; p->fd_rindices =3D 0; - p->fds_changed =3D 0; + p->fds_deregistered =3D 0; =20 rc =3D libxl__pipe_nonblock(CTX, p->wakeup_pipe); if (rc) goto out; diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h index ba8c9b41ab..c5b71d15f0 100644 --- a/tools/libxl/libxl_internal.h +++ b/tools/libxl/libxl_internal.h @@ -629,14 +629,14 @@ struct libxl__poller { /* * We also use the poller to record whether any fds have been * deregistered since we entered poll. Each poller which is not - * idle is on the list pollers_fds_changed. fds_changed is + * idle is on the list pollers_fds_changed. fds_deregistered is * cleared by beforepoll, and tested by afterpoll. Whenever an fd - * event is deregistered, we set the fds_changed of all non-idle + * event is deregistered, we set the fds_deregistered of all non-idle * pollers. So afterpoll can tell whether any POLLNVAL is * plausibly due to an fd being closed and reopened. */ LIBXL_LIST_ENTRY(libxl__poller) fds_changed_entry; - bool fds_changed; + bool fds_deregistered; }; =20 struct libxl__gc { --=20 2.11.0 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel