From nobody Sat May 4 18:33:08 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail(p=none dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1578317245; cv=none; d=zohomail.com; s=zohoarc; b=j1PBPTKCf3xm0SPELRt2qQrmcmgIkFweOXP/fa8Q36dpopXspFhuG2xuagwbzTDFCPDPYdHn53DIn6gD/Z9kuYkMlmyao/I6sfplwBunN8/1yUYn8fDmOYWRnBWu5AQaMhnLP30jmZPBrU7GqKbjjeXzV24wmO8cnw2bJAVKS7w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1578317245; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=SvzA62u3VJUUUCuDVUJARsf+/m0QU8jR4LhOw0rV5uo=; b=Mto8268p1nS5L01aCLgeZ0qf+a8Wzc3t8El2O5/wLvT/ywzBOVoFDYVUF8QIPHzLGFn5Dp/tcRFPO7G8nfuzjrynrZVrEj15E2hfBm64YTe0DW359/NP8JWsGW21LyJrMhHOH5bcyNTJPKDmZA/SO0+Fir2YmEsr8to/mzBW7Xs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1578317245383951.6350197223389; Mon, 6 Jan 2020 05:27:25 -0800 (PST) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1ioSOk-0005dr-PJ; Mon, 06 Jan 2020 13:26:22 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1ioSOj-0005d7-Nu for xen-devel@lists.xenproject.org; Mon, 06 Jan 2020 13:26:21 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 1e7763a8-3088-11ea-ab05-12813bfff9fa; Mon, 06 Jan 2020 13:26:17 +0000 (UTC) X-Inumbo-ID: 1e7763a8-3088-11ea-ab05-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1578317178; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=HCyEfPOFjCrTqTXFF6h3hqdw8I3qGXNBZIcXHYkdNDI=; b=UOectS0Xp+IYNlT1Tul6uHCdDYQZYvXkuBT6xWnv9xR/t4frEnD6uBjS L2Ro3U6GVc8uxBkaHkX7308MhBqTOGaG9PixYLDkmwLEdEuNzzL7D2gwh qHQHS2Tay9xDWj9cC35F8uYyokeJeD7xBzWg2gpnCU9fAfyXl4BK08t1C c=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=andrew.cooper3@citrix.com; spf=Pass smtp.mailfrom=Andrew.Cooper3@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: None (esa1.hc3370-68.iphmx.com: no sender authenticity information available from domain of andrew.cooper3@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa1.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="andrew.cooper3@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa1.hc3370-68.iphmx.com: domain of Andrew.Cooper3@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa1.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="Andrew.Cooper3@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa1.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa1.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: w4PMUsjVeUZgZZSDGHgPR6TNw4Y1trp/iiNVVL1uGjcfspr1NTYazFS+7y4TtwUipyx8kwAbat 2I38wUdFO6ekPKeUXgdABd9c9DV/MQ9r9LFBmHuhJuEtojGHEI+SCYmU/4MiNyiKNF/HujzRBE qV+BAK4fYAB3+qnSy28nPn5WTlmAc0NQQTUPqdCnYiuffgKdDkrQUAXDG5MPfG/s7odMjapeHw zyG8h0D/wVcDNcdhPQcsNzNDSz0SopmGzqrIfJtNAyKTB5nhYNSgXVjUyfTxnOvT0l6ypC0QC4 IJQ= X-SBRS: 2.7 X-MesageID: 10647200 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.69,402,1571716800"; d="scan'208";a="10647200" From: Andrew Cooper To: Xen-devel Date: Mon, 6 Jan 2020 13:26:14 +0000 Message-ID: <20200106132614.25583-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Subject: [Xen-devel] [PATCH] x86/smpboot: Use printk_once() rather than opencoding it X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Wei Liu , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Shrink the text to be less verbose. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich --- CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monn=C3=A9 --- xen/arch/x86/smpboot.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/xen/arch/x86/smpboot.c b/xen/arch/x86/smpboot.c index a7e7013097..7e29704080 100644 --- a/xen/arch/x86/smpboot.c +++ b/xen/arch/x86/smpboot.c @@ -1291,14 +1291,11 @@ int cpu_add(uint32_t apic_id, uint32_t acpi_id, uin= t32_t pxm) /* Physically added CPUs do not have synchronised TSC. */ if ( boot_cpu_has(X86_FEATURE_TSC_RELIABLE) ) { - static bool once_only; - - if ( !test_and_set_bool(once_only) ) - printk(XENLOG_WARNING - " ** New physical CPU %u may have skewed TSC and hence " - "break assumed cross-CPU TSC coherency.\n" - " ** Consider using boot parameter \"tsc=3Dskewed\" " - "which forces TSC emulation where appropriate.\n", cpu); + printk_once( + XENLOG_WARNING + "New CPU %u may have skewed TSC and break cross-CPU TSC cohere= ncy\n" + "Consider using \"tsc=3Dskewed\" to force emulation where appr= opriate\n", + cpu); cpumask_set_cpu(cpu, &tsc_sync_cpu_mask); } =20 --=20 2.11.0 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel