From nobody Wed May 1 22:49:04 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail(p=none dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1577973474; cv=none; d=zohomail.com; s=zohoarc; b=YUHmU+nb9Kcv1eA9I32Ga7O6Vc17Ec5qX6sIKiONziZeK4Rc9O0iFyhzCo8bHP7AcGXOYyrtAJVLLJM4mQyzWgNlc/aB3QM1cHPayWIoSNq9KltOZYp6OqxsAxo4nhYXwy6uu3NRyfU/vPjdOmIGuqu8iVcPWEe2SXoy10+kdgA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1577973474; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=qRE4CuoSbLrsPLWdaU9W8quEVIlrpRZHmV50kC7fSak=; b=ULOn2Yqa7BEnU7XgZ3r93tgXviJjeJtue9N0DMlBSJoVMDouGFqR/fTXvw+a6TRCRe9wxF9oDNEJHT5F1AAprscA98HOm4aatTYoQ28CoDb9qQLxH65Wr6WBZ5yB1b3kI6+sCCh4pptJ4gcTJcgwt+pHuEgprGarQqdrKwJy4gU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1577973474584106.17054346790235; Thu, 2 Jan 2020 05:57:54 -0800 (PST) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1in0xp-0005yX-VD; Thu, 02 Jan 2020 13:56:37 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1in0xp-0005yS-7T for xen-devel@lists.xenproject.org; Thu, 02 Jan 2020 13:56:37 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id abe6353a-2d67-11ea-a1e1-bc764e2007e4; Thu, 02 Jan 2020 13:56:28 +0000 (UTC) X-Inumbo-ID: abe6353a-2d67-11ea-a1e1-bc764e2007e4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1577973388; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=mn5JFeCRwY/yXWhNq4ML2NQjhiT89SS0XjXdMfrq8KY=; b=fxnQ5OUhcA/7sUyf3dIwcSxfVv+xkREsb8xeTRLf4NmOvcsN7z2RhyYw fpO5G0BRvNq1sEVnkCyZM4Qls97jWGsZiTybJhV9TA3U6yLNUzixNvmzF O+stv4RCSMxLd5NHfHW76GO7mzwBf8ZP36h09E4UuQ3RLKhCBAZgnGNxg M=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=andrew.cooper3@citrix.com; spf=Pass smtp.mailfrom=Andrew.Cooper3@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: None (esa6.hc3370-68.iphmx.com: no sender authenticity information available from domain of andrew.cooper3@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="andrew.cooper3@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa6.hc3370-68.iphmx.com: domain of Andrew.Cooper3@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="Andrew.Cooper3@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa6.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: 6bpga+oEakx+3GR2tybPpc2tICGUGIA1PR3TH2T0YZc5Gh/17pVId6u1buGTeHumux4cbTECBY jqwOvdQ2Hz3vKlB2hWs4A5eyB+aCdXCX9LfJoHn8RGaPpyLeQlCsBzWgUOfB43uZXSOheX5uOl H60cmCs/BOhOyrn+497RpDxSob8hc9uR8OCRsxn4kcXC/jAOkKho6REA1/4LAcog64++JNBbEY xNIHY8IXMhLCs4F8O+Y5EOvYjsTmB3Pa5VqT+o3yvSpbJvmPXsFf+apNVbF5Ed0bzQOBKdED7Z Lk8= X-SBRS: 2.7 X-MesageID: 10804504 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.69,387,1571716800"; d="scan'208";a="10804504" From: Andrew Cooper To: Xen-devel Date: Thu, 2 Jan 2020 13:56:24 +0000 Message-ID: <20200102135624.30787-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Subject: [Xen-devel] [PATCH] xen/efi: Drop infinite loops and use unreachable()/noreturn X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , Andrew Cooper , Jan Beulich , Volodymyr Babchuk , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) No functional change. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich Acked-by: Julien Grall Reviewed-by: Wei Liu --- CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monn=C3=A9 CC: Stefano Stabellini CC: Julien Grall CC: Volodymyr Babchuk --- xen/arch/arm/efi/efi-boot.h | 2 +- xen/arch/x86/efi/efi-boot.h | 2 +- xen/common/efi/boot.c | 1 - 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h index ca655ff003..d7bf934077 100644 --- a/xen/arch/arm/efi/efi-boot.h +++ b/xen/arch/arm/efi/efi-boot.h @@ -367,7 +367,7 @@ static void __init efi_arch_pre_exit_boot(void) { } =20 -static void __init efi_arch_post_exit_boot(void) +static void __init noreturn efi_arch_post_exit_boot(void) { efi_xen_start(fdt, fdt_totalsize(fdt)); } diff --git a/xen/arch/x86/efi/efi-boot.h b/xen/arch/x86/efi/efi-boot.h index 232972eedf..676d616ff8 100644 --- a/xen/arch/x86/efi/efi-boot.h +++ b/xen/arch/x86/efi/efi-boot.h @@ -268,7 +268,7 @@ static void __init noreturn efi_arch_post_exit_boot(voi= d) [stkoff] "i" (STACK_SIZE - sizeof(struct cpu_info)), "D" (&mbi) : "memory" ); - for( ; ; ); /* not reached */ + unreachable(); } =20 static void __init efi_arch_cfg_file_early(EFI_FILE_HANDLE dir_handle, cha= r *section) diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c index 3f1c330afe..1b7dc16056 100644 --- a/xen/common/efi/boot.c +++ b/xen/common/efi/boot.c @@ -1402,7 +1402,6 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *S= ystemTable) efi_exit_boot(ImageHandle, SystemTable); =20 efi_arch_post_exit_boot(); - for( ; ; ); /* not reached */ } =20 #ifndef CONFIG_ARM /* TODO - runtime service support */ --=20 2.11.0 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel