From nobody Sun May 5 10:22:55 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail(p=none dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1577182875; cv=none; d=zohomail.com; s=zohoarc; b=jHB+P5FWGD2zGDPV3/6jgJ+k0ClitgfLhfOSmkT9i9RhymFJ8zp5JdS0Mis93Eb3pZYOo9Z/VT/PsU5DavfmLUC/0qPMyIY3d11Uuaxavr2Ni5Cb0hiPbwmcjLJ3QdXyt9d+KxGn0eyL8yDqsOERcdZeW8Dpel5kFC35Hn/e7ac= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1577182875; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=oes1nEEJzcz+3jQr2nOJDu/PxYKrH/C1i4yzMUTpPZs=; b=Su/5vDDNE/EXHoEFEx/hJgZLSSrVB5uwhKrrUxfN+e+rhWR8mrRtbV+ms0+A3ouNnY7INdaY9Z2qysEUeLc5EWu+SIceoxfYEbcYToAVyczsw2ZJbsK8HBzd+SuJ04M8zffZuHnM2rszlCdxDTK0Ss8W7M4q1iwn92JtWh4Txvw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1577182875643736.9790553568016; Tue, 24 Dec 2019 02:21:15 -0800 (PST) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1ijhIw-0000Pd-8U; Tue, 24 Dec 2019 10:20:42 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1ijhIu-0000PW-Oa for xen-devel@lists.xenproject.org; Tue, 24 Dec 2019 10:20:40 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 0879f8f0-2637-11ea-978f-12813bfff9fa; Tue, 24 Dec 2019 10:20:40 +0000 (UTC) X-Inumbo-ID: 0879f8f0-2637-11ea-978f-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1577182840; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=M6mDZWs6g2o48xWGr7PSDpZ8rocmMmhEd3WloyruAFA=; b=PHX5zWtD8lcIs/W4KRQe74H+Ke/eUEs1fD+RW70JQkvbB5XcHP83tWGk h+PyLTuA42/EO/sVUwLQ8YCUaNaRBLPUTondF+GlazXX54kJBwowkU+sB U65qXhJcIAF7LBoftqmJTt3NwDT6kqCbL++uK/oG8K5wNJ/WMioK826Jl Q=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=roger.pau@citrix.com; spf=Pass smtp.mailfrom=roger.pau@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: None (esa3.hc3370-68.iphmx.com: no sender authenticity information available from domain of roger.pau@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa3.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="roger.pau@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa3.hc3370-68.iphmx.com: domain of roger.pau@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa3.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="roger.pau@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa3.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa3.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: G712NR+t5CrKW64zoVSAVwYNl/Qfl3UGLlHA+T8VrPPHAfDb/228m06BQToitB++SByfw+jRD+ URo6mckX4cUazq3/VRf462kOfNoPg25oXU5olEDpCMtmUsm+bexgq548qZSlwRkmhM0TOd60SW v8nGZ8uKRCIJ4RCnUG8HXndEUzip6AarBvaMNUjqfI+AYeE/9unaGTuVk00ZOz+pJOqbUdrf0s b+Q1ZkBgDyh3cAPoM3SZmjcSZ2RNVMymjLu5gou18v3thtTE4G1I6CnNyKIP4R/kRIuVNdgoWE hIo= X-SBRS: 2.7 X-MesageID: 10093177 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.69,351,1571716800"; d="scan'208";a="10093177" From: Roger Pau Monne To: Date: Tue, 24 Dec 2019 11:18:10 +0100 Message-ID: <20191224101810.45915-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 Subject: [Xen-devel] [PATCH] x86/hvm: always expose x2APIC feature in max HVM cpuid policy X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Wei Liu , Jan Beulich , Roger Pau Monne Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) On hardware without x2APIC support Xen emulated local APIC will provide such mode, and hence the feature should be set in the maximum HVM cpuid policy. Not exposing it in the maximum policy results in HVM domains not getting such feature exposed unless it's also supported by the underlying hardware. Signed-off-by: Roger Pau Monn=C3=A9 --- This is a regression, but I'm not able to identify the commit that introduced the bogus behavior. --- xen/arch/x86/cpuid.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/cpuid.c b/xen/arch/x86/cpuid.c index 7055509ed6..b1ed33d524 100644 --- a/xen/arch/x86/cpuid.c +++ b/xen/arch/x86/cpuid.c @@ -396,10 +396,11 @@ static void __init calculate_hvm_max_policy(void) hvm_featureset[i] &=3D hvm_featuremask[i]; =20 /* - * Xen can provide an APIC emulation to HVM guests even if the host's = APIC - * isn't enabled. + * Xen can provide an (x2)APIC emulation to HVM guests even if the hos= t's + * (x2)APIC isn't enabled. */ __set_bit(X86_FEATURE_APIC, hvm_featureset); + __set_bit(X86_FEATURE_X2APIC, hvm_featureset); =20 /* * On AMD, PV guests are entirely unable to use SYSENTER as Xen runs in --=20 2.24.1 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel