From nobody Fri May 3 19:04:25 2024 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1576038466; cv=none; d=zohomail.com; s=zohoarc; b=WFhjfb8dhMq6XDfIrAi7dKcAsXMMt7SOtyTbXLlSdJPzDQsUiA3nhyOAT7tHwW86ZK/dUUJ2Z66fh6QFng0aIkZ3gJBX8moEFjw6qq+uqC34YTBmjMcw+ayrXrAN+xFrTVpTB7GpybJNSTFLklkwjJbK0rsstmBCbH0HjB6Xl6M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1576038466; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=iv2UNwuRnPPnufCTtmj5hNQtYgQK/UIyLOaPruAVCiE=; b=dKZ12Ws2PRltI60lKli0kBfhruN8vle0NRDB1BJiEeLlhFmG5HB7YR2l2DK+2TxwB3skQZZVv1UR+zqEIHikRb+z96uZzUFZETE/CNDrMzfB+7Z0OD9ZWev1CewXG6SMSYXsXabbBQWvwWZbX9TqxXx4TLHyQZSHwVtxAd7fJ+c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1576038466305164.95848751704057; Tue, 10 Dec 2019 20:27:46 -0800 (PST) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1ietaj-0004w5-Ju; Wed, 11 Dec 2019 04:27:13 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1ietai-0004vx-2I for xen-devel@lists.xenproject.org; Wed, 11 Dec 2019 04:27:12 +0000 Received: from mail-pj1-x1044.google.com (unknown [2607:f8b0:4864:20::1044]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 7fe0f902-1bce-11ea-88e7-bc764e2007e4; Wed, 11 Dec 2019 04:27:11 +0000 (UTC) Received: by mail-pj1-x1044.google.com with SMTP id v93so8400821pjb.6 for ; Tue, 10 Dec 2019 20:27:11 -0800 (PST) Received: from localhost.localdomain ([12.176.148.120]) by smtp.gmail.com with ESMTPSA id r62sm692916pfc.89.2019.12.10.20.27.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2019 20:27:09 -0800 (PST) X-Inumbo-ID: 7fe0f902-1bce-11ea-88e7-bc764e2007e4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=s7ypUOuVnqBd5be1hKp8bDLVVBRRPeaRQV9mQbkGU3s=; b=gTENeTiCkWr99yApgh/4VAIyoKDT3J7JznhYgYA4yoRd3lIV7Jm+5BL8ZWoTvA7zRp z9pynE4SbT7H+qeti2O+huH/QLAOHUl79cPlwnOC8jDVV7lx8IoXTxHIGs3rhJvAAMQa Yc6x1Rvg1pAjEwIvVGdP7984KVM3/BVxsgQNuP6LZ7fkAqAkavw1uX8LJtV2j+Zp6Lb5 1awdDwCJI3o1m3td6EweC4s2Bl/AsVBEc+qxdVSUDqSpEWAbA3tf9WnGg8pegcAPS9R4 5PjvVVq/2M5E9jWv0ThPdLHenPImUhlT90qLM1HLA+JaSUhSUgxpC8QDPSSX8C4XEFZT Jocg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=s7ypUOuVnqBd5be1hKp8bDLVVBRRPeaRQV9mQbkGU3s=; b=c/3ZEeDyqXO0ICD1dWe8be7IVNMHDdj7l7qyPnfEeXIWCcMHIqveGbQOOt9syDot1f sLJH/Ne6Shug8w7GOr/tqQhhat2P+2GyYzOpdpxfuqnu+RsEeGSykXI8tTiVFfmqnvfe EezsPopzFIMVNxrLD5rzmDReu5IbwUNBuAO71QotjGtT7cUm2F9n2HC5XDwvjGMKBBVC arziOCV4liAGMPOpClhlQ3waAuXeBDwfYnAOFPNnK0gNR4qaTwllZTEGNJVwqHxWWPmJ MH8Fx+3sNKz0Gk+TliSr1upRF0nhxRWN/e1c61tvC0ETwWiLLsZ0B1mtdasePnqqBp44 RHiQ== X-Gm-Message-State: APjAAAXnrXiQE+JdjSgsKgVu6ivuyWow7sOXnuoidrom54KCUzN3aVoh 4RVQMqR94O8bmOMPE2OJinY= X-Google-Smtp-Source: APXvYqxmdkRJdHXU4kf3uFrsdx5z19XOW4pKdUEplSPaVl+4BRm2wt+R0nQkpS14IKgOpvMW5oYY+g== X-Received: by 2002:a17:90a:1955:: with SMTP id 21mr1200544pjh.105.1576038430640; Tue, 10 Dec 2019 20:27:10 -0800 (PST) From: SeongJae Park X-Google-Original-From: SeongJae Park To: jgross@suse.com, axboe@kernel.dk, konrad.wilk@oracle.com, roger.pau@citrix.com Date: Wed, 11 Dec 2019 04:26:57 +0000 Message-Id: <20191211042657.6037-1-sjpark@amazon.de> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191211042428.5961-1-sjpark@amazon.de> References: <20191211042428.5961-1-sjpark@amazon.de> Subject: [Xen-devel] [PATCH v6 1/3] xenbus/backend: Add memory pressure handler callback X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: sjpark@amazon.com, pdurrant@amazon.com, SeongJae Park , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, xen-devel@lists.xenproject.org MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Granting pages consumes backend system memory. In systems configured with insufficient spare memory for those pages, it can cause a memory pressure situation. However, finding the optimal amount of the spare memory is challenging for large systems having dynamic resource utilization patterns. Also, such a static configuration might lack flexibility. To mitigate such problems, this commit adds a memory reclaim callback to 'xenbus_driver'. If a memory pressure is detected, 'xenbus' requests every backend driver to volunarily release its memory. Note that it would be able to improve the callback facility for more sophisticated handlings of general pressures. For example, it would be possible to monitor the memory consumption of each device and issue the release requests to only devices which causing the pressure. Also, the callback could be extended to handle not only memory, but general resources. Nevertheless, this version of the implementation defers such sophisticated goals as a future work. Reviewed-by: Juergen Gross Signed-off-by: SeongJae Park --- drivers/xen/xenbus/xenbus_probe_backend.c | 32 +++++++++++++++++++++++ include/xen/xenbus.h | 1 + 2 files changed, 33 insertions(+) diff --git a/drivers/xen/xenbus/xenbus_probe_backend.c b/drivers/xen/xenbus= /xenbus_probe_backend.c index b0bed4faf44c..aedbe2198de5 100644 --- a/drivers/xen/xenbus/xenbus_probe_backend.c +++ b/drivers/xen/xenbus/xenbus_probe_backend.c @@ -248,6 +248,35 @@ static int backend_probe_and_watch(struct notifier_blo= ck *notifier, return NOTIFY_DONE; } =20 +static int xenbus_backend_reclaim(struct device *dev, void *data) +{ + struct xenbus_driver *drv; + + if (!dev->driver) + return 0; + drv =3D to_xenbus_driver(dev->driver); + if (drv && drv->reclaim) + drv->reclaim(to_xenbus_device(dev)); + return 0; +} + +/* + * Returns 0 always because we are using shrinker to only detect memory + * pressure. + */ +static unsigned long xenbus_backend_shrink_count(struct shrinker *shrinker, + struct shrink_control *sc) +{ + bus_for_each_dev(&xenbus_backend.bus, NULL, NULL, + xenbus_backend_reclaim); + return 0; +} + +static struct shrinker xenbus_backend_shrinker =3D { + .count_objects =3D xenbus_backend_shrink_count, + .seeks =3D DEFAULT_SEEKS, +}; + static int __init xenbus_probe_backend_init(void) { static struct notifier_block xenstore_notifier =3D { @@ -264,6 +293,9 @@ static int __init xenbus_probe_backend_init(void) =20 register_xenstore_notifier(&xenstore_notifier); =20 + if (register_shrinker(&xenbus_backend_shrinker)) + pr_warn("shrinker registration failed\n"); + return 0; } subsys_initcall(xenbus_probe_backend_init); diff --git a/include/xen/xenbus.h b/include/xen/xenbus.h index 869c816d5f8c..196260017666 100644 --- a/include/xen/xenbus.h +++ b/include/xen/xenbus.h @@ -104,6 +104,7 @@ struct xenbus_driver { struct device_driver driver; int (*read_otherend_details)(struct xenbus_device *dev); int (*is_ready)(struct xenbus_device *dev); + void (*reclaim)(struct xenbus_device *dev); }; =20 static inline struct xenbus_driver *to_xenbus_driver(struct device_driver = *drv) --=20 2.17.1 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel From nobody Fri May 3 19:04:25 2024 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1576038481; cv=none; d=zohomail.com; s=zohoarc; b=jPD2d/S+G2/9SnPrYpduq3O+Cw1EQNaCKSK4smjcaGDtYYSvESkV8hBWRbaxukeIWZypS7Z7kivZ8+QK8VvP8BrSwKSLio8wRXmdDbFVs0U00O4dv6Oul+xVuYahnxMrCc6kQGEfD9Ks8/Y3m+cM5bkWlu4fHK4mOvqTwGKB0RM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1576038481; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=lkMDLATNwWSXIPO2ftShmZ6+AkMVZHCwtjX83RdHB48=; b=iF5JqtfQ+hpbzs8kems9XjLhO9+aecMWPesxsAgxikqv19ej3lbSAveu+Wpa6tGH2zdQXwwbaeM6gkaRcU9cTjCKaK9+wYh9PlPmsDc31lXxQgeKCiiYf24u9UgL3FcDmlYLxFISxMnMwohI11d1O98WMElUhWBUwCNI6qJsh74= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1576038481778638.2173045022762; Tue, 10 Dec 2019 20:28:01 -0800 (PST) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1ietaz-0004zB-T2; Wed, 11 Dec 2019 04:27:29 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1ietaz-0004z4-C5 for xen-devel@lists.xenproject.org; Wed, 11 Dec 2019 04:27:29 +0000 Received: from mail-pj1-x1044.google.com (unknown [2607:f8b0:4864:20::1044]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 89f58692-1bce-11ea-b6f1-bc764e2007e4; Wed, 11 Dec 2019 04:27:28 +0000 (UTC) Received: by mail-pj1-x1044.google.com with SMTP id ep17so8396285pjb.4 for ; Tue, 10 Dec 2019 20:27:28 -0800 (PST) Received: from localhost.localdomain ([12.176.148.120]) by smtp.gmail.com with ESMTPSA id b16sm675558pfo.64.2019.12.10.20.27.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2019 20:27:26 -0800 (PST) X-Inumbo-ID: 89f58692-1bce-11ea-b6f1-bc764e2007e4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=gHSB8JjTfrVa+2rnf6DBh2FVjHPHYrux3hW9l4ue23E=; b=LLwWW9+atm4yq8czOoNnegigQXlKjPxM5zcG1K667YPGhnXmyYIY3mDof7HhDeXskK XtJeViRpZfA/hFcqlvWWfSOp73jGUmQ89qvP3PfD73Eb98wvRbr1irnc364RYDC6OK3K ACXHNrFzxP++QOoE+vcZ0i+vHM1zjSY0t1cO6mxiaYdluG2e1uJMAxbnRgB2+lcXPM0X vfl2aciNj10eWqQpn/0g+94hSgeZ1CWh6DhhmEaPEdAb7GjZKMDGNlw7by1sEwD1nDcF JHO7HV+RQnTghtAVRDCdKehaA/eV/upbf4V4QGDKmuEMaQ6AKXO7LVD3Vgo1Nh0yNiNg LqDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=gHSB8JjTfrVa+2rnf6DBh2FVjHPHYrux3hW9l4ue23E=; b=R5/hAeoy4fkR5KFoIf9ZjpmLiIyUGMHDsDDm/SLl9sQ1eTuANQciF6TDc8DpipTD9i Ytiwz447aHqoajgzO1CVvfzFMmJtbsv1vAVZFg8jKiyMyfyInUgO9XzjFlmAGUSkZFCy zNwuy3VcPZXb+8O115AY0XQ0raqUKgepUUB3xEOIDeQPeKqCZlVJ4mAKr6e9oDcXvVlL BIICdsWFgNNqVz54hv64lAhYsFQO8MtDsb70bYizAa9h9Hu55mduaQZekmwiDq3b66cb B0kLNBaGxKxCuDZs+e8ctQ5al6V9kyKxLHZ/jUIbM3EryTSJHVf0JKXXEtwZXIU/EmgA j18g== X-Gm-Message-State: APjAAAW2PgAXKbSNKUpwPhtyeI0lCsgYEvFP4mrZK2ZZ0Aia8KBqsEBw 1fa8u//WUIaMXNscAKzvON4= X-Google-Smtp-Source: APXvYqz78yFKteR4nCz5+N9t6t8Ay+iS2x0/OVGDpwF3Lf3uinkm8v3lH7hD4cBH/h0h8wj9awnvlA== X-Received: by 2002:a17:902:43:: with SMTP id 61mr1169630pla.88.1576038447420; Tue, 10 Dec 2019 20:27:27 -0800 (PST) From: SeongJae Park X-Google-Original-From: SeongJae Park To: jgross@suse.com, axboe@kernel.dk, konrad.wilk@oracle.com, roger.pau@citrix.com Date: Wed, 11 Dec 2019 04:27:17 +0000 Message-Id: <20191211042717.6090-1-sjpark@amazon.de> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191211042428.5961-1-sjpark@amazon.de> References: <20191211042428.5961-1-sjpark@amazon.de> Subject: [Xen-devel] [PATCH v6 2/3] xen/blkback: Squeeze page pools if a memory pressure is detected X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: sjpark@amazon.com, pdurrant@amazon.com, SeongJae Park , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, xen-devel@lists.xenproject.org MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Each `blkif` has a free pages pool for the grant mapping. The size of the pool starts from zero and be increased on demand while processing the I/O requests. If current I/O requests handling is finished or 100 milliseconds has passed since last I/O requests handling, it checks and shrinks the pool to not exceed the size limit, `max_buffer_pages`. Therefore, if a system (maybe mistakenly) allows `blkfront` running guests to attach a large number of devices, the guests could cause a memory pressure in the `blkback` running guest by attaching a large number of block devices and inducing I/O. System administrators can avoid such problematic situations by limiting the maximum number of devices that can be attached, but finding the optimal limit is not so easy. Improper set of the limit can results in the memory pressure or a resource underutilization. This commit avoids such problematic situations by squeezing the pools (returns every free page in the pool to the system) for a while (users can set this duration via a module parameter) if a memory pressure is detected. Discussions =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D The `blkback`'s original shrinking mechanism returns only pages in the pool, which are not currently be used by `blkback`, to the system. In other words, the pages that are not mapped with granted pages. Because this commit is changing only the shrink limit but still uses the same freeing mechanism it does not touch pages which are currently mapping grants. Once a memory pressure is detected, this commit keeps the squeezing limit for a user-specified time duration. The duration should be neither too long nor too short. If it is too long, the squeezing incurring overhead can reduce the I/O performance. If it is too short, `blkback` will not free enough pages to reduce the memory pressure. This commit sets the value as `10 milliseconds` by default because it is a short time in terms of I/O while it is a long time in terms of memory operations. Also, as the original shrinking mechanism works for at least every 100 milliseconds, this could be a somewhat reasonable choice. I also tested other durations (refer to the below section for more details) and confirmed that 10 milliseconds is the one that works best with the test. That said, the proper duration depends on actual configurations and workloads. That's why this commit allows users to set the duration as a module parameter. Memory Pressure Test =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D To show how this commit fixes the memory pressure situation well, I configured a test environment on a xen-running virtualization system. On the `blkfront` running guest instances, I attach a large number of network-backed volume devices and induce I/O to those. Meanwhile, I measure the number of pages that swapped in (pswpin) and out (pswpout) on the `blkback` running guest. The test ran twice, once for the `blkback` before this commit and once for that after this commit. As shown below, this commit has dramatically reduced the memory pressure: pswpin pswpout before 76,672 185,799 after 212 3,325 Optimal Aggressive Shrinking Duration Reviewed-by: Juergen Gross ------------------------------------- To find a best squeezing duration, I repeated the test with three different durations (1ms, 10ms, and 100ms). The results are as below: duration pswpin pswpout 1 852 6,424 10 212 3,325 100 203 3,340 As expected, the memory pressure has decreased as the duration is increased, but the reduction stopped from the `10ms`. Based on this results, I chose the default duration as 10ms. Performance Overhead Test =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D This commit could incur I/O performance degradation under severe memory pressure because the squeezing will require more page allocations per I/O. To show the overhead, I artificially made a worst-case squeezing situation and measured the I/O performance of a `blkfront` running guest. For the artificial squeezing, I set the `blkback.max_buffer_pages` using the `/sys/module/xen_blkback/parameters/max_buffer_pages` file. We set the value to `1024` and `0`. The `1024` is the default value. Setting the value as `0` is same to a situation doing the squeezing always (worst-case). For the I/O performance measurement, I use a simple `dd` command. Default Performance ------------------- [dom0]# echo 1024 > /sys/module/xen_blkback/parameters/max_buffer_pages [instance]$ for i in {1..5}; do dd if=3D/dev/zero of=3Dfile \ bs=3D4k count=3D$((256*512)); sync; = done 131072+0 records in 131072+0 records out 536870912 bytes (537 MB) copied, 11.7257 s, 45.8 MB/s 131072+0 records in 131072+0 records out 536870912 bytes (537 MB) copied, 13.8827 s, 38.7 MB/s 131072+0 records in 131072+0 records out 536870912 bytes (537 MB) copied, 13.8781 s, 38.7 MB/s 131072+0 records in 131072+0 records out 536870912 bytes (537 MB) copied, 13.8737 s, 38.7 MB/s 131072+0 records in 131072+0 records out 536870912 bytes (537 MB) copied, 13.8702 s, 38.7 MB/s Worst-case Performance ---------------------- [dom0]# echo 0 > /sys/module/xen_blkback/parameters/max_buffer_pages [instance]$ for i in {1..5}; do dd if=3D/dev/zero of=3Dfile \ bs=3D4k count=3D$((256*512)); sync; = done 131072+0 records in 131072+0 records out 536870912 bytes (537 MB) copied, 11.7257 s, 45.8 MB/s 131072+0 records in 131072+0 records out 536870912 bytes (537 MB) copied, 13.878 s, 38.7 MB/s 131072+0 records in 131072+0 records out 536870912 bytes (537 MB) copied, 13.8746 s, 38.7 MB/s 131072+0 records in 131072+0 records out 536870912 bytes (537 MB) copied, 13.8786 s, 38.7 MB/s 131072+0 records in 131072+0 records out 536870912 bytes (537 MB) copied, 13.8749 s, 38.7 MB/s In short, even worst case squeezing makes no visible performance degradation on this test machine. I think this is due to the slow speed of the I/O devices I used. In other words, the additional page allocation overhead is hidden under the much slower I/O latency. Nevertheless, pleaset note that this is just a very simple and minimal test using a slow block device. On systems using fast block devices such as ramdisks or NVMe SSDs, the results could be very different. If you are in such cases, you should control the squeezing duration via the module parameter. Reviewed-by: Juergen Gross Signed-off-by: SeongJae Park --- drivers/block/xen-blkback/blkback.c | 22 ++++++++++++++++++++-- drivers/block/xen-blkback/common.h | 1 + drivers/block/xen-blkback/xenbus.c | 3 ++- 3 files changed, 23 insertions(+), 3 deletions(-) diff --git a/drivers/block/xen-blkback/blkback.c b/drivers/block/xen-blkbac= k/blkback.c index fd1e19f1a49f..b493c306e84f 100644 --- a/drivers/block/xen-blkback/blkback.c +++ b/drivers/block/xen-blkback/blkback.c @@ -142,6 +142,21 @@ static inline bool persistent_gnt_timeout(struct persi= stent_gnt *persistent_gnt) HZ * xen_blkif_pgrant_timeout); } =20 +/* Once a memory pressure is detected, squeeze free page pools for a while= . */ +static unsigned int buffer_squeeze_duration_ms =3D 10; +module_param_named(buffer_squeeze_duration_ms, + buffer_squeeze_duration_ms, int, 0644); +MODULE_PARM_DESC(buffer_squeeze_duration_ms, +"Duration in ms to squeeze pages buffer when a memory pressure is detected= "); + +static unsigned long buffer_squeeze_end; + +void xen_blkbk_reclaim(struct xenbus_device *dev) +{ + buffer_squeeze_end =3D jiffies + + msecs_to_jiffies(buffer_squeeze_duration_ms); +} + static inline int get_free_page(struct xen_blkif_ring *ring, struct page *= *page) { unsigned long flags; @@ -656,8 +671,11 @@ int xen_blkif_schedule(void *arg) ring->next_lru =3D jiffies + msecs_to_jiffies(LRU_INTERVAL); } =20 - /* Shrink if we have more than xen_blkif_max_buffer_pages */ - shrink_free_pagepool(ring, xen_blkif_max_buffer_pages); + /* Shrink the free pages pool if it is too large. */ + if (time_before(jiffies, buffer_squeeze_end)) + shrink_free_pagepool(ring, 0); + else + shrink_free_pagepool(ring, xen_blkif_max_buffer_pages); =20 if (log_stats && time_after(jiffies, ring->st_print)) print_stats(ring); diff --git a/drivers/block/xen-blkback/common.h b/drivers/block/xen-blkback= /common.h index 1d3002d773f7..8a3195d2dca7 100644 --- a/drivers/block/xen-blkback/common.h +++ b/drivers/block/xen-blkback/common.h @@ -383,6 +383,7 @@ irqreturn_t xen_blkif_be_int(int irq, void *dev_id); int xen_blkif_schedule(void *arg); int xen_blkif_purge_persistent(void *arg); void xen_blkbk_free_caches(struct xen_blkif_ring *ring); +void xen_blkbk_reclaim(struct xenbus_device *dev); =20 int xen_blkbk_flush_diskcache(struct xenbus_transaction xbt, struct backend_info *be, int state); diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback= /xenbus.c index b90dbcd99c03..b596c6e8b006 100644 --- a/drivers/block/xen-blkback/xenbus.c +++ b/drivers/block/xen-blkback/xenbus.c @@ -1115,7 +1115,8 @@ static struct xenbus_driver xen_blkbk_driver =3D { .ids =3D xen_blkbk_ids, .probe =3D xen_blkbk_probe, .remove =3D xen_blkbk_remove, - .otherend_changed =3D frontend_changed + .otherend_changed =3D frontend_changed, + .reclaim =3D xen_blkbk_reclaim, }; =20 int xen_blkif_xenbus_init(void) --=20 2.17.1 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel From nobody Fri May 3 19:04:25 2024 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1576038492; cv=none; d=zohomail.com; s=zohoarc; b=C7FQ7vykAQLaP520rbK+kpgPob8kRJFye9UuZXrL74DpG3/rSzhYS6H++rCpfn7GPmv69PLuLmHGOsBp934vbXKG/+CHDuzHxf0kkiAOfrfzivLFjmqvvXaCnY0d/fkJcM3+rDBzRBqYIRjYzRvGOmwm2B038fnBGgoHZMeMiyA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1576038492; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ZoDwjDLlYsoWDiFoKDCfclqGnj8l4TKS62eC2dANilk=; b=PU7Rp+xe+unvA5yra9x/8fkUdga2IrVpfn8CRo8z9n7vk30h9Y5VFnzJsXXxmtP5gwQtvngqGdEuXD1sFIz8/KGcJoOBqqi9MhfXuoSoltqNqiG1U39waRHHII91srjmL481BPhlJ/ALByIeCfZwM6veafnIR+8wR9FHbkg6kbY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1576038492887654.8524210518846; Tue, 10 Dec 2019 20:28:12 -0800 (PST) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1ietbD-00052g-AG; Wed, 11 Dec 2019 04:27:43 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1ietbC-00052P-E4 for xen-devel@lists.xenproject.org; Wed, 11 Dec 2019 04:27:42 +0000 Received: from mail-pf1-x444.google.com (unknown [2607:f8b0:4864:20::444]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 91eee1a4-1bce-11ea-a1e1-bc764e2007e4; Wed, 11 Dec 2019 04:27:41 +0000 (UTC) Received: by mail-pf1-x444.google.com with SMTP id p14so1123639pfn.4 for ; Tue, 10 Dec 2019 20:27:41 -0800 (PST) Received: from localhost.localdomain ([12.176.148.120]) by smtp.gmail.com with ESMTPSA id m12sm591259pgr.87.2019.12.10.20.27.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2019 20:27:40 -0800 (PST) X-Inumbo-ID: 91eee1a4-1bce-11ea-a1e1-bc764e2007e4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=rEcgwnaRhxf5O9dD75Zxn4HOLh2R66s7XyntOC74d9E=; b=Lofcsni9piHB5mGQqPP+2S3S9s2EWFhep17RT10aY33Ak4WVy8+GtR5AqC/lyTbgrr Gg/7AF1H3tw7Ve+kMhOLmpbKBhsALPRZb3g8pXcEmQqBhuJ1TdI359kUsfjWqHhPuF9a c6YUIfaBtfXhrVNjJljAadm+61nNiWTUpAc8EiURHCKSBZUqniMDjhKcXY1RsM8zqQF7 0+Nbn1ryRgDh6di/c5AcWUXRcFRtaiYCz2hmEmFPNPYADcLKg2SsK9lzyB9qTXjUe591 vOtDOH2suB8pnV0xgEsaHX1zr6nzndzvfkECb7EbFXB1tS7YazCJzuSOKlfTRMoSx08m HPBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=rEcgwnaRhxf5O9dD75Zxn4HOLh2R66s7XyntOC74d9E=; b=nQ6cs57Nbbr8rEfYEuQLhfgGjjz50Tz8eBOOzs2j22P4SrOu8SPzsz7wqXMJmvC8HI yH3r3co1MCbaJAgcD15yUuXhvcZiJGVnbaUEz7w6gHDy4i5BCPa6zZUkCHi2fGN3+6oO 38j698+V7eZ/g+fpsYRq5eCgka94f+FJ48XQkA4FwICr96W/bmTf7ktFlrJnS5SF1tG1 +esGVJSfgJaG27f34jofscuFlZ9MYKP2iy0HLAYkK8QFLzhSjBgg2Mr7yVJcRN5laI4A e8dYZK4BJSpOy5sGt6cqKUvOHLRgYn5VT3emnoZFgGbnQSzQRhHrAdW9UoZ1YFHUK+YE bkqA== X-Gm-Message-State: APjAAAWYItrRyiMV+Zyk4QNFxNC7COBxngTLhY0zCMzNr+vI+p6WXov9 5KNn+lLtZS1gDTko/FxijcU= X-Google-Smtp-Source: APXvYqy24bhJZxnJNM/F0i7fclLKt26wgSxp0KGAPJ6m6mq/sBjQJXDJ7S1yh/UQDwwQYt2vwWmJFQ== X-Received: by 2002:a63:5818:: with SMTP id m24mr1905056pgb.358.1576038460800; Tue, 10 Dec 2019 20:27:40 -0800 (PST) From: SeongJae Park X-Google-Original-From: SeongJae Park To: jgross@suse.com, axboe@kernel.dk, konrad.wilk@oracle.com, roger.pau@citrix.com Date: Wed, 11 Dec 2019 04:27:33 +0000 Message-Id: <20191211042733.6143-1-sjpark@amazon.de> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191211042428.5961-1-sjpark@amazon.de> References: <20191211042428.5961-1-sjpark@amazon.de> Subject: [Xen-devel] [PATCH v6 3/3] xen/blkback: Remove unnecessary static variable name prefixes X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: sjpark@amazon.com, pdurrant@amazon.com, SeongJae Park , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, xen-devel@lists.xenproject.org MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) A few of static variables in blkback have 'xen_blkif_' prefix, though it is unnecessary for static variables. This commit removes such prefixes. Signed-off-by: SeongJae Park Reviewed-by: Roger Pau Monn=C3=A9 --- drivers/block/xen-blkback/blkback.c | 37 +++++++++++++---------------- 1 file changed, 17 insertions(+), 20 deletions(-) diff --git a/drivers/block/xen-blkback/blkback.c b/drivers/block/xen-blkbac= k/blkback.c index b493c306e84f..f690373669b8 100644 --- a/drivers/block/xen-blkback/blkback.c +++ b/drivers/block/xen-blkback/blkback.c @@ -62,8 +62,8 @@ * IO workloads. */ =20 -static int xen_blkif_max_buffer_pages =3D 1024; -module_param_named(max_buffer_pages, xen_blkif_max_buffer_pages, int, 0644= ); +static int max_buffer_pages =3D 1024; +module_param_named(max_buffer_pages, max_buffer_pages, int, 0644); MODULE_PARM_DESC(max_buffer_pages, "Maximum number of free pages to keep in each block backend buffer"); =20 @@ -78,8 +78,8 @@ MODULE_PARM_DESC(max_buffer_pages, * algorithm. */ =20 -static int xen_blkif_max_pgrants =3D 1056; -module_param_named(max_persistent_grants, xen_blkif_max_pgrants, int, 0644= ); +static int max_pgrants =3D 1056; +module_param_named(max_persistent_grants, max_pgrants, int, 0644); MODULE_PARM_DESC(max_persistent_grants, "Maximum number of grants to map persistently"); =20 @@ -88,8 +88,8 @@ MODULE_PARM_DESC(max_persistent_grants, * use. The time is in seconds, 0 means indefinitely long. */ =20 -static unsigned int xen_blkif_pgrant_timeout =3D 60; -module_param_named(persistent_grant_unused_seconds, xen_blkif_pgrant_timeo= ut, +static unsigned int pgrant_timeout =3D 60; +module_param_named(persistent_grant_unused_seconds, pgrant_timeout, uint, 0644); MODULE_PARM_DESC(persistent_grant_unused_seconds, "Time in seconds an unused persistent grant is allowed to " @@ -137,9 +137,8 @@ module_param(log_stats, int, 0644); =20 static inline bool persistent_gnt_timeout(struct persistent_gnt *persisten= t_gnt) { - return xen_blkif_pgrant_timeout && - (jiffies - persistent_gnt->last_used >=3D - HZ * xen_blkif_pgrant_timeout); + return pgrant_timeout && (jiffies - persistent_gnt->last_used >=3D + HZ * pgrant_timeout); } =20 /* Once a memory pressure is detected, squeeze free page pools for a while= . */ @@ -249,7 +248,7 @@ static int add_persistent_gnt(struct xen_blkif_ring *ri= ng, struct persistent_gnt *this; struct xen_blkif *blkif =3D ring->blkif; =20 - if (ring->persistent_gnt_c >=3D xen_blkif_max_pgrants) { + if (ring->persistent_gnt_c >=3D max_pgrants) { if (!blkif->vbd.overflow_max_grants) blkif->vbd.overflow_max_grants =3D 1; return -EBUSY; @@ -412,14 +411,13 @@ static void purge_persistent_gnt(struct xen_blkif_rin= g *ring) goto out; } =20 - if (ring->persistent_gnt_c < xen_blkif_max_pgrants || - (ring->persistent_gnt_c =3D=3D xen_blkif_max_pgrants && + if (ring->persistent_gnt_c < max_pgrants || + (ring->persistent_gnt_c =3D=3D max_pgrants && !ring->blkif->vbd.overflow_max_grants)) { num_clean =3D 0; } else { - num_clean =3D (xen_blkif_max_pgrants / 100) * LRU_PERCENT_CLEAN; - num_clean =3D ring->persistent_gnt_c - xen_blkif_max_pgrants + - num_clean; + num_clean =3D (max_pgrants / 100) * LRU_PERCENT_CLEAN; + num_clean =3D ring->persistent_gnt_c - max_pgrants + num_clean; num_clean =3D min(ring->persistent_gnt_c, num_clean); pr_debug("Going to purge at least %u persistent grants\n", num_clean); @@ -614,8 +612,7 @@ static void print_stats(struct xen_blkif_ring *ring) current->comm, ring->st_oo_req, ring->st_rd_req, ring->st_wr_req, ring->st_f_req, ring->st_ds_req, - ring->persistent_gnt_c, - xen_blkif_max_pgrants); + ring->persistent_gnt_c, max_pgrants); ring->st_print =3D jiffies + msecs_to_jiffies(10 * 1000); ring->st_rd_req =3D 0; ring->st_wr_req =3D 0; @@ -675,7 +672,7 @@ int xen_blkif_schedule(void *arg) if (time_before(jiffies, buffer_squeeze_end)) shrink_free_pagepool(ring, 0); else - shrink_free_pagepool(ring, xen_blkif_max_buffer_pages); + shrink_free_pagepool(ring, max_buffer_pages); =20 if (log_stats && time_after(jiffies, ring->st_print)) print_stats(ring); @@ -902,7 +899,7 @@ static int xen_blkbk_map(struct xen_blkif_ring *ring, continue; } if (use_persistent_gnts && - ring->persistent_gnt_c < xen_blkif_max_pgrants) { + ring->persistent_gnt_c < max_pgrants) { /* * We are using persistent grants, the grant is * not mapped but we might have room for it. @@ -929,7 +926,7 @@ static int xen_blkbk_map(struct xen_blkif_ring *ring, pages[seg_idx]->persistent_gnt =3D persistent_gnt; pr_debug("grant %u added to the tree of persistent grants, using %u/%u\= n", persistent_gnt->gnt, ring->persistent_gnt_c, - xen_blkif_max_pgrants); + max_pgrants); goto next; } if (use_persistent_gnts && !blkif->vbd.overflow_max_grants) { --=20 2.17.1 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel