From nobody Mon Feb 9 19:52:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail(p=none dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1575476490; cv=none; d=zohomail.com; s=zohoarc; b=fEZw8Amwa2LrUp5+1bkExD1WW4CwkA93vM1swtv7BkzRra2ffSMr+to/9ETVX1T72J8WlkPtjsDl9glOrhY4tA87jOtGxo2RqKvGui0CWLMSVUtXZ5ce3FrPlY9UaUIUiy5iKzWVlEeA46ZmZ0bT+VI1poJDXKILovXPejQubL4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1575476490; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=dB/3Y9bIH1a14vLoEF0LLZxhxNrVzaJ1z3xxO50ziT4=; b=GVIdlsxA/44b98RF2p8GCHS7EEiSdQk+IJvibIyEIiCDr1hkw50uyuEXN5MKBbK3NCu7J+VEEOtlOKTF4/loN9z0NDKOq1fPunJKySbSLr+buqQCXaPpr9nlIdnrL3Ah1Pc9Rssk9oUUdV0S4eHCfkv7amulwFOs0U+rZApH1C0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 157547649007886.36166917875425; Wed, 4 Dec 2019 08:21:30 -0800 (PST) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1icXOW-0006sV-IT; Wed, 04 Dec 2019 16:20:52 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1icXOV-0006s1-4u for xen-devel@lists.xenproject.org; Wed, 04 Dec 2019 16:20:51 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 08ef6ff3-16b2-11ea-8206-12813bfff9fa; Wed, 04 Dec 2019 16:20:50 +0000 (UTC) X-Inumbo-ID: 08ef6ff3-16b2-11ea-8206-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1575476451; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=80NBp/22T/CAr+4PPAbMOKrqqzLlXhTyFbDherA9Olo=; b=PQGZsW9bXnhdsa/DeprYU7x7pcqbUKQ2HJs9xtmPyeqTFe7mkNKxrBO0 phxrEUCDGTBHh6QfCbEBoqQQydnrHl70ujqlP6v1S8gKe4thRsqai5t6d a1vxsqIh2ocfMWksip3VchSKa/DfD7BCxsNONkGurU7v6hHgaj6hKbl9d 8=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=roger.pau@citrix.com; spf=Pass smtp.mailfrom=roger.pau@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of roger.pau@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="roger.pau@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa2.hc3370-68.iphmx.com: domain of roger.pau@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="roger.pau@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: SY9ZnMe4o8+zOGEwLQAliZ60XRsR9Gb/WXmtgdJNxGcHwFeuBOoohiCHDKx/PUOLK1yjNtjzB/ 2fUj1hHmyTNTcXDm8eoHqHYsN/hT6DAPFPN0w1xLz7qQfwXD6TgzcXXqEgV8xHhk0qifXyvFJ2 HlIIQcigKfTJUAIAAqJJE4lxZ561VHOAOW1cULB1x4iKZ3AynO0lAMTkFsiZIh92//IRdoksuZ AwlVAQgAMbW0lnuu3CvEUv+9wkRIG3XcKYi73wOCvJDBKfalx/vyDPSvTRcGKmt3v44hU+CZHX 5yU= X-SBRS: 2.7 X-MesageID: 9200817 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.69,277,1571716800"; d="scan'208";a="9200817" From: Roger Pau Monne To: Date: Wed, 4 Dec 2019 17:20:24 +0100 Message-ID: <20191204162025.37510-4-roger.pau@citrix.com> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191204162025.37510-1-roger.pau@citrix.com> References: <20191204162025.37510-1-roger.pau@citrix.com> MIME-Version: 1.0 Subject: [Xen-devel] [PATCH v3 3/4] x86/smp: check APIC ID on AP bringup X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Wei Liu , Jan Beulich , Roger Pau Monne Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Check that the processor to be woken up APIC ID is addressable in the current APIC mode. Note that in practice systems with APIC IDs > 255 should already have x2APIC enabled by the firmware, and hence this is mostly a safety belt. Signed-off-by: Roger Pau Monn=C3=A9 Reviewed-by: Jan Beulich --- Changes since v2: - Reword error message. --- xen/arch/x86/smpboot.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/xen/arch/x86/smpboot.c b/xen/arch/x86/smpboot.c index fa691b6ba0..8cbb7173a4 100644 --- a/xen/arch/x86/smpboot.c +++ b/xen/arch/x86/smpboot.c @@ -1317,6 +1317,13 @@ int __cpu_up(unsigned int cpu) if ( (apicid =3D x86_cpu_to_apicid[cpu]) =3D=3D BAD_APICID ) return -ENODEV; =20 + if ( (!x2apic_enabled || !iommu_intremap) && (apicid >> 8) ) + { + printk("Unsupported: APIC ID %#x in xAPIC mode w/o interrupt remap= ping", + apicid); + return -EINVAL; + } + if ( (ret =3D do_boot_cpu(apicid, cpu)) !=3D 0 ) return ret; =20 --=20 2.24.0 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel