From nobody Fri Apr 26 14:53:08 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail(p=none dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1575027033; cv=none; d=zohomail.com; s=zohoarc; b=nVOnRH+ZpTTgvsT4zAp3WN4dNI2MLmDo8FgA8mqPUajVe1oDgCfTF3NWfhmAzG6wqMKibo3y6Y5/K1ETGr8THONqpKLMeJfKvrEcC0iK6YisTHSLjj1juNRxDRSpuDjXTbcEOt4Vb86bNzsqsykwrLQqOXS/5qU1Kk52d2rT5rw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1575027033; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=NfXhqzIjp6h/2u1qlJ3Yy29xYteG2Yf/NydemfMV7vM=; b=Ae8M+MPLLCO2aQFlcLv3tPHGyUcDb7D/k74f4owKTo5kMA/atXFaiBb2F8Wixc3Ux5D1HIzmyMBmP8H03kqh49r2+hkvHrh3O/bzbyWOjPp1OqubGts4EeiAYlkcpfrYEOdKT3ozbc39UNlf0X80/wTvRaFdj8kRps+QQSNPoTs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1575027032979496.0725892302262; Fri, 29 Nov 2019 03:30:32 -0800 (PST) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iaeT0-0006qY-6h; Fri, 29 Nov 2019 11:29:42 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iaeSy-0006qT-RP for xen-devel@lists.xenproject.org; Fri, 29 Nov 2019 11:29:40 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 87c2042c-129b-11ea-b155-bc764e2007e4; Fri, 29 Nov 2019 11:29:40 +0000 (UTC) X-Inumbo-ID: 87c2042c-129b-11ea-b155-bc764e2007e4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1575026981; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=M6WVb9qVoCWSq+IksgaLNw4MVZZQraMScTx5Z7NZA6E=; b=WXhEDyoEFzoaKW9wPKo5DbkBw7fPaaYyVwlX38Sc30fKleBSx+S7oR3U NZ2hvZtLmYl+09QOtGh3EFcOewazKilBjcyfG8PRaZlrFgW9rylL6fVNA OHOgROQ8hL1bn/UJcav5SXIewPhzDgK7V96K4besqDNFFMqK80mtQM7el U=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=roger.pau@citrix.com; spf=Pass smtp.mailfrom=roger.pau@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: none (zohomail.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of roger.pau@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="roger.pau@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa2.hc3370-68.iphmx.com: domain of roger.pau@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="roger.pau@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: doxhNnF1hksrFHfv1jmCQBG25XC1DX4KXwADCDy2OtipLAWGnrSfDw4D5ZbSvOFa0fXl8rF+/3 as2+F+NqOxhLxLc6iINiW3LpXeZUI9i0AGW2nzZOTg6oGGXyTJrRd7l/wqdtJN2MKKsoeKUciZ wDJvcHsSIeJzOQh6Dtgr5OMe7XMUGW31e+AUma2BpM1KfvkLwIZowxCM6V2IjwO96k2f2vXym7 /VHGW642PV9RWZ+BD6dY2/Wc4XiG9iQ2T6rjz1M76Wm+uXBwMrR7EKk2ZN/lhRFWkxNPyoGnIe ZMs= X-SBRS: 2.7 X-MesageID: 8987262 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.69,257,1571716800"; d="scan'208";a="8987262" From: Roger Pau Monne To: Date: Fri, 29 Nov 2019 12:28:50 +0100 Message-ID: <20191129112851.19273-4-roger.pau@citrix.com> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191129112851.19273-1-roger.pau@citrix.com> References: <20191129112851.19273-1-roger.pau@citrix.com> MIME-Version: 1.0 Subject: [Xen-devel] [PATCH v2 3/4] x86/smp: check APIC ID on AP bringup X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Wei Liu , Jan Beulich , Roger Pau Monne Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Check that the processor to be woken up APIC ID is addressable in the current APIC mode. Note that in practice systems with APIC IDs > 255 should already have x2APIC enabled by the firmware, and hence this is mostly a safety belt. Signed-off-by: Roger Pau Monn=C3=A9 --- xen/arch/x86/smpboot.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/xen/arch/x86/smpboot.c b/xen/arch/x86/smpboot.c index fa691b6ba0..484d344c44 100644 --- a/xen/arch/x86/smpboot.c +++ b/xen/arch/x86/smpboot.c @@ -1317,6 +1317,13 @@ int __cpu_up(unsigned int cpu) if ( (apicid =3D x86_cpu_to_apicid[cpu]) =3D=3D BAD_APICID ) return -ENODEV; =20 + if ( (!x2apic_enabled || !iommu_intremap) && (apicid >> 8) ) + { + printk("Processor with APIC ID %u cannot be onlined in xAPIC mode " + "or without interrupt remapping\n", apicid); + return -EINVAL; + } + if ( (ret =3D do_boot_cpu(apicid, cpu)) !=3D 0 ) return ret; =20 --=20 2.24.0 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel