From nobody Mon Feb 9 19:06:30 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail(p=none dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1574351692; cv=none; d=zoho.com; s=zohoarc; b=JotP8FEneqjufYG7wDZljdpMK6K9V/8+U6T2m+nSt8Gw+ToUN/ekiTrEN8kwKsB0BpXlBffWa2A3xYaj88EHWdgvsn4Lb5w9gygGbUpbfPOEnqjl7zz2zEgX/UPS9Wu67sFtQPyOHJfuERaeWYydP/2lmvZ0fZIfpHrTZEllw5c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1574351692; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=TaVhv57hqqY/XSK7erPDQOz3d/8FRo8nMXg5yDQBm9Y=; b=ewVr8EgjWqrpvUswYqA1fGseWlKv4qNFVjcgOj8DSY7JUJGCLs43N++mUhxuvEGxWAC6oHci+id5xc4+JjlHPvWG613U5Rr3uGrsBnY2LZfP9Jt2XX3ht5jH19fkqCf6mEybAN1AQG33rB9yx4JuE95Xcm7njQoyZebZfMaWuKk= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1574351692276332.9862572915031; Thu, 21 Nov 2019 07:54:52 -0800 (PST) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iXomn-0007Mq-Lz; Thu, 21 Nov 2019 15:54:25 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iXomm-0007Md-HM for xen-devel@lists.xenproject.org; Thu, 21 Nov 2019 15:54:24 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 2fecc9aa-0c77-11ea-a33c-12813bfff9fa; Thu, 21 Nov 2019 15:54:23 +0000 (UTC) X-Inumbo-ID: 2fecc9aa-0c77-11ea-a33c-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1574351663; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Ni72YK4MQ3tW3zR5VLAk3DqhGd0LLmGdxnb57VoU8vc=; b=hkzZgbdGlz4ihJDLOQ1L5uxu/TElH+5So3rgGxhrDKGT6Md1z1vVNJHT ImNWNtP6R/I6wtRbPVfV2OwMzgB40tLmDYMwOHTEGIIDMDPZFN3cQrADO FxqozeThHN8CMfzd/dGy/m8nQEwaVMuL6odc7cZSBXFF8oRIfFfUcgd9B U=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=roger.pau@citrix.com; spf=Pass smtp.mailfrom=roger.pau@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of roger.pau@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="roger.pau@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa2.hc3370-68.iphmx.com: domain of roger.pau@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="roger.pau@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: 4zu0VCs2s2QXTatdlqnu7bLiRuguGvbbG13Gmc3um6HIFl2QAtukvTYP8RLL9f5XFDzIOK2PqF vdRVC7bR3+IBHaFnZp/sB1tMuKE2/LFdn2bGuA50FjLowRPDmI0AEtrZLDO+RkblNqRlUXuAco 1hBh1BHnx6HHCoibsp/dnB+Q6e+nuASRqFQhwARyHSBoF5fbIFo7w3qzi7UnhBz7BqJDWxj0uh r5mf/88y/Mw6fzkswWXdibL/D4gao+cH94/tpMjt9zTnRtbZe+nJ4HkM0eIjZi5yTJ3PnQtZi/ cXI= X-SBRS: 2.7 X-MesageID: 8668388 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.69,226,1571716800"; d="scan'208";a="8668388" From: Roger Pau Monne To: Date: Thu, 21 Nov 2019 16:54:10 +0100 Message-ID: <20191121155411.13250-3-roger.pau@citrix.com> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191121155411.13250-1-roger.pau@citrix.com> References: <20191121155411.13250-1-roger.pau@citrix.com> MIME-Version: 1.0 Subject: [Xen-devel] [PATCH 2/3] x86/smp: check APIC ID on AP bringup X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Wei Liu , Jan Beulich , Roger Pau Monne Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Check that the processor to be woken up APIC ID is addressable in the current APIC mode. Note that in practice systems with APIC IDs > 255 should already have x2APIC enabled by the firmware, and hence this is mostly a safety belt. Signed-off-by: Roger Pau Monn=C3=A9 --- xen/arch/x86/smpboot.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/xen/arch/x86/smpboot.c b/xen/arch/x86/smpboot.c index f86c15bde3..4e9fe7e03e 100644 --- a/xen/arch/x86/smpboot.c +++ b/xen/arch/x86/smpboot.c @@ -1315,6 +1315,13 @@ int __cpu_up(unsigned int cpu) if ( (apicid =3D x86_cpu_to_apicid[cpu]) =3D=3D BAD_APICID ) return -ENODEV; =20 + if ( (!x2apic_enabled || !iommu_intremap) && (apicid >> 8) ) + { + printk("Processor with APIC ID %u cannot be onlined in xAPIC mode " + "or without interrupt remapping\n", apicid); + return -EINVAL; + } + if ( (ret =3D do_boot_cpu(apicid, cpu)) !=3D 0 ) return ret; =20 --=20 2.24.0 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel