From nobody Mon May 6 22:07:52 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail(p=none dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1573670283; cv=none; d=zoho.com; s=zohoarc; b=Y56eGJ9jcd0PTl4OfWqnEomqN4vhhmGyHoU93oAba0KfJLOe9HSCPsyRnYODUH0OgMH8GL9sH4AoG6hL7wZIm8YSvKoMIvw8jrgc27kJHoatbGdxuSHBk1QMaxfWQnwCmess0cgUzPN1Vpso+QJ1v2Swg/BYnUrVC9Yzn7z0GcU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1573670283; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=96ihXei8LkO49xtmpFlYCzsmukHfh8sq+wjU8IaNEpU=; b=SzK3bwd2I+x8FCR87O9CxAhgFNkWABkzf/C+zQLIIYywvsvAgeM33bcpRta0/JSpCd+dEIC+2m6/R7o1Aj2HUpfth5H1RYizPaNf33eC/hOli5yzAbf+C6b+53oNjoXjQuL64fT5CKppeNejradufoPgCgUkYUKXhAfOagUqHDA= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1573670283096444.1216906110009; Wed, 13 Nov 2019 10:38:03 -0800 (PST) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iUxVa-00085T-Mx; Wed, 13 Nov 2019 18:36:50 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iUxVZ-00085O-4w for xen-devel@lists.xenproject.org; Wed, 13 Nov 2019 18:36:49 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 8c6dc686-0644-11ea-a23d-12813bfff9fa; Wed, 13 Nov 2019 18:36:47 +0000 (UTC) X-Inumbo-ID: 8c6dc686-0644-11ea-a23d-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1573670208; h=from:to:cc:subject:date:message-id:mime-version; bh=s2umt9L7hxLKlNnW2M4n3MFgoalGuAuLHbS71nqQTDU=; b=BJP4JhZ/+lJ45h+W0s99UgQKcE1flOLjS6A4hlhqYE3C+VVgYC8Zvg8H /AmsM3anOgWYhCTIsMiGZftGQUTfGnTtNUfDdeLrbCV3uJ6oeS+SNw7AC J+d3cB8oH3BzfITJb7BjAHVf68yktyHVnP/7Fkncxn8rnNycCuaKNpxVA A=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=andrew.cooper3@citrix.com; spf=Pass smtp.mailfrom=Andrew.Cooper3@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of andrew.cooper3@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="andrew.cooper3@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa2.hc3370-68.iphmx.com: domain of Andrew.Cooper3@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="Andrew.Cooper3@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: oMHILbXf2xgHDjiVc5DWeG1e7mvFAM9eBxiNF0fqlIKQG9YYZgbEeOJU0PMY0wPhVN7wMe+9Sw NljzE8EDt/P85g0pkabMmR63N0y38RZLF5ooRsFIVWoAwW8krElBRPZ4m1gd9DEj+wohKSKzg0 X5oxPxp163vHJULklDERRRr8Sorydpcwjbzj/LtIhc4/NVrov29SOIwBKgm8mu5jBRMvOCVlog lQg4jqN+3l6wxz1+AmzlHs0sNbg18+OFmgyuTeu8kAFZL8Ta1CfaZGIryQdpHGsVgs75cC0bjy RhA= X-SBRS: 2.7 X-MesageID: 8285313 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.68,301,1569297600"; d="scan'208";a="8285313" From: Andrew Cooper To: Xen-devel Date: Wed, 13 Nov 2019 18:36:41 +0000 Message-ID: <20191113183641.2871-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Subject: [Xen-devel] [PATCH for-4.13] xen/sched: Render sibling/core masks with %pbl to improve 'r' debugkey X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , Andrew Cooper , George Dunlap , Dario Faggioli Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) For system with large numbers of CPUs, the 'r' debugkey is unwieldy. Sibli= ng and core masks are a single block of adjacent bits, so are vastly shorter to render with %pbl. Before: (XEN) CPU[00] nr_run=3D0, sort=3D157, sibling=3D00000000,00000000,0000000= 0,00000000,00000000,00000000,00000000,00000003, core=3D00000000,00000000,00= 000000,00000000,ffffffff,ffffffff,ffffffff,ffffffff (XEN) CPU[01] nr_run=3D0, sort=3D13750, sibling=3D00000000,00000000,00000= 000,00000000,00000000,00000000,00000000,00000003, core=3D00000000,00000000,= 00000000,00000000,ffffffff,ffffffff,ffffffff,ffffffff (XEN) CPU[02] nr_run=3D0, sort=3D188, sibling=3D00000000,00000000,0000000= 0,00000000,00000000,00000000,00000000,0000000c, core=3D00000000,00000000,00= 000000,00000000,ffffffff,ffffffff,ffffffff,ffffffff (XEN) CPU[03] nr_run=3D0, sort=3D13730, sibling=3D00000000,00000000,00000= 000,00000000,00000000,00000000,00000000,0000000c, core=3D00000000,00000000,= 00000000,00000000,ffffffff,ffffffff,ffffffff,ffffffff After: (XEN) CPU[00] nr_run=3D0, sort=3D1169, sibling=3D{0-1}, core=3D{0-127} (XEN) CPU[01] nr_run=3D0, sort=3D2488, sibling=3D{0-1}, core=3D{0-127} (XEN) CPU[02] nr_run=3D0, sort=3D1210, sibling=3D{2-3}, core=3D{0-127} (XEN) CPU[03] nr_run=3D0, sort=3D2476, sibling=3D{2-3}, core=3D{0-127} Signed-off-by: Andrew Cooper Acked-by: George Dunlap Reviewed-by: Juergen Gross --- CC: Juergen Gross CC: Dario Faggioli CC: George Dunlap 4.13 nice-to-have. Not strictly required, but it is a low risk change which improves diagnostics. --- xen/common/sched_credit.c | 2 +- xen/common/sched_credit2.c | 2 +- xen/common/sched_null.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/common/sched_credit.c b/xen/common/sched_credit.c index 645cdc5e9a..aa41a3301b 100644 --- a/xen/common/sched_credit.c +++ b/xen/common/sched_credit.c @@ -2065,7 +2065,7 @@ csched_dump_pcpu(const struct scheduler *ops, int cpu) spc =3D CSCHED_PCPU(cpu); runq =3D &spc->runq; =20 - printk("CPU[%02d] nr_run=3D%d, sort=3D%d, sibling=3D%*pb, core=3D%*pb\= n", + printk("CPU[%02d] nr_run=3D%d, sort=3D%d, sibling=3D{%*pbl}, core=3D{%= *pbl}\n", cpu, spc->nr_runnable, spc->runq_sort_last, CPUMASK_PR(per_cpu(cpu_sibling_mask, cpu)), CPUMASK_PR(per_cpu(cpu_core_mask, cpu))); diff --git a/xen/common/sched_credit2.c b/xen/common/sched_credit2.c index af58ee161d..f7c477053c 100644 --- a/xen/common/sched_credit2.c +++ b/xen/common/sched_credit2.c @@ -3658,7 +3658,7 @@ dump_pcpu(const struct scheduler *ops, int cpu) struct csched2_private *prv =3D csched2_priv(ops); struct csched2_unit *svc; =20 - printk("CPU[%02d] runq=3D%d, sibling=3D%*pb, core=3D%*pb\n", + printk("CPU[%02d] runq=3D%d, sibling=3D{%*pbl}, core=3D{%*pbl}\n", cpu, c2r(cpu), CPUMASK_PR(per_cpu(cpu_sibling_mask, cpu)), CPUMASK_PR(per_cpu(cpu_core_mask, cpu))); diff --git a/xen/common/sched_null.c b/xen/common/sched_null.c index da3fe29f21..3f3418c9b1 100644 --- a/xen/common/sched_null.c +++ b/xen/common/sched_null.c @@ -926,7 +926,7 @@ static void null_dump_pcpu(const struct scheduler *ops,= int cpu) =20 lock =3D pcpu_schedule_lock_irqsave(cpu, &flags); =20 - printk("CPU[%02d] sibling=3D%*pb, core=3D%*pb", + printk("CPU[%02d] sibling=3D{%*pbl}, core=3D{%*pbl}", cpu, CPUMASK_PR(per_cpu(cpu_sibling_mask, cpu)), CPUMASK_PR(per_cpu(cpu_core_mask, cpu))); if ( per_cpu(npc, cpu).unit !=3D NULL ) --=20 2.11.0 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel