From nobody Sat Apr 27 02:32:51 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail(p=none dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1572881536; cv=none; d=zoho.com; s=zohoarc; b=YUVbJAkXuXY8bxzIVqcQgJqM31ZAFzAv8oAlDctB2uwHY9k6Pd4GUBbLriwr0Wl93paqat4kV/AR19RHRW3qNGgSP2NarichxkOLh0fYN1ouuory2zBx77apZhCiI2teDsCxW4ZUPCRl3zWzpkhyciOf19rK3kXJPh099mY9EXI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1572881536; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=t6RoTaFxYQVPx0S4g//dzuDadoE3PbnZVO/oO7L+xAM=; b=lCz+Qj2bck9gWejChs6lOORIrUcp7+qpy2CTO3IL17elp84LX6S26T6uGBIwhLO35lhIKlAFCqZsw13/1qyYNcTIGbKh75Emsbs2S74SuJy8wiZ8EFWf7OAe4cuZzSFUQfUSx1NQCFTv6PghkwhOO3DXOvwoaBrQjmjYpZK1mKs= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1572881536523899.3199384476424; Mon, 4 Nov 2019 07:32:16 -0800 (PST) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iReJl-0008AV-OG; Mon, 04 Nov 2019 15:30:57 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iReJl-0008AQ-Cg for xen-devel@lists.xenproject.org; Mon, 04 Nov 2019 15:30:57 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 18199a40-ff18-11e9-9631-bc764e2007e4; Mon, 04 Nov 2019 15:30:56 +0000 (UTC) X-Inumbo-ID: 18199a40-ff18-11e9-9631-bc764e2007e4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1572881457; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=OVNr69J7iTrUVesWz3pgyddyZJTZVh8zfOLdea2x1TM=; b=fMezACitx+w2rh7sP2A6K0bZitQS1RhW1kpAM/yXHO4kgJ1s0U2yEUfa EFF0ZGdAfdYYzdUfGws+xIwvS8a+olcmKgfrJfXPCoAN6hbmpllzBI04a aDFLBv54/kJN4G3LamiwZV+qP8z3mC7/muNPE9htp3JmCGT2cQpFIFhvN w=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=anthony.perard@citrix.com; spf=Pass smtp.mailfrom=anthony.perard@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of anthony.perard@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa2.hc3370-68.iphmx.com: domain of anthony.perard@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: 0MyA82dzbK6BqnQtYFX4tUHkQof9KN8RvXNozCxLWPE/f+YUXSG4nzEaIXQYF/RgPNRYsmc4T0 N73MQC666P4uWvU5Hqk0zcTXWr9MDxUf2qPMFLugVImrmaVV+/E3071FjO8JRBvKpaO1Dvfsz7 vj+AsBa7ZSvZRLpuO8wc0NrUGq0nAyD6CEBHOorry1+ts82Ix46Utp4WGx8SUBatznhm4lizgT SZW2R3sgGuEsiIbMxi74pQlrvNOmt/xDlWq+iHudtlEgkVrENHHD/pYGjW42+cB33VXQ0ZWLhJ yy0= X-SBRS: 2.7 X-MesageID: 7811060 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.68,267,1569297600"; d="scan'208";a="7811060" From: Anthony PERARD To: Date: Mon, 4 Nov 2019 15:30:47 +0000 Message-ID: <20191104153047.568013-1-anthony.perard@citrix.com> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Subject: [Xen-devel] [XEN PATCH for-4.13] libxl: Fix setting vncpasswd to empty string X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Anthony PERARD , =?UTF-8?q?J=C3=BCrgen=20Gro=C3=9F?= , Ian Jackson , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Before 93dcc22, error from setting the vnc password to an empty string, when QEMU wasn't expected a password, never prevented the creation of a guest, and only logged an error message. Reported-by: Roger Pau Monn=C3=A9 Fixes: 93dcc22fe798c9fa5ce117f1ed6db0d8bd779020 Signed-off-by: Anthony PERARD Acked-by: Wei Liu --- tools/libxl/libxl_dm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c index 7e52f0973172..8e0fb78bd2f3 100644 --- a/tools/libxl/libxl_dm.c +++ b/tools/libxl/libxl_dm.c @@ -2936,7 +2936,7 @@ static void device_model_postconfig_vnc(libxl__egc *e= gc, if (rc) goto out; } =20 - if (vnc && vnc->passwd) { + if (vnc && vnc->passwd && vnc->passwd[0]) { qmp->callback =3D device_model_postconfig_vnc_passwd; libxl__qmp_param_add_string(gc, &args, "password", vnc->passwd); rc =3D libxl__ev_qmp_send(gc, qmp, "change-vnc-password", args); --=20 Anthony PERARD _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel