[Xen-devel] [XEN PATCH for-4.13] libxl: Fix setting vncpasswd to empty string

Anthony PERARD posted 1 patch 2 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/xen tags/patchew/20191104153047.568013-1-anthony.perard@citrix.com
tools/libxl/libxl_dm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

[Xen-devel] [XEN PATCH for-4.13] libxl: Fix setting vncpasswd to empty string

Posted by Anthony PERARD 2 weeks ago
Before 93dcc22, error from setting the vnc password to an empty
string, when QEMU wasn't expected a password, never prevented the creation
of a guest, and only logged an error message.

Reported-by: Roger Pau Monné <roger.pau@citrix.com>
Fixes: 93dcc22fe798c9fa5ce117f1ed6db0d8bd779020
Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 tools/libxl/libxl_dm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
index 7e52f0973172..8e0fb78bd2f3 100644
--- a/tools/libxl/libxl_dm.c
+++ b/tools/libxl/libxl_dm.c
@@ -2936,7 +2936,7 @@ static void device_model_postconfig_vnc(libxl__egc *egc,
         if (rc) goto out;
     }
 
-    if (vnc && vnc->passwd) {
+    if (vnc && vnc->passwd && vnc->passwd[0]) {
         qmp->callback = device_model_postconfig_vnc_passwd;
         libxl__qmp_param_add_string(gc, &args, "password", vnc->passwd);
         rc = libxl__ev_qmp_send(gc, qmp, "change-vnc-password", args);
-- 
Anthony PERARD


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [XEN PATCH for-4.13] libxl: Fix setting vncpasswd to empty string

Posted by Jürgen Groß 2 weeks ago
On 04.11.19 16:30, Anthony PERARD wrote:
> Before 93dcc22, error from setting the vnc password to an empty
> string, when QEMU wasn't expected a password, never prevented the creation
> of a guest, and only logged an error message.
> 
> Reported-by: Roger Pau Monné <roger.pau@citrix.com>
> Fixes: 93dcc22fe798c9fa5ce117f1ed6db0d8bd779020
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Release-acked-by: Juergen Gross <jgross@suse.com>


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [XEN PATCH for-4.13] libxl: Fix setting vncpasswd to empty string

Posted by Wei Liu 2 weeks ago
On Mon, Nov 04, 2019 at 03:30:47PM +0000, Anthony PERARD wrote:
> Before 93dcc22, error from setting the vnc password to an empty
> string, when QEMU wasn't expected a password, never prevented the creation
> of a guest, and only logged an error message.
> 
> Reported-by: Roger Pau Monné <roger.pau@citrix.com>
> Fixes: 93dcc22fe798c9fa5ce117f1ed6db0d8bd779020
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Acked-by: Wei Liu <wl@xen.org>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel