From nobody Fri Mar 29 08:59:35 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail(p=none dis=none) header.from=eu.citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1572541962; cv=none; d=zoho.com; s=zohoarc; b=CTGsdxubXRleYrtLend23053AqTp43aB8rA4wTQfX8yuyBoD7oBo8p+X8Xbndy848pyaDnyursQeTypnKHGlvKrzz76HRb+ESW0oOp2DjgI5XPAwZoglh0dpt2J7pTwxoycTD9+yLNfttEn+sdQCyjL/v4vtV9ytA/C0ef2u/uk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1572541962; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=VwQEkYg77QFH/8rdyruBb/S1h4eoXug0FVhdbu2rHxU=; b=YkfL2mDpFTPx3627iJGfv4X25q374YnnfhHyP5/MzydwQ3bPlASjNkw0aa+Dio7EklOE0YTiEGiJ/q+boyMW+VN1aHphJSP7RxzPqVa63rBAyoTwBqsGaqnRNvJeLSqhB0H70m0a88HF4fDeJl9jYVzSpmfVpcvAiJ0nMICiQro= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1572541962229929.0849423106598; Thu, 31 Oct 2019 10:12:42 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iQDyO-0003Xe-7C; Thu, 31 Oct 2019 17:11:00 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iQDyN-0003XZ-AW for xen-devel@lists.xenproject.org; Thu, 31 Oct 2019 17:10:59 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 676e7581-fc01-11e9-954e-12813bfff9fa; Thu, 31 Oct 2019 17:10:58 +0000 (UTC) X-Inumbo-ID: 676e7581-fc01-11e9-954e-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1572541857; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=3mPNLXvpjxQnUmDBA5LcICR/1ppwK5qqnjDVNl3I4Kg=; b=HxlLDnvgAjDPZI3HQtbEjY5IBtS4fBWko6R7VhOobr9rwYHIXbcEFCgF KJYCTArVb784XLw/J7Gx+XicPxjjBnO8YHdFMamSTJjVzeLmYmZOMvUrB Pz4xdgVFwRQk/inD0uamefwOCnLYhnXmPsFyHOFBZXK3aZsbgTJ3C9PMY k=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=ian.jackson@eu.citrix.com; spf=Pass smtp.mailfrom=Ian.Jackson@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: None (esa5.hc3370-68.iphmx.com: no sender authenticity information available from domain of ian.jackson@eu.citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa5.hc3370-68.iphmx.com; envelope-from="Ian.Jackson@citrix.com"; x-sender="ian.jackson@eu.citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa5.hc3370-68.iphmx.com: domain of Ian.Jackson@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa5.hc3370-68.iphmx.com; envelope-from="Ian.Jackson@citrix.com"; x-sender="Ian.Jackson@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa5.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa5.hc3370-68.iphmx.com; envelope-from="Ian.Jackson@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: gjLqlGuJjWxoRPkq+INrl9HUA1h1ZFCq7k5I59NjmcDvdszykFrLbLQon6+ZrTk+hkGkZyUqqN BR4fHOj9h0CNejyiHkkxWiwJCO5MZsu5hZyl0zaDKOnw8OGzGbYMvxLiwmeZbJZLqox7SmNtXC iqltcRX+GtjLAXffImHW7GFmz8m7c2ygwjJrSCgRCIKoKSCsSoy4oZr/ANPa4qpRLXYDG2TTWu la+lxtuteqPyhB0iSmCB6Hc+C8gaDzCKrDARKlB/k/HQrS8UKcdBBTFx0X3BF6ifavTuyaTMp3 HLQ= X-SBRS: 2.7 X-MesageID: 8021275 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.68,252,1569297600"; d="scan'208";a="8021275" From: Ian Jackson To: Date: Thu, 31 Oct 2019 17:10:29 +0000 Message-ID: <20191031171029.3627-1-ian.jackson@eu.citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Subject: [Xen-devel] [OSSTEST PATCH] grub2 setup: Set GRUB_TERMINAL=console, if no other setting X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?J=C3=BCrgen=20Gro=C3=9F?= , Brian Woods , Julien Grall , Stefano Stabellini , Ian Jackson Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) The default for d-i, if it doesn't know better, is to let update-grub set grub's terminal to `gfxterm'. But in osstest we do not really ever want to use a graphical console. Let us discuss some of the cases in a bit more detail: On UEFI systems with a serial console, the UEFI console ought (and in our installation is in all cases so far) typically linked to the serial console. So GRUB_TERMINAL=3Dconsole would be right for UEFI. This appears to be correct on the albanas, our one pair of in-service x86 boxes with a UEFI firmware configuration. But on x86 systems, we generally pass console=3DttyS... arguments on the d-i command line, and d-i arranges for GRUB_TERMINAL=3Dserial and appropriate other settings. We already have a workaround that changes that to "serial console", which is fine whether "console" means a VGA console we don't look at, or some kind of BIOS console redirection. This currently works on all our x86 machines including o UEFI. On our ThunderX (arm64) boxes, `gfxterm' does not work at all. `console', does, because it goes to the UEFI console which UEFI sends to the serial port. The best approach to unpicking this mess seems to be to apply a default setting of GRUB_TERMINAL=3Dconsole. The effect of this is to change `gfxterm' in grub.cfg. In practice all our x86 boxes (including our x86 UEFI boxes, where `console' would work) have it set to `serial' (modified by us to `serial console') so remain unchanged. The net result is that on ARM, we now set `GRUB_TERMINAL=3Dconsole', and we now get all of the bootloader serial output on the rochesters. I have tested this on: rochester0 - arm64 uefi ThunderX, used not to work laxton1 - arm64 uefi SoftIron albana0 - x86 uefi huxelrebe0 - x86 bios arndale-westfield - armhf u-boot cubietruck-gleizes - armhf u-boot Thanks to Brian Woods for poking at rochester0 and making the key suggestions. CC: Brian Woods CC: Stefano Stabellini CC: Julien Grall CC: J=C3=BCrgen Gro=C3=9F Signed-off-by: Ian Jackson --- Osstest/Debian.pm | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Osstest/Debian.pm b/Osstest/Debian.pm index 79aa2d24..c22aaadf 100644 --- a/Osstest/Debian.pm +++ b/Osstest/Debian.pm @@ -624,9 +624,11 @@ END =20 target_editfile_root($ho, '/etc/default/grub', sub { my %k; + my $had_terminal; while (<::EI>) { # some bioses block the serial still so we try vga too s/^(GRUB_TERMINAL=3D)(['"]?)serial\2\s*$/$1'serial console'\n/; + $had_terminal ||=3D m/^GRUB_TERMINAL=3D/; =20 if (m/^\s*([A-Z_]+)\s*\=3D\s*(.*?)\s*$/) { my ($k,$v) =3D ($1,$2); @@ -636,6 +638,11 @@ END next if m/^GRUB_CMDLINE_(?:XEN|LINUX(?:_XEN_REPLACE)?(?:_D= EFAULT)?).*\=3D|^GRUB_DEFAULT.*\=3D/; print ::EO; } + print ::EO <{MenuEntryPath}" --=20 2.11.0 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel