From nobody Thu Apr 25 10:50:22 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail(p=none dis=none) header.from=eu.citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1572451865; cv=none; d=zoho.com; s=zohoarc; b=iUnBPc3YzeMKRLU8EOzJrKqzw9q7fMcTwtrgpf/ISR4D3ClpZM4yGOBBU+pa64tIvzrBNwyw00WO7OEkeHjs/8Rms1k3gnTW49hCo6fkRnQg3J5XVm5Hp47fpoEx7GAghJq5EHAMsWcaS/fIR+tEUExGc9UkFSv06ypNJe7BGKY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1572451865; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=Z/jDOvO4Bc0XgIVlJVcyEALiwQhJgzfJ9B3H2HH+8ak=; b=b36TTHjbsJKfLhZrd9jyTkhBE/TncdZ+7Sd1lrOApYiDK5qhiNesu0BPnO74zdziuJMciBcOWJBdbtU+46X8y1g8DJX+M2EAMwgJCAY6HT/GMtBpyuclhXmzPnUOKOnBqQImjFAy2S35WtQbJ6rVslJyEXSWyp9WqlTDoWsGtT4= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1572451865899997.7318830380874; Wed, 30 Oct 2019 09:11:05 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iPqXi-0001n2-0F; Wed, 30 Oct 2019 16:09:54 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iPqXh-0001mw-Fk for xen-devel@lists.xenproject.org; Wed, 30 Oct 2019 16:09:53 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b3f1c344-fb2f-11e9-beca-bc764e2007e4; Wed, 30 Oct 2019 16:09:52 +0000 (UTC) X-Inumbo-ID: b3f1c344-fb2f-11e9-beca-bc764e2007e4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1572451793; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=QDb0PpdNtwQ0AG5ps/gVfjxYd+q31U33P43gd2HvYYw=; b=T0lfo5wtcp1DuFIG+2FVrQ3Pgf5cVPprd1oqo5zcUvQLHnIRjEwAa0px Kwt0UPU/ywoIAXOEOnI8LJhaSkZRejCkle8fnX0SmNoDvPt8EXY7o6Hsd Oj8Hd3EW/j6IL5T+eCAsBcQMjyAHg+4yiF4gRcDfrGJJiuzaGiKO/1HEm 0=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=ian.jackson@eu.citrix.com; spf=Pass smtp.mailfrom=Ian.Jackson@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: None (esa1.hc3370-68.iphmx.com: no sender authenticity information available from domain of ian.jackson@eu.citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa1.hc3370-68.iphmx.com; envelope-from="Ian.Jackson@citrix.com"; x-sender="ian.jackson@eu.citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa1.hc3370-68.iphmx.com: domain of Ian.Jackson@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa1.hc3370-68.iphmx.com; envelope-from="Ian.Jackson@citrix.com"; x-sender="Ian.Jackson@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa1.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa1.hc3370-68.iphmx.com; envelope-from="Ian.Jackson@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: BTxySh6mupme50ew2zbwmgIbcH9etBbpSqAoBCv9ExrhtwkQR1NvBgkbzo0mrHIGvm+YYc7zkb odCiT74xV41anyLGxrJ937WQV+lAqJlNNnnq+I5fc/YgxmQEQC+oWwSPUhe9OTiS0UIRnRSzBZ auEY50tHjn0sdnPq5nzetWr/xU3spI6t/DlOS8q66vMmFS8lupdJUMSUHX4vkyHYwrBWO8ayx+ MvMLoz6peLFjLKK/SPCOFq4XULHss8R/mpITKFv6LcvTgjXnRrkIJyJljPe7NTyByHI20nruLX O3E= X-SBRS: 2.7 X-MesageID: 7732010 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.68,247,1569297600"; d="scan'208";a="7732010" From: Ian Jackson To: Date: Wed, 30 Oct 2019 16:09:37 +0000 Message-ID: <20191030160937.19420-1-ian.jackson@eu.citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Subject: [Xen-devel] [OSSTEST PATCH] xl guest creation: Pause 10s to work around libxl/blkback races X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?J=C3=BCrgen=20Gro=C3=9F?= , Anthony PERARD , Ian Jackson , Wei Liu Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) In ea6626f7edd9eb40a3510eaf6816a77cac4f63d0 guest_prepare_disk: Only do the umount if we set an env var we removed (in the usual case) a check for the guest disk already being mounted in dom0 etc. This check is there for ad-hoc testing. We removed it because it exposes what we think is an annoying race in blkback. Unfortunately this change seems to have made guest-rapid-restart races worse rather than better. Steps test-* guest-start/debian.repeat seem to fail a lot more now. We are in the throes of preparing the Xen 4.13 release. These guest restart races have existed for a long time. Bodge this for now by adding a sleep :-/. We do this in the xl toolstack, during domain creation. And also in the libvirt toolstack because that uses xl but doesn't inherit the sleep from the Osstest module. CC: J=C3=BCrgen Gro=C3=9F CC: Wei Liu CC: Anthony PERARD Signed-off-by: Ian Jackson --- Osstest/Toolstack/libvirt.pm | 1 + Osstest/Toolstack/xl.pm | 1 + 2 files changed, 2 insertions(+) diff --git a/Osstest/Toolstack/libvirt.pm b/Osstest/Toolstack/libvirt.pm index e817f5b4..23c76cc0 100644 --- a/Osstest/Toolstack/libvirt.pm +++ b/Osstest/Toolstack/libvirt.pm @@ -55,6 +55,7 @@ sub create ($$) { my $lcfg =3D $cfg; $lcfg =3D~ s,/,-,g; $lcfg =3D hostnamepath($ho)."--$lcfg"; + sleep(10); target_cmd_root($ho, "virsh domxml-from-native xen-xl $cfg > $cfg.xml"= , 30); target_getfile_root($ho,60,"$cfg.xml", "$stash/$lcfg"); target_cmd_root($ho, "virsh create --file $cfg.xml", 100); diff --git a/Osstest/Toolstack/xl.pm b/Osstest/Toolstack/xl.pm index 85972753..517b0f4d 100644 --- a/Osstest/Toolstack/xl.pm +++ b/Osstest/Toolstack/xl.pm @@ -43,6 +43,7 @@ sub destroy ($$) { sub _create ($$$) { my ($self,$gho,$options) =3D @_; my $cfg =3D $gho->{CfgPath}; + sleep(10); target_cmd_root($self->{Host}, $self->{_VerboseCommand}." create $options $cfg", 100); } --=20 2.11.0 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel