From nobody Sat Apr 27 00:51:17 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail(p=none dis=none) header.from=eu.citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1572371933; cv=none; d=zoho.com; s=zohoarc; b=a+yFv2Wts322yXBW7nWqMmYO9myAZAeLj1gWKv5n9SWoaZVzQG+HnOLM8K25bzKfza69pWJxJ8e+aEfgd9cQ6ffMjLvuunSmQ7zrpi3bXXuidrUHBeYTInyEr7Hbax8DIygWoCbemUoVMSQqwTdrBLBcTSV3+AfVCBtREjj31K4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1572371933; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=YHRiRTnp3imPwJQvJnmcGccqbZY1JaGDNIu0iiiFsi4=; b=ZdIQh8J9Ht8gU4ZNqwRlmktQqM39aExmTHPHiCVWxTmVsp8GqT5qa6VKFJspgLRbCByqGpdi3gI7uYSk6gRqBirxx4L5e4dyH3jYMQhWftAbUmHQ32Llq7R0/iKKVul32wSGIuTq1ImBzPAf4YtX4WWxS4btK1rkoCDQznkYr6s= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 157237193311787.50499145127799; Tue, 29 Oct 2019 10:58:53 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iPVkG-0002OG-Ae; Tue, 29 Oct 2019 17:57:28 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iPVkE-0002OB-Pl for xen-devel@lists.xenproject.org; Tue, 29 Oct 2019 17:57:26 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 9075a76a-fa75-11e9-bbab-bc764e2007e4; Tue, 29 Oct 2019 17:57:25 +0000 (UTC) X-Inumbo-ID: 9075a76a-fa75-11e9-bbab-bc764e2007e4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1572371845; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=PHDOqdd3Btv6Rq5lFsK2wS+5odjzlKpkCbkP56Ia6EA=; b=UWcDLg1t2r2zf3BMjXnFHT5FbvDp0CzrX/D11v9+R2NYNDQqWn0WY/0U ojYU70WxiWWWmuNTIjhLviBSxZ8DeCTkPi9zy9SIYmZLv8k9ko7fxzvtv bx/du+yRtW1xkd9aU0wKN9Nl8b4m1pBztKA8T8EivPoWgu5Ye6AUV6xZZ w=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=ian.jackson@eu.citrix.com; spf=Pass smtp.mailfrom=Ian.Jackson@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: None (esa6.hc3370-68.iphmx.com: no sender authenticity information available from domain of ian.jackson@eu.citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="Ian.Jackson@citrix.com"; x-sender="ian.jackson@eu.citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa6.hc3370-68.iphmx.com: domain of Ian.Jackson@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="Ian.Jackson@citrix.com"; x-sender="Ian.Jackson@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa6.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="Ian.Jackson@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: WVXG0aqqeHUoCZsC3YmXBcFEG0od2JTnnc0tSOThJbO0YVX9hzWxtBzLokcianfiZFXJ/6bmXS +1FKOeMmlXju8Ve/zucArcQop1OV7unEvPf/RL5K2ZA2IbX4ANzkA2dM8sxix84zhm8n+F9SFA 5XAaqlRhiu/sZzkIMxuDufBw5KqTmYXiAI1nfgvQE19tQx5/qmVxodhy5h9NWGLo8NwsUt+hP8 VofTOZ1E8qHB/N/C6sy3hxteUm6KfHR5tmOFEJyNmmpdiQCiNxbdy/y+2/LpR2BA0y/EqylqLx bZM= X-SBRS: 2.7 X-MesageID: 7944013 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.68,244,1569297600"; d="scan'208";a="7944013" From: Ian Jackson To: Date: Tue, 29 Oct 2019 17:57:20 +0000 Message-ID: <20191029175720.7354-1-ian.jackson@eu.citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Subject: [Xen-devel] [XEN PATCH for-4.13] tools/configure: Honour XEN_COMPILE_ARCH and _TARGET_ for shim X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?J=C3=BCrgen=20Gro=C3=9F?= , Ian Jackson Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) The pvshim can only be built 64-bit because the hypervisor is only 64-bit nowadays. The hypervisor build supports XEN_COMPILE_ARCH and XEN_TARGET_ARCH which override the information from uname. The pvshim build runs out of the tools/ directory but calls the hypervisor build system. If one runs in a Linux 32-bit userland with a 64-bit kernel, one used to be able to set XEN_COMPILE_ARCH. But nowadays this does not work. configure sees the target cpu as 64-bit and tries to build pvshim. The build prints echo "*** Xen x86/32 target no longer supported!" and doesn't build anything. Then the subsequent Makefiles try to install the non-built pieces. Fix this anomaly by causing configure to honour the Xen hypervisor way of setting the target architecture. In principle this user behaviour is not handled quite right, because configure will still see 64-bit and so all the autoconf-based architecture testing will see 64-bit rather than 32-bit x86. But the tools are in fact generally quite portable: this particular location in configure{.ac,} is the only place in tools/ where 64-bit x86 is treated differently from 32-bit x86, so the fix is sufficient and correct for this use case. It remains the case that XEN_COMPILE_ARCH or XEN_TARGET_ARCH to a non-x86 architecture, when configure thinks things are x86, or vice versa, will not work right. I have rerun autogen.sh, so this patch contains the fix to configure as well as the source fix to configure.ac. Signed-off-by: Ian Jackson CC: J=C3=BCrgen Gro=C3=9F Reviewed-by: Roger Pau Monn=C3=A9 Reviewed-by: Wei Liu --- tools/configure | 2 +- tools/configure.ac | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/configure b/tools/configure index 82947ad308..d9ccce6d2b 100755 --- a/tools/configure +++ b/tools/configure @@ -9711,7 +9711,7 @@ fi else =20 cpu=3D`test -z "$target_cpu" && echo "$host_cpu" || echo "$target_cpu"` - case "$cpu" in + case "${XEN_COMPILE_ARCH-${XEN_TARGET_ARCH-$cpu}}" in x86_64) pvshim=3D"y";; *) pvshim=3D"n";; diff --git a/tools/configure.ac b/tools/configure.ac index 674bd5809d..a8d8ce5ffe 100644 --- a/tools/configure.ac +++ b/tools/configure.ac @@ -479,7 +479,7 @@ AC_ARG_ENABLE([pvshim], [Disable pvshim build (enabled by default on 64bit x86)= ]), [AS_IF([test "x$enable_pvshim" =3D "xno"], [pvshim=3Dn], [pvshim=3Dy])= ], [ cpu=3D`test -z "$target_cpu" && echo "$host_cpu" || echo "$target_cpu"` - case "$cpu" in + case "${XEN_COMPILE_ARCH-${XEN_TARGET_ARCH-$cpu}}" in x86_64) pvshim=3D"y";; *) pvshim=3D"n";; --=20 2.11.0 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel