From nobody Thu May 2 14:45:23 2024 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1571926964; cv=none; d=zoho.com; s=zohoarc; b=Jv5qfABDudgxw6mNGWXhVMgbpK3ODDAifYKPRWB0L1f3+beJoS1jotLrTq7WRKiVX652SHCX6wtMUP6VLDxei5MjeWOIGH65Xmqu4KvJ5abGoaPWiWBa2OihRN+QIycGV2Uupsyt4HonoZ7lmMOuZrSMnQlrtP8V9A8T+g4SpWA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1571926964; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=x/sNmozAcO5euZ/pre8ArJA34p3U/nWaEaDUCwkWzjU=; b=ZayzykA8BmEo8g5u95jonQ1mdqSuQr6VWcYCfV75ycEn2yg1zUIQu16qBL1/LlrUAzqEL7oknegxZDDLBHkrMsw0qUoCOgqXsotyjpwwHPOrNEchODxjxOqUVj9MqcY1DFiGkr+B4EBaT+FOt5oR3nPRRM4SZrEarwlRGbjGEew= ARC-Authentication-Results: i=1; mx.zoho.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1571926964036942.962841247997; Thu, 24 Oct 2019 07:22:44 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iNdzL-0000eu-P1; Thu, 24 Oct 2019 14:21:19 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iNdzJ-0000eA-Te for xen-devel@lists.xenproject.org; Thu, 24 Oct 2019 14:21:17 +0000 Received: from smtp-fw-6001.amazon.com (unknown [52.95.48.154]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 8ad076ba-f669-11e9-94a3-12813bfff9fa; Thu, 24 Oct 2019 14:21:17 +0000 (UTC) Received: from iad6-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-1d-5dd976cd.us-east-1.amazon.com) ([10.124.125.6]) by smtp-border-fw-out-6001.iad6.amazon.com with ESMTP; 24 Oct 2019 14:21:17 +0000 Received: from EX13MTAUEA001.ant.amazon.com (iad55-ws-svc-p15-lb9-vlan2.iad.amazon.com [10.40.159.162]) by email-inbound-relay-1d-5dd976cd.us-east-1.amazon.com (Postfix) with ESMTPS id 874FEA2914; Thu, 24 Oct 2019 14:21:15 +0000 (UTC) Received: from EX13D32EUB004.ant.amazon.com (10.43.166.212) by EX13MTAUEA001.ant.amazon.com (10.43.61.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 24 Oct 2019 14:21:14 +0000 Received: from EX13MTAUWB001.ant.amazon.com (10.43.161.207) by EX13D32EUB004.ant.amazon.com (10.43.166.212) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 24 Oct 2019 14:21:13 +0000 Received: from CBG-5CG9341D0C.cbg10.amazon.com (10.55.227.46) by mail-relay.amazon.com (10.43.161.249) with Microsoft SMTP Server id 15.0.1367.3 via Frontend Transport; Thu, 24 Oct 2019 14:21:11 +0000 X-Inumbo-ID: 8ad076ba-f669-11e9-94a3-12813bfff9fa IronPort-SDR: 8lY5UTrKzgBnwzNUPr5njIOvc98Pba1LBCU9X/8Hn50q7X22pApuHe+1FfV63EAcO8TibXGDh+ R1YD8YNio7PQ== X-IronPort-AV: E=Sophos;i="5.68,224,1569283200"; d="scan'208";a="232578" From: To: Date: Thu, 24 Oct 2019 15:21:03 +0100 Message-ID: <20191024142103.962-1-paul@xen.org> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Precedence: Bulk Subject: [Xen-devel] [PATCH] tools/hotpug: only attempt to call 'ip route' if there is valid command X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Wei Liu , Paul Durrant , Ian Jackson Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Paul Durrant The vif-route script should only call 'ip route' when 'ipcmd' has been set, otherwise it will fail due to an incorrect command string. Signed-off-by: Paul Durrant --- Cc: Ian Jackson Cc: Wei Liu This appears to have been broken forever. --- tools/hotplug/Linux/vif-route | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/hotplug/Linux/vif-route b/tools/hotplug/Linux/vif-route index c149ffca73..98893d90b6 100644 --- a/tools/hotplug/Linux/vif-route +++ b/tools/hotplug/Linux/vif-route @@ -35,7 +35,7 @@ case "${command}" in ;; esac =20 -if [ "${ip}" ] ; then +if [ "${ipcmd}" ] ; then # If we've been given a list of IP addresses, then add routes from dom= 0 to # the guest using those addresses. for addr in ${ip} ; do --=20 2.17.1 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel