arch/arm/xen/mm.c | 1 + 1 file changed, 1 insertion(+)
Include <xen/xen-ops.h> for xen_{create,destroy}_contigous_region
call declarations. Fixes the following sparse warnings:
arch/arm/xen/mm.c:119:5: warning: symbol 'xen_create_contiguous_region' was not declared. Should it be static?
arch/arm/xen/mm.c:131:6: warning: symbol 'xen_destroy_contiguous_region' was not declared. Should it be static?
Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>
---
Cc: Stefano Stabellini <sstabellini@kernel.org>
Cc: Russell King <linux@armlinux.org.uk>
Cc: xen-devel@lists.xenproject.org
Cc: linux-arm-kernel@lists.infradead.org
---
arch/arm/xen/mm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c
index 38fa917c8585..6feb6b78b13c 100644
--- a/arch/arm/xen/mm.c
+++ b/arch/arm/xen/mm.c
@@ -15,6 +15,7 @@
#include <xen/interface/grant_table.h>
#include <xen/interface/memory.h>
#include <xen/page.h>
+#include <xen/xen-ops.h>
#include <xen/swiotlb-xen.h>
#include <asm/cacheflush.h>
--
2.23.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
On Tue, 22 Oct 2019, Ben Dooks (Codethink) wrote: > Include <xen/xen-ops.h> for xen_{create,destroy}_contigous_region > call declarations. Fixes the following sparse warnings: > > arch/arm/xen/mm.c:119:5: warning: symbol 'xen_create_contiguous_region' was not declared. Should it be static? > arch/arm/xen/mm.c:131:6: warning: symbol 'xen_destroy_contiguous_region' was not declared. Should it be static? > > Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org> > --- > Cc: Stefano Stabellini <sstabellini@kernel.org> > Cc: Russell King <linux@armlinux.org.uk> > Cc: xen-devel@lists.xenproject.org > Cc: linux-arm-kernel@lists.infradead.org > --- > arch/arm/xen/mm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c > index 38fa917c8585..6feb6b78b13c 100644 > --- a/arch/arm/xen/mm.c > +++ b/arch/arm/xen/mm.c > @@ -15,6 +15,7 @@ > #include <xen/interface/grant_table.h> > #include <xen/interface/memory.h> > #include <xen/page.h> > +#include <xen/xen-ops.h> > #include <xen/swiotlb-xen.h> > > #include <asm/cacheflush.h> > -- > 2.23.0 > _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
On Tue, 22 Oct 2019, Stefano Stabellini wrote: > On Tue, 22 Oct 2019, Ben Dooks (Codethink) wrote: > > Include <xen/xen-ops.h> for xen_{create,destroy}_contigous_region > > call declarations. Fixes the following sparse warnings: > > > > arch/arm/xen/mm.c:119:5: warning: symbol 'xen_create_contiguous_region' was not declared. Should it be static? > > arch/arm/xen/mm.c:131:6: warning: symbol 'xen_destroy_contiguous_region' was not declared. Should it be static? > > > > Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk> > > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org> Do you want me to pick up these two patches and have them go upstream via the Xen tree, or are they part of a bigger rework? _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
On 22/10/2019 18:09, Stefano Stabellini wrote: > On Tue, 22 Oct 2019, Stefano Stabellini wrote: >> On Tue, 22 Oct 2019, Ben Dooks (Codethink) wrote: >>> Include <xen/xen-ops.h> for xen_{create,destroy}_contigous_region >>> call declarations. Fixes the following sparse warnings: >>> >>> arch/arm/xen/mm.c:119:5: warning: symbol 'xen_create_contiguous_region' was not declared. Should it be static? >>> arch/arm/xen/mm.c:131:6: warning: symbol 'xen_destroy_contiguous_region' was not declared. Should it be static? >>> >>> Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk> >> >> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org> > > Do you want me to pick up these two patches and have them go upstream > via the Xen tree, or are they part of a bigger rework? I've been doing some testing with sparse and going fixing warnings as I go along. Please take these via your tree. -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius https://www.codethink.co.uk/privacy.html _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
© 2016 - 2024 Red Hat, Inc.