From nobody Sat Apr 27 16:20:57 2024 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1571384829; cv=none; d=zoho.com; s=zohoarc; b=dCQSi324FNq7yEcFoAQnkDB8xHrLvlEg8dt/M2hdhM83OFFKUo+10AnwmBhWgvqdNf2QLxxk4nUIY1zAP9q81ekuvhS73hs9x/XqS7BtGsvWVOXxRNYMEmhvMZQEaoPRDAFB6/5m4ZSaUJiSv+18uKawRX+Yy5+QXHrCsSKmFQA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1571384829; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=YV8pXrrTT/4VuPoZ9StTpqTndpvHK20PIuhLWLUeQ2c=; b=oh8t2ovkUxUyFXUC4D2ETFqxicjFN0Z9PlAKShgs8XVLBYmj25oSq6WxizO6DV/pib5VTbaYdp2H5gaMtKkxvHCclKuUJap6Bxm2RnB4vroIlblQizQronXeen82OlA1rnsXXULeVb7Xnw/0U62SUOF1jp3QCcvh4f1SLQ5lbwI= ARC-Authentication-Results: i=1; mx.zoho.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1571384829811133.3492964481942; Fri, 18 Oct 2019 00:47:09 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iLMxQ-0007nM-1g; Fri, 18 Oct 2019 07:45:56 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iLMxO-0007mT-AW for xen-devel@lists.xenproject.org; Fri, 18 Oct 2019 07:45:54 +0000 Received: from mx1.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 4f2d5cec-f17b-11e9-beca-bc764e2007e4; Fri, 18 Oct 2019 07:45:52 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id C8E74B6D9; Fri, 18 Oct 2019 07:45:51 +0000 (UTC) X-Inumbo-ID: 4f2d5cec-f17b-11e9-beca-bc764e2007e4 X-Virus-Scanned: by amavisd-new at test-mx.suse.de From: Juergen Gross To: xen-devel@lists.xenproject.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 18 Oct 2019 09:45:49 +0200 Message-Id: <20191018074549.4778-1-jgross@suse.com> X-Mailer: git-send-email 2.16.4 Subject: [Xen-devel] [PATCH] xen/netback: fix error path of xenvif_connect_data() X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , Wei Liu , "David S. Miller" , stable@vger.kernel.org, Paul Durrant MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" xenvif_connect_data() calls module_put() in case of error. This is wrong as there is no related module_get(). Remove the superfluous module_put(). Fixes: 279f438e36c0a7 ("xen-netback: Don't destroy the netdev until the vif= is shut down") Cc: # 3.12 Signed-off-by: Juergen Gross Reviewed-by: Paul Durrant Reviewed-by: Wei Liu --- drivers/net/xen-netback/interface.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/= interface.c index 240f762b3749..103ed00775eb 100644 --- a/drivers/net/xen-netback/interface.c +++ b/drivers/net/xen-netback/interface.c @@ -719,7 +719,6 @@ int xenvif_connect_data(struct xenvif_queue *queue, xenvif_unmap_frontend_data_rings(queue); netif_napi_del(&queue->napi); err: - module_put(THIS_MODULE); return err; } =20 --=20 2.16.4 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel