From nobody Sat Apr 27 02:10:47 2024 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1570208279; cv=none; d=zoho.com; s=zohoarc; b=jLh1Un0LVkzrqwje0G5jxcDkkWW4QCGUCcuKnMSG30bXXfxvkLpapBP/PwOL/r7L6acy0AjF1+jj8q7Y9Eh9sgMInjdYlY5tcIYJ7bLDNEr2N8ufhbprL90GCOM362aLf+k5A7ZLBEmPKMBBsbHcG8vwxvF7JzSNYwiu0D73JWk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1570208279; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=+EqZcO2p05ZYj8NA66KZbaArNDifvJvbqspm2fizZ/s=; b=UZy67SDgzYtE555i85Y3Kcw025eCo1yamitk7O+GOOVPIdDPzxMHSxXIc9DqPXMDRjHmobYmqa0xFabu0PB+FdsL0vIMu/trWRnlihS6pj/2Cb0yYsenMMdHbps+1UiRrrbvd3omeqHttdLXdr8Hcp8BNjiajmQZ/MK8NDRtX44= ARC-Authentication-Results: i=1; mx.zoho.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1570208279677497.4086370203727; Fri, 4 Oct 2019 09:57:59 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iGQsw-00044P-2L; Fri, 04 Oct 2019 16:56:54 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iGQsu-00044K-AW for xen-devel@lists.xenproject.org; Fri, 04 Oct 2019 16:56:52 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id f5f769aa-e6c7-11e9-975d-12813bfff9fa; Fri, 04 Oct 2019 16:56:51 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E4EBF15AB; Fri, 4 Oct 2019 09:56:50 -0700 (PDT) Received: from e108454-lin.cambridge.arm.com (e108454-lin.cambridge.arm.com [10.1.196.50]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3B5EA3F68E; Fri, 4 Oct 2019 09:56:50 -0700 (PDT) X-Inumbo-ID: f5f769aa-e6c7-11e9-975d-12813bfff9fa From: Julien Grall To: xen-devel@lists.xenproject.org Date: Fri, 4 Oct 2019 17:56:46 +0100 Message-Id: <20191004165646.14482-1-julien.grall@arm.com> X-Mailer: git-send-email 2.11.0 Subject: [Xen-devel] [PATCH for-4.13] xen/xsm: flask: Check xmalloc_array() return in security_sid_to_context() X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: jgross@suse.com, Julien Grall , Daniel De Graaf MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" xmalloc_array() may return NULL if there are memory. Rather than trying to deference it directly, we should check the return value first. Coverity-ID: 1381852 Signed-off-by: Julien Grall --- xen/xsm/flask/ss/services.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xen/xsm/flask/ss/services.c b/xen/xsm/flask/ss/services.c index b59928ea8a..42686535f2 100644 --- a/xen/xsm/flask/ss/services.c +++ b/xen/xsm/flask/ss/services.c @@ -775,6 +775,8 @@ int security_sid_to_context(u32 sid, char **scontext, u= 32 *scontext_len) =20 *scontext_len =3D strlen(initial_sid_to_string[sid]) + 1; scontextp =3D xmalloc_array(char, *scontext_len); + if ( !scontextp ) + return -ENOMEM; strlcpy(scontextp, initial_sid_to_string[sid], *scontext_len); *scontext =3D scontextp; goto out; --=20 2.11.0 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel