From nobody Fri Apr 26 17:10:23 2024 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1570207447; cv=none; d=zoho.com; s=zohoarc; b=ggbvDPYDpYBXq1tyPfIgK44E9PquwDz0tUHhtCS0BDguvAkAGZgWMZmi/wHGGkQVtzoheOa5wnlUj28me6mAEhHTzwD5gUrzte1i2GQ8c3RYkoKn5bFhcuF7bH8yrBYEVNQBGm1yc3TJZEaXnIQp2t/a8UnJkmfYgrGdtVSXxdY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1570207447; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=IpOrT+IMgbVYIo36qzoXhdprepZtqHMzoTmwHjA6luQ=; b=UQjBWAGmyp7pFqffXDFnY32HDb4OUXvLE9BjHy0XtVPEPki1yOGXVuSpyJrwk+hUcC6yxR1bj9oGoql1k9j6BBIbA8Y+BYw/Xy8IrpgWzUfc3iCkrvn6+7rkVNIrvvCBgIdn0ey2TfYRxZOoI/ODiwLdmsYVcMBgdNrOENv4jYE= ARC-Authentication-Results: i=1; mx.zoho.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1570207447487682.2228266231336; Fri, 4 Oct 2019 09:44:07 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iGQfM-0002z5-1X; Fri, 04 Oct 2019 16:42:52 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iGQfK-0002z0-90 for xen-devel@lists.xenproject.org; Fri, 04 Oct 2019 16:42:50 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id fffd7842-e6c5-11e9-80e3-bc764e2007e4; Fri, 04 Oct 2019 16:42:49 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 98DBC15AB; Fri, 4 Oct 2019 09:42:48 -0700 (PDT) Received: from e108454-lin.cambridge.arm.com (e108454-lin.cambridge.arm.com [10.1.196.50]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CBFC73F68E; Fri, 4 Oct 2019 09:42:47 -0700 (PDT) X-Inumbo-ID: fffd7842-e6c5-11e9-80e3-bc764e2007e4 From: Julien Grall To: xen-devel@lists.xenproject.org Date: Fri, 4 Oct 2019 17:42:43 +0100 Message-Id: <20191004164243.30822-1-julien.grall@arm.com> X-Mailer: git-send-email 2.11.0 Subject: [Xen-devel] [PATCH for-4.13] xen/xsm: flask: Prevent NULL deference in flask_assign_{, dt}device() X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: jgross@suse.com, Julien Grall , Daniel De Graaf , paul@xen.org MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" flask_assign_{, dt}device() may be used to check whether you can test if a device is assigned. In this case, the domain will be NULL. However, flask_iommu_resource_use_perm() will be called and may end up to deference a NULL pointer. This can be prevented by moving the call after we check the validity for the domain pointer. Coverity-ID: 1486741 Fixes: 71e617a6b8 ('use is_iommu_enabled() where appropriate...') Signed-off-by: Julien Grall Reviewed-by: Paul Durrant --- xen/xsm/flask/hooks.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c index 3b30827764..cf7f25cda2 100644 --- a/xen/xsm/flask/hooks.c +++ b/xen/xsm/flask/hooks.c @@ -1296,11 +1296,13 @@ static int flask_assign_device(struct domain *d, ui= nt32_t machine_bdf) u32 dsid, rsid; int rc =3D -EPERM; struct avc_audit_data ad; - u32 dperm =3D flask_iommu_resource_use_perm(d); + u32 dperm; =20 if ( !d ) return flask_test_assign_device(machine_bdf); =20 + dperm =3D flask_iommu_resource_use_perm(d); + rc =3D current_has_perm(d, SECCLASS_RESOURCE, RESOURCE__ADD); if ( rc ) return rc; @@ -1355,11 +1357,13 @@ static int flask_assign_dtdevice(struct domain *d, = const char *dtpath) u32 dsid, rsid; int rc =3D -EPERM; struct avc_audit_data ad; - u32 dperm =3D flask_iommu_resource_use_perm(d); + u32 dperm; =20 if ( !d ) return flask_test_assign_dtdevice(dtpath); =20 + dperm =3D flask_iommu_resource_use_perm(d); + rc =3D current_has_perm(d, SECCLASS_RESOURCE, RESOURCE__ADD); if ( rc ) return rc; --=20 2.11.0 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel