From nobody Mon Feb 9 11:30:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1568913492; cv=none; d=zoho.com; s=zohoarc; b=HzRrAN7fM+uz60TrDsK60UBGXbbhnvLu7IrRoDZcbL8yGRiT2axoq1MJ7RvAzpd8hk7izSc68fKhBZcf8Aqx/M+iM2uhKbksNeb8QInrBkjPwZfLdpPbstMVPetNgM7y7k5a3dc55u7XFywCc6HvDQjKmYN6ruNvLG5wTWI9ZnY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1568913492; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=I2F9FDlzy0RqxFnCyf7lhhSwx/BkaR4I+SEnsZEJqnQ=; b=SWEXHH69avOjQbHdBWlOYIGhlK/ma+Z+oRL8XodYJQi0f/Jz+IsU/Ndxy0VYCkhojk5nwlw0G01cydhuiVMU3B2V/JtnelVVXrNmGUv80RKneMOzkxinHrqIFEPjmN5fMx04OmpWxngBpLNDWFH+iiifbIEnrAnYqOEutdejjcU= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1568913492414361.59315238651413; Thu, 19 Sep 2019 10:18:12 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iB03M-0000uw-C8; Thu, 19 Sep 2019 17:17:12 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iB03L-0000ua-8W for xen-devel@lists.xenproject.org; Thu, 19 Sep 2019 17:17:11 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 4cc3c9f4-db01-11e9-978d-bc764e2007e4; Thu, 19 Sep 2019 17:17:04 +0000 (UTC) X-Inumbo-ID: 4cc3c9f4-db01-11e9-978d-bc764e2007e4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1568913424; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=5lXH6LoQMSLoUqlZd8iS2EJBv9405IMHRGZeH3BV5dI=; b=eHxTjhDoDIS4wY37/rcBH0ioSYaNWyVKI2d6ZFfvBtg+osQvcRkHZL7l 5BHWBlObQKHHHYg32yBmV3cxzUaZJQwfhVTfnszO6bF9zqolGASp4KAS5 2P5qLX61mXfbhwPemOwPTiKW+H0BjBdInI79i/RJdV77TPhrfWy5/o2uH I=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=anthony.perard@citrix.com; spf=Pass smtp.mailfrom=anthony.perard@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: None (esa5.hc3370-68.iphmx.com: no sender authenticity information available from domain of anthony.perard@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa5.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa5.hc3370-68.iphmx.com: domain of anthony.perard@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa5.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ~all" Received-SPF: None (esa5.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa5.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: Cwu3crThgW2bcZGD4ePVaDfxsBOXl1n5/hNwPoX71Nwig6MXm0zhTkQcC3PStojCOSHvwEPhV+ N1xUXc67Qqz7w+oM1HKbP6+XuQ+g2beOklt6ZEowiswtQjexgKK1/Za0KvrES2x4SQMT8ZjmY2 Q1CEN+JNQG2hiJEf9lTyts59q5I3A9KFCnQIh98vZ0QHTeulPai3SthIHg3YqiU3iJFF5Xl8lE 9DKe3sVXm+TDBQ4NeB3t/+g9XvVmsP6qeLGyt+7BBLFQ5ilmEqw7Pg3G6fVfBG3uRI2q2YGOx6 IQI= X-SBRS: 2.7 X-MesageID: 6009422 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.64,524,1559534400"; d="scan'208";a="6009422" From: Anthony PERARD To: Date: Thu, 19 Sep 2019 18:16:25 +0100 Message-ID: <20190919171656.899649-6-anthony.perard@citrix.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190919171656.899649-1-anthony.perard@citrix.com> References: <20190919171656.899649-1-anthony.perard@citrix.com> MIME-Version: 1.0 Subject: [Xen-devel] [PATCH v2 05/35] libxl: Make libxl_qemu_monitor_command async X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Anthony PERARD , Ian Jackson , Wei Liu Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) .. because it makes QMP calls which are going to be async. Signed-off-by: Anthony PERARD Acked-by: Ian Jackson --- tools/libxl/libxl.h | 14 +++++++++++++- tools/libxl/libxl_qmp.c | 9 +++++---- tools/xl/xl_misc.c | 2 +- 3 files changed, 19 insertions(+), 6 deletions(-) diff --git a/tools/libxl/libxl.h b/tools/libxl/libxl.h index fd1e1349bf6a..ba48e7e900d3 100644 --- a/tools/libxl/libxl.h +++ b/tools/libxl/libxl.h @@ -1222,6 +1222,7 @@ void libxl_mac_copy(libxl_ctx *ctx, libxl_mac *dst, c= onst libxl_mac *src); * libxl_send_trigger() * libxl_set_vcpuonline() * libxl_retrieve_domain_configuration() + * libxl_qemu_monitor_command() */ #define LIBXL_HAVE_FN_USING_QMP_ASYNC 1 =20 @@ -2571,7 +2572,18 @@ int libxl_fd_set_nonblock(libxl_ctx *ctx, int fd, in= t nonblock); * via output. */ int libxl_qemu_monitor_command(libxl_ctx *ctx, uint32_t domid, - const char *command_line, char **output); + const char *command_line, char **output, + const libxl_asyncop_how *ao_how) + LIBXL_EXTERNAL_CALLERS_ONLY; +#if defined(LIBXL_API_VERSION) && LIBXL_API_VERSION < 0x041300 +static inline int libxl_qemu_monitor_command_0x041200(libxl_ctx *ctx, + uint32_t domid, const char *command_line, char **output) +{ + return libxl_qemu_monitor_command(ctx, domid, command_line, output, + NULL); +} +#define libxl_qemu_monitor_command libxl_qemu_monitor_command_0x041200 +#endif =20 #include =20 diff --git a/tools/libxl/libxl_qmp.c b/tools/libxl/libxl_qmp.c index 20d9eed8ddc8..505e0e5469a9 100644 --- a/tools/libxl/libxl_qmp.c +++ b/tools/libxl/libxl_qmp.c @@ -1291,15 +1291,16 @@ int libxl__qmp_hmp(libxl__gc *gc, int domid, const = char *command_line, } =20 int libxl_qemu_monitor_command(libxl_ctx *ctx, uint32_t domid, - const char *command_line, char **output) + const char *command_line, char **output, + const libxl_asyncop_how *ao_how) { - GC_INIT(ctx); + AO_CREATE(ctx, domid, ao_how); int rc; =20 rc =3D libxl__qmp_hmp(gc, domid, command_line, output); =20 - GC_FREE; - return rc; + libxl__ao_complete(egc, ao, rc); + return AO_INPROGRESS; } =20 int libxl__qmp_initializations(libxl__gc *gc, uint32_t domid, diff --git a/tools/xl/xl_misc.c b/tools/xl/xl_misc.c index 50c8436337c9..20ed605f4f44 100644 --- a/tools/xl/xl_misc.c +++ b/tools/xl/xl_misc.c @@ -228,7 +228,7 @@ int main_qemu_monitor_command(int argc, char **argv) return EXIT_FAILURE; } =20 - ret =3D libxl_qemu_monitor_command(ctx, domid, cmd, &output); + ret =3D libxl_qemu_monitor_command(ctx, domid, cmd, &output, NULL); if (!ret && output) { printf("%s\n", output); free(output); --=20 Anthony PERARD _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel