From nobody Tue Feb 10 00:58:55 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1568891161; cv=none; d=zoho.com; s=zohoarc; b=HfUM505J1Mz95hX8ZZw9tDnBfjU7C/X9e3ROCoXt5yssqIYeYvFLRwCzliRwct7h5/3Z1gSZJrDvhyCDCyHrIm6Cj/KUenLcy47+9Pu2iYk0Hc5mlgLQ9zlRxiPi+MWqEZacQ/VQ04T2omCvJlUUPi3p2wuOZV/Gb8rszA3Fvfw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1568891161; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=nTFZWiZT1LHKePyCV4ZDiutG55gaC0x+lUov12Gi2Tc=; b=Q46MEL86N6hmA+0TY1auHPg1kIWxI/RoRRQFGsDDTy1NOpAfTuIHVeTul0vR0m7nv3WSGH9CFD0AG1LuWHcHMzi5sEzQK/Tlh3745v9YZnFdfc5Ia1IL4UNtgWpNKNZ88VyrhcayjwZyFo8lh55vBZEizs1/24qxfhFhF3XRUpo= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 156889116152192.52229633970853; Thu, 19 Sep 2019 04:06:01 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iAuF8-0003Ab-6u; Thu, 19 Sep 2019 11:04:58 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iAuF7-00039q-20 for xen-devel@lists.xenproject.org; Thu, 19 Sep 2019 11:04:57 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 4ad232f4-dacd-11e9-978d-bc764e2007e4; Thu, 19 Sep 2019 11:04:47 +0000 (UTC) X-Inumbo-ID: 4ad232f4-dacd-11e9-978d-bc764e2007e4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1568891087; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=mrsRuwynkbymOCcoesCdW4GjkY00KLS1YUIo7f9zr98=; b=PS1A9cAZzFi7O/52R8m25JW/j1qzreSkutNhxu1E4v7tBMlnm/TAsd8P 9SQ80og2EI6axW3FCpEBYFzFF1zBnMeF+cF42B6hbS3suu/w6Q5gDKHGi EhzohlQXO6rvQKWXA1w58LuIRxAEN1TUZ3uDQtkGD0VmFKxo6/Vk+i8NR Q=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=anthony.perard@citrix.com; spf=Pass smtp.mailfrom=anthony.perard@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: None (esa3.hc3370-68.iphmx.com: no sender authenticity information available from domain of anthony.perard@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa3.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa3.hc3370-68.iphmx.com: domain of anthony.perard@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa3.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ~all" Received-SPF: None (esa3.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa3.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: 30G5kPlXesu8YAIC8wwTlqpgVzjqFg2OdYLE34R8OiE4El2VUV9UTarfKjbPXlUpEujqiywbNB sKUYQC0TQEmCNoy3Fq2BqI60mtwjde7txms6AyrK2l6sFAXLyva4vbDiOhwhsSPipwa5WoVi+W QWdME3A40RyrFWKKycAEDvuMw9R9QMFwPhnnY1/yA3vynUVYK4xqv1bwJhFCmzJsqz+Hw/UKop C7WDUKutjI6AkJQoqMra8rCeBBi3Ku/pIdNn+OxDvZQhs5imA8d0scoTU/2vLzuiUEedtiS/Wb ENg= X-SBRS: 2.7 X-MesageID: 5782655 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.64,523,1559534400"; d="scan'208";a="5782655" From: Anthony PERARD To: Date: Thu, 19 Sep 2019 12:04:36 +0100 Message-ID: <20190919110443.817594-3-anthony.perard@citrix.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190919110443.817594-1-anthony.perard@citrix.com> References: <20190919110443.817594-1-anthony.perard@citrix.com> MIME-Version: 1.0 Subject: [Xen-devel] [PATCH v3 2/9] libxl: Pointer on usage of libxl__domain_userdata_lock X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Anthony PERARD , Ian Jackson , Wei Liu Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) It is currently difficult to know how/when/why the userdata lock is supposed to be used. Add some pointers to the hotplug comments. Signed-off-by: Anthony PERARD Acked-by: Ian Jackson --- tools/libxl/libxl_internal.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h index a3e4b907b7c9..03e086480ca3 100644 --- a/tools/libxl/libxl_internal.h +++ b/tools/libxl/libxl_internal.h @@ -4477,6 +4477,12 @@ void libxl__unlock_domain_userdata(libxl__domain_use= rdata_lock *lock); * data store. The registry entry in libxl private data store * is "libxl-json". * Caller must hold user data lock. + * + * Other names used for this lock throughout the libxl code are json_lock, + * libxl__domain_userdata_lock, "libxl-json", data store lock. + * + * See the comment for libxl__ao_device, and "Algorithm for handling device + * removal", for information about using the libxl-json lock / json_lock. */ int libxl__get_domain_configuration(libxl__gc *gc, uint32_t domid, libxl_domain_config *d_config); --=20 Anthony PERARD _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel