From nobody Tue Nov 11 06:58:46 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1568743228; cv=none; d=zoho.com; s=zohoarc; b=PLHE+jYFIB+d1UOfncjAKyiHorR0W24dZjhdTaxb57cD8MGKyOSDL+cbFAuH+nuoIBOSth3fYXTo2oO+LmfwSeuKO97e3d47ILdsLPdBSncO2zmyoHK5yPvXDTH1KW8LmYZhz5kuB8/N9IWsepgwGTCX17B2xbK2+BZP9DvRutg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1568743228; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=p4nDn+Rk/3LqcimccGwkJEpEWOrB4Dk+u4pXDBR2Vl8=; b=Fnx8qNTme9Qi0dPHP6xWqYZLLHb9V/2pNDKBTOLpEwtZhaRLYGfj3TYWtnnVLEQqjH/ES1Cu6GyQ+g3h58N7oMBvxb5TRq3oRBMqmo//QSmz8uqYz10pHVk+Mcsen4wIbBodO/9mIsg571gNQfGP2naITqg9jjQX3qokNyIKzAE= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 156874322884830.60796297060415; Tue, 17 Sep 2019 11:00:28 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iAHke-00054o-Ve; Tue, 17 Sep 2019 17:58:56 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iAHkd-00054b-Ne for xen-devel@lists.xenproject.org; Tue, 17 Sep 2019 17:58:55 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id d028974a-d974-11e9-961c-12813bfff9fa; Tue, 17 Sep 2019 17:58:54 +0000 (UTC) X-Inumbo-ID: d028974a-d974-11e9-961c-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1568743134; h=from:to:cc:subject:date:message-id:mime-version; bh=IcYxy1OpyBK5Gicvdbqlqj4aiODvlWL2jP1gQhxyCHo=; b=aDvxGzreG9xey3OQCNlJh69ogMW2XZxDIE7bbPca+vwwMF/8I9MgJSQZ hXjOFW+50jb7q7krJCyP2i03LqDAKAXMtpwRwpL0uhc2diAqkBsMjff48 V3N/53Uou1FxUduUx4R/6Y9DVYTTqFV0d0XmS5w/2bfVRHiKVmj29g1GP 4=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=andrew.cooper3@citrix.com; spf=Pass smtp.mailfrom=Andrew.Cooper3@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: None (esa4.hc3370-68.iphmx.com: no sender authenticity information available from domain of andrew.cooper3@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa4.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="andrew.cooper3@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa4.hc3370-68.iphmx.com: domain of Andrew.Cooper3@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa4.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="Andrew.Cooper3@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ~all" Received-SPF: None (esa4.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa4.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: pKljf8HKY6w/SRoky2J90FMRd2czn4iyQHHVioZAA9EYekNh5mKpd/O6goQcH7H+uU8fqjnSpk Jy2JOZNiiRoRCLrcpAkAeQSo6W8n3WRENnq+4B5WdH7AFx7rR21OnsCSuSZ9KASQwUOhxRVunk 6LirfFUMaBuxgtkj26RF87PmbhZ1tsIddcKtmAGFbrVnPNUrXjx9KMQx3jio1xl3M+Ne4umDra JkBQ63UdXrhgeLT8QDF0obhF7Z/ZP5ihhAlon0vsoBq1TR3OitMA1cy2zKeQStGBt65YXt3DMl lhQ= X-SBRS: 2.7 X-MesageID: 5995153 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.64,517,1559534400"; d="scan'208";a="5995153" From: Andrew Cooper To: Xen-devel Date: Tue, 17 Sep 2019 18:58:50 +0100 Message-ID: <20190917175850.14940-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Subject: [Xen-devel] [PATCH] tools/libs: Fix build following c/s 56dccee3f X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , Andrew Cooper Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Travis reports: make subdirs-install make[2]: Entering directory `/home/travis/build/andyhhp/xen/tools' make[3]: Entering directory `/home/travis/build/andyhhp/xen/tools' make -C libs install make[4]: Entering directory `/home/travis/build/andyhhp/xen/tools/libs' make[5]: Entering directory `/home/travis/build/andyhhp/xen/tools/libs' make -C toolcore install make[6]: Entering directory `/home/travis/build/andyhhp/xen/tools/libs/to= olcore' make libs make[7]: Entering directory`/home/travis/build/andyhhp/xen/tools/libs/too= lcore' for i in include/xentoolcore.h include/xentoolcore_internal.h; do \ gcc -x c -ansi -Wall -Werror -I/xen/tools/libs/toolcore/../= ../../tools/include \ -S -o /dev/null $i || exit 1; \ echo $i; \ done >headers.chk.new include/xentoolcore_internal.h:30:31: fatal error: _xentoolcore_list.h: N= o such file or directory #include "_xentoolcore_list.h" ^ compilation terminated. make[7]: *** [headers.chk] Error 1 The problem is that xentoolcore_internal.h includes _xentoolcore_list.h whi= ch hasn't been generated yet. The toolcore headers.chk rule (unlike the other libraries) had an additional dependency against $(AUTOINCS), which forced the headers to be generated first. Replicate this in the common libs.mk Signed-off-by: Andrew Cooper Acked-by: Ian Jackson --- CC: Juergen Gross Ian gave his Ack IRL and I've pushed this commit to fix the build. --- tools/libs/libs.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libs/libs.mk b/tools/libs/libs.mk index b680087653..8027ae7400 100644 --- a/tools/libs/libs.mk +++ b/tools/libs/libs.mk @@ -47,7 +47,7 @@ build: .PHONY: libs libs: headers.chk $(LIB) $(PKG_CONFIG_INST) $(PKG_CONFIG_LOCAL) =20 -headers.chk: $(wildcard include/*.h) +headers.chk: $(wildcard include/*.h) $(AUTOINCS) =20 libxen$(LIBNAME).a: $(LIB_OBJS) $(AR) rc $@ $^ --=20 2.11.0 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel