From nobody Mon Feb 9 19:06:27 2026 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1568021692; cv=none; d=zoho.com; s=zohoarc; b=JxFsZ6VJAzmpbdIaNv/FgsQkIAt6FwXUgt3gnU0+ZaI0tnlQxTeA5Gfio93t5WZZRiwlE6DjShS4ypJqrQdQD+hX234MOCBbemQYwBCRzyndDpWS6jgYjpRVkVIQKY+K9+7r9eq0AEPJOD8+oTAudumbscUuH9m0orN/X8iTiSo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1568021692; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=vzFSEPwrKM2XLFlpGbfNRVQ0bagFiuV91nZVzX1xfrU=; b=OabuRJcDR3bpnoX42xcmsiL4jnVwoeb/b+Wr9WDYVeP7FxMhLoXfd6tN5x7PZ/f+GNUPCD7lWY6oAwPlhfERRNORF5OiCOz81aIwxEBsgIMF854brSgg72k8R3rGszDy0yV/rYOu7Z43PMSnPyrAwGF9O5otAchMwivMJ6NebUE= ARC-Authentication-Results: i=1; mx.zoho.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1568021692613806.1180904345804; Mon, 9 Sep 2019 02:34:52 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1i7G3S-0006Wv-S7; Mon, 09 Sep 2019 09:33:50 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1i7G3R-0006WS-CA for xen-devel@lists.xenproject.org; Mon, 09 Sep 2019 09:33:49 +0000 Received: from mx1.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e9b6a148-d2e4-11e9-ac09-12813bfff9fa; Mon, 09 Sep 2019 09:33:43 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 67521B65F; Mon, 9 Sep 2019 09:33:42 +0000 (UTC) X-Inumbo-ID: e9b6a148-d2e4-11e9-ac09-12813bfff9fa X-Virus-Scanned: by amavisd-new at test-mx.suse.de From: Juergen Gross To: xen-devel@lists.xenproject.org Date: Mon, 9 Sep 2019 11:33:39 +0200 Message-Id: <20190909093339.7134-5-jgross@suse.com> X-Mailer: git-send-email 2.16.4 In-Reply-To: <20190909093339.7134-1-jgross@suse.com> References: <20190909093339.7134-1-jgross@suse.com> Subject: [Xen-devel] [PATCH v3 4/4] xen/sched: switch to debugtrace in cpupool handling X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , Dario Faggioli MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Instead of having a cpupool_dprintk() define just use debugtrace. Signed-off-by: Juergen Gross Acked-by: Dario Faggioli --- xen/common/cpupool.c | 48 +++++++++++++++++++++++------------------------- 1 file changed, 23 insertions(+), 25 deletions(-) diff --git a/xen/common/cpupool.c b/xen/common/cpupool.c index 15e7004df4..179521e2dd 100644 --- a/xen/common/cpupool.c +++ b/xen/common/cpupool.c @@ -36,8 +36,6 @@ static DEFINE_SPINLOCK(cpupool_lock); =20 DEFINE_PER_CPU(struct cpupool *, cpupool); =20 -#define cpupool_dprintk(x...) ((void)0) - static struct cpupool *alloc_cpupool_struct(void) { struct cpupool *c =3D xzalloc(struct cpupool); @@ -133,7 +131,7 @@ static struct cpupool *cpupool_create( /* One reference for caller, one reference for cpupool_destroy(). */ atomic_set(&c->refcnt, 2); =20 - cpupool_dprintk("cpupool_create(pool=3D%d,sched=3D%u)\n", poolid, sche= d_id); + debugtrace_printk("cpupool_create(pool=3D%d,sched=3D%u)\n", poolid, sc= hed_id); =20 spin_lock(&cpupool_lock); =20 @@ -175,8 +173,8 @@ static struct cpupool *cpupool_create( =20 spin_unlock(&cpupool_lock); =20 - cpupool_dprintk("Created cpupool %d with scheduler %s (%s)\n", - c->cpupool_id, c->sched->name, c->sched->opt_name); + debugtrace_printk("Created cpupool %d with scheduler %s (%s)\n", + c->cpupool_id, c->sched->name, c->sched->opt_name); =20 *perr =3D 0; return c; @@ -212,7 +210,7 @@ static int cpupool_destroy(struct cpupool *c) =20 cpupool_put(c); =20 - cpupool_dprintk("cpupool_destroy(pool=3D%d)\n", c->cpupool_id); + debugtrace_printk("cpupool_destroy(pool=3D%d)\n", c->cpupool_id); return 0; } =20 @@ -377,14 +375,14 @@ static long cpupool_unassign_cpu_helper(void *info) struct cpupool *c =3D info; long ret; =20 - cpupool_dprintk("cpupool_unassign_cpu(pool=3D%d,cpu=3D%d)\n", - cpupool_cpu_moving->cpupool_id, cpupool_moving_cpu); + debugtrace_printk("cpupool_unassign_cpu(pool=3D%d,cpu=3D%d)\n", + cpupool_cpu_moving->cpupool_id, cpupool_moving_cpu); spin_lock(&cpupool_lock); =20 ret =3D cpupool_unassign_cpu_finish(c); =20 spin_unlock(&cpupool_lock); - cpupool_dprintk("cpupool_unassign_cpu ret=3D%ld\n", ret); + debugtrace_printk("cpupool_unassign_cpu ret=3D%ld\n", ret); =20 return ret; } @@ -406,14 +404,14 @@ static int cpupool_unassign_cpu(struct cpupool *c, un= signed int cpu) int work_cpu; int ret; =20 - cpupool_dprintk("cpupool_unassign_cpu(pool=3D%d,cpu=3D%d)\n", - c->cpupool_id, cpu); + debugtrace_printk("cpupool_unassign_cpu(pool=3D%d,cpu=3D%d)\n", + c->cpupool_id, cpu); =20 ret =3D cpupool_unassign_cpu_start(c, cpu); if ( ret ) { - cpupool_dprintk("cpupool_unassign_cpu(pool=3D%d,cpu=3D%d) ret %d\n= ", - c->cpupool_id, cpu, ret); + debugtrace_printk("cpupool_unassign_cpu(pool=3D%d,cpu=3D%d) ret %d= \n", + c->cpupool_id, cpu, ret); return ret; } =20 @@ -455,8 +453,8 @@ int cpupool_add_domain(struct domain *d, int poolid) rc =3D 0; } spin_unlock(&cpupool_lock); - cpupool_dprintk("cpupool_add_domain(dom=3D%d,pool=3D%d) n_dom %d rc %d= \n", - d->domain_id, poolid, n_dom, rc); + debugtrace_printk("cpupool_add_domain(dom=3D%d,pool=3D%d) n_dom %d rc = %d\n", + d->domain_id, poolid, n_dom, rc); return rc; } =20 @@ -476,8 +474,8 @@ void cpupool_rm_domain(struct domain *d) n_dom =3D d->cpupool->n_dom; d->cpupool =3D NULL; spin_unlock(&cpupool_lock); - cpupool_dprintk("cpupool_rm_domain(dom=3D%d,pool=3D%d) n_dom %d\n", - d->domain_id, cpupool_id, n_dom); + debugtrace_printk("cpupool_rm_domain(dom=3D%d,pool=3D%d) n_dom %d\n", + d->domain_id, cpupool_id, n_dom); return; } =20 @@ -644,8 +642,8 @@ int cpupool_do_sysctl(struct xen_sysctl_cpupool_op *op) unsigned cpu; =20 cpu =3D op->cpu; - cpupool_dprintk("cpupool_assign_cpu(pool=3D%d,cpu=3D%d)\n", - op->cpupool_id, cpu); + debugtrace_printk("cpupool_assign_cpu(pool=3D%d,cpu=3D%d)\n", + op->cpupool_id, cpu); spin_lock(&cpupool_lock); if ( cpu =3D=3D XEN_SYSCTL_CPUPOOL_PAR_ANY ) cpu =3D cpumask_first(&cpupool_free_cpus); @@ -663,8 +661,8 @@ int cpupool_do_sysctl(struct xen_sysctl_cpupool_op *op) ret =3D cpupool_assign_cpu_locked(c, cpu); addcpu_out: spin_unlock(&cpupool_lock); - cpupool_dprintk("cpupool_assign_cpu(pool=3D%d,cpu=3D%d) ret %d\n", - op->cpupool_id, cpu, ret); + debugtrace_printk("cpupool_assign_cpu(pool=3D%d,cpu=3D%d) ret %d\n= ", + op->cpupool_id, cpu, ret); } break; =20 @@ -703,8 +701,8 @@ int cpupool_do_sysctl(struct xen_sysctl_cpupool_op *op) rcu_unlock_domain(d); break; } - cpupool_dprintk("cpupool move_domain(dom=3D%d)->pool=3D%d\n", - d->domain_id, op->cpupool_id); + debugtrace_printk("cpupool move_domain(dom=3D%d)->pool=3D%d\n", + d->domain_id, op->cpupool_id); ret =3D -ENOENT; spin_lock(&cpupool_lock); =20 @@ -713,8 +711,8 @@ int cpupool_do_sysctl(struct xen_sysctl_cpupool_op *op) ret =3D cpupool_move_domain_locked(d, c); =20 spin_unlock(&cpupool_lock); - cpupool_dprintk("cpupool move_domain(dom=3D%d)->pool=3D%d ret %d\n= ", - d->domain_id, op->cpupool_id, ret); + debugtrace_printk("cpupool move_domain(dom=3D%d)->pool=3D%d ret %d= \n", + d->domain_id, op->cpupool_id, ret); rcu_unlock_domain(d); } break; --=20 2.16.4 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel