From nobody Thu Mar 28 21:44:26 2024 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1567604840; cv=none; d=zoho.com; s=zohoarc; b=B5lAwMx3aQa+secGWFn3hkzX20YIm+c1dxJOrfKk4UUZ0XNuKXN/LQNxgO0YYYZjX14Bh6tPaTkQ8cdqkwe/ZHY4U3JoGTTHHYdUguaDnS7H/5qBNBdkjwvx1JT590gmmeT70mQUaMuqhdfj/zi9s5yD0Y9ser2wcDuwbE+bzHc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1567604840; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=LSPo9E4JF6iemDqUh/gbO1fGxzMsnt40MWoCksEpmJo=; b=GDmtmU8ShpYmvPV4O9+XtVNpVj0v0pV4V+10cZiTsaa4NkPp70iz35kPcNKe/rxAGkDnA412XbMIL1TMUk87q79xAMEfFIoTnWtZeBM2WE4mPWbLK7E8CyTsvrph7Pe8qPajw0Z7eVJXDrjtb+FNEROpnT4gFmnJ0K4kJHAwY58= ARC-Authentication-Results: i=1; mx.zoho.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 15676048406001017.803862714556; Wed, 4 Sep 2019 06:47:20 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1i5Vc3-0003nR-Tc; Wed, 04 Sep 2019 13:46:19 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1i5Vc2-0003n7-Hn for xen-devel@lists.xenproject.org; Wed, 04 Sep 2019 13:46:18 +0000 Received: from mx1.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 5b2cbb38-cf1a-11e9-a337-bc764e2007e4; Wed, 04 Sep 2019 13:46:12 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 3A111AEEE; Wed, 4 Sep 2019 13:46:11 +0000 (UTC) X-Inumbo-ID: 5b2cbb38-cf1a-11e9-a337-bc764e2007e4 X-Virus-Scanned: by amavisd-new at test-mx.suse.de From: Juergen Gross To: xen-devel@lists.xenproject.org Date: Wed, 4 Sep 2019 15:46:05 +0200 Message-Id: <20190904134608.18425-2-jgross@suse.com> X-Mailer: git-send-email 2.16.4 In-Reply-To: <20190904134608.18425-1-jgross@suse.com> References: <20190904134608.18425-1-jgross@suse.com> Subject: [Xen-devel] [PATCH v4 1/4] xen: fix debugtrace clearing X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , Stefano Stabellini , Wei Liu , Konrad Rzeszutek Wilk , George Dunlap , Andrew Cooper , Ian Jackson , Tim Deegan , Julien Grall , Jan Beulich MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" After dumping the debugtrace buffer it is cleared. This results in some entries not being printed in case the buffer is dumped again before having wrapped. While at it remove the trailing zero byte in the buffer as it is no longer needed. Commit b5e6e1ee8da59f introduced passing the number of chars to be printed in the related interfaces, so the trailing 0 byte is no longer required. Signed-off-by: Juergen Gross --- xen/drivers/char/console.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c index f49c6f29a8..62477a9728 100644 --- a/xen/drivers/char/console.c +++ b/xen/drivers/char/console.c @@ -1171,6 +1171,7 @@ static volatile int debugtrace_send_to_console; =20 static char *debugtrace_buf; /* Debug-trace buffer */ static unsigned int debugtrace_prd; /* Producer index */ +static unsigned int debugtrace_prd_last; static unsigned int debugtrace_kilobytes =3D 128, debugtrace_bytes; static unsigned int debugtrace_used; static DEFINE_SPINLOCK(debugtrace_lock); @@ -1184,16 +1185,17 @@ static void debugtrace_dump_worker(void) printk("debugtrace_dump() starting\n"); =20 /* Print oldest portion of the ring. */ - ASSERT(debugtrace_buf[debugtrace_bytes - 1] =3D=3D 0); if ( debugtrace_buf[debugtrace_prd] !=3D '\0' ) console_serial_puts(&debugtrace_buf[debugtrace_prd], - debugtrace_bytes - debugtrace_prd - 1); + debugtrace_bytes - debugtrace_prd); =20 /* Print youngest portion of the ring. */ debugtrace_buf[debugtrace_prd] =3D '\0'; console_serial_puts(&debugtrace_buf[0], debugtrace_prd); =20 memset(debugtrace_buf, '\0', debugtrace_bytes); + debugtrace_prd =3D 0; + debugtrace_prd_last =3D 0; =20 printk("debugtrace_dump() finished\n"); } @@ -1241,8 +1243,7 @@ static void debugtrace_add_to_buf(char *buf) for ( p =3D buf; *p !=3D '\0'; p++ ) { debugtrace_buf[debugtrace_prd++] =3D *p; - /* Always leave a nul byte at the end of the buffer. */ - if ( debugtrace_prd =3D=3D (debugtrace_bytes - 1) ) + if ( debugtrace_prd =3D=3D debugtrace_bytes ) debugtrace_prd =3D 0; } } @@ -1250,7 +1251,7 @@ static void debugtrace_add_to_buf(char *buf) void debugtrace_printk(const char *fmt, ...) { static char buf[1024], last_buf[1024]; - static unsigned int count, last_count, last_prd; + static unsigned int count, last_count; =20 char cntbuf[24]; va_list args; @@ -1264,8 +1265,6 @@ void debugtrace_printk(const char *fmt, ...) =20 spin_lock_irqsave(&debugtrace_lock, flags); =20 - ASSERT(debugtrace_buf[debugtrace_bytes - 1] =3D=3D 0); - va_start(args, fmt); nr =3D vscnprintf(buf, sizeof(buf), fmt, args); va_end(args); @@ -1281,14 +1280,14 @@ void debugtrace_printk(const char *fmt, ...) { if ( strcmp(buf, last_buf) ) { - last_prd =3D debugtrace_prd; + debugtrace_prd_last =3D debugtrace_prd; last_count =3D ++count; safe_strcpy(last_buf, buf); snprintf(cntbuf, sizeof(cntbuf), "%u ", count); } else { - debugtrace_prd =3D last_prd; + debugtrace_prd =3D debugtrace_prd_last; snprintf(cntbuf, sizeof(cntbuf), "%u-%u ", last_count, ++count= ); } debugtrace_add_to_buf(cntbuf); --=20 2.16.4 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel From nobody Thu Mar 28 21:44:26 2024 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1567604851; cv=none; d=zoho.com; s=zohoarc; b=gwjGA+j4IfjM9faj6O2AMfBDfLvkcsWrOg+y59fcw1pW4BVxwEZdUEAtmiaMrRzN85rp4XP6IRl9dtjk0PszB48Z8SRmUdrhhbDnqbj6L1dsY2Y7w7mf21NdkV1w0pI+fsvuU4EZDhjFF251aziSHkCC+Pvn8zzwMGDvcgXRQh0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1567604851; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=r5zJspSz8tcjGeKhV+j4zl1fC1H4KBwoUn0Nl9fTcy4=; b=MAi8JF0cpCceGb/usL1J5Zh2ggj4GWVaNya/Fpl15g6RyixHk4Jyj17sOCSRI1yk0dTTAFfBbR2h4msRq54qnb564NBYdepB8wi2wuDqoC1j4fudVSeck0yKDJPnfDxDuijYSnL0lCK1EIhg8dXyOE9y3FXLdbdwSNDGLXH9f88= ARC-Authentication-Results: i=1; mx.zoho.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1567604851091342.9948946768528; Wed, 4 Sep 2019 06:47:31 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1i5Vc9-0003rM-0L; Wed, 04 Sep 2019 13:46:25 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1i5Vc7-0003qd-Hu for xen-devel@lists.xenproject.org; Wed, 04 Sep 2019 13:46:23 +0000 Received: from mx1.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 5b3b2074-cf1a-11e9-978d-bc764e2007e4; Wed, 04 Sep 2019 13:46:12 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 859FEAD5D; Wed, 4 Sep 2019 13:46:11 +0000 (UTC) X-Inumbo-ID: 5b3b2074-cf1a-11e9-978d-bc764e2007e4 X-Virus-Scanned: by amavisd-new at test-mx.suse.de From: Juergen Gross To: xen-devel@lists.xenproject.org Date: Wed, 4 Sep 2019 15:46:06 +0200 Message-Id: <20190904134608.18425-3-jgross@suse.com> X-Mailer: git-send-email 2.16.4 In-Reply-To: <20190904134608.18425-1-jgross@suse.com> References: <20190904134608.18425-1-jgross@suse.com> Subject: [Xen-devel] [PATCH v4 2/4] xen: move debugtrace coding to common/debugtrace.c X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , Stefano Stabellini , Wei Liu , Konrad Rzeszutek Wilk , George Dunlap , Andrew Cooper , Ian Jackson , Tim Deegan , Julien Grall , Jan Beulich MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Instead of living in drivers/char/console.c move the debugtrace related coding to a new file common/debugtrace.c No functional change, code movement only. Signed-off-by: Juergen Gross Acked-by: Jan Beulich --- xen/common/Makefile | 1 + xen/common/debugtrace.c | 180 +++++++++++++++++++++++++++++++++++++++++= ++++ xen/drivers/char/console.c | 177 +----------------------------------------= --- 3 files changed, 182 insertions(+), 176 deletions(-) create mode 100644 xen/common/debugtrace.c diff --git a/xen/common/Makefile b/xen/common/Makefile index eddda5daa6..62b34e69e9 100644 --- a/xen/common/Makefile +++ b/xen/common/Makefile @@ -4,6 +4,7 @@ obj-y +=3D bsearch.o obj-$(CONFIG_CORE_PARKING) +=3D core_parking.o obj-y +=3D cpu.o obj-y +=3D cpupool.o +obj-$(CONFIG_DEBUG_TRACE) +=3D debugtrace.o obj-$(CONFIG_HAS_DEVICE_TREE) +=3D device_tree.o obj-y +=3D domctl.o obj-y +=3D domain.o diff --git a/xen/common/debugtrace.c b/xen/common/debugtrace.c new file mode 100644 index 0000000000..506aee9418 --- /dev/null +++ b/xen/common/debugtrace.c @@ -0,0 +1,180 @@ +/*************************************************************************= ***** + * debugtrace.c + * + * Debugtrace for Xen + */ + + +#include +#include +#include +#include +#include +#include +#include +#include + +/* Send output direct to console, or buffer it? */ +static volatile int debugtrace_send_to_console; + +static char *debugtrace_buf; /* Debug-trace buffer */ +static unsigned int debugtrace_prd; /* Producer index */ +static unsigned int debugtrace_prd_last; +static unsigned int debugtrace_kilobytes =3D 128, debugtrace_bytes; +static unsigned int debugtrace_used; +static DEFINE_SPINLOCK(debugtrace_lock); +integer_param("debugtrace", debugtrace_kilobytes); + +static void debugtrace_dump_worker(void) +{ + if ( (debugtrace_bytes =3D=3D 0) || !debugtrace_used ) + return; + + printk("debugtrace_dump() starting\n"); + + /* Print oldest portion of the ring. */ + if ( debugtrace_buf[debugtrace_prd] !=3D '\0' ) + console_serial_puts(&debugtrace_buf[debugtrace_prd], + debugtrace_bytes - debugtrace_prd); + + /* Print youngest portion of the ring. */ + debugtrace_buf[debugtrace_prd] =3D '\0'; + console_serial_puts(&debugtrace_buf[0], debugtrace_prd); + + memset(debugtrace_buf, '\0', debugtrace_bytes); + debugtrace_prd =3D 0; + debugtrace_prd_last =3D 0; + + printk("debugtrace_dump() finished\n"); +} + +static void debugtrace_toggle(void) +{ + unsigned long flags; + + watchdog_disable(); + spin_lock_irqsave(&debugtrace_lock, flags); + + /* + * Dump the buffer *before* toggling, in case the act of dumping the + * buffer itself causes more printk() invocations. + */ + printk("debugtrace_printk now writing to %s.\n", + !debugtrace_send_to_console ? "console": "buffer"); + if ( !debugtrace_send_to_console ) + debugtrace_dump_worker(); + + debugtrace_send_to_console =3D !debugtrace_send_to_console; + + spin_unlock_irqrestore(&debugtrace_lock, flags); + watchdog_enable(); + +} + +void debugtrace_dump(void) +{ + unsigned long flags; + + watchdog_disable(); + spin_lock_irqsave(&debugtrace_lock, flags); + + debugtrace_dump_worker(); + + spin_unlock_irqrestore(&debugtrace_lock, flags); + watchdog_enable(); +} + +static void debugtrace_add_to_buf(char *buf) +{ + char *p; + + for ( p =3D buf; *p !=3D '\0'; p++ ) + { + debugtrace_buf[debugtrace_prd++] =3D *p; + if ( debugtrace_prd =3D=3D debugtrace_bytes ) + debugtrace_prd =3D 0; + } +} + +void debugtrace_printk(const char *fmt, ...) +{ + static char buf[1024], last_buf[1024]; + static unsigned int count, last_count; + + char cntbuf[24]; + va_list args; + unsigned long flags; + unsigned int nr; + + if ( debugtrace_bytes =3D=3D 0 ) + return; + + debugtrace_used =3D 1; + + spin_lock_irqsave(&debugtrace_lock, flags); + + va_start(args, fmt); + nr =3D vsnprintf(buf, sizeof(buf), fmt, args); + va_end(args); + + if ( debugtrace_send_to_console ) + { + unsigned int n =3D scnprintf(cntbuf, sizeof(cntbuf), "%u ", ++coun= t); + + console_serial_puts(cntbuf, n); + console_serial_puts(buf, nr); + } + else + { + if ( strcmp(buf, last_buf) ) + { + debugtrace_prd_last =3D debugtrace_prd; + last_count =3D ++count; + safe_strcpy(last_buf, buf); + snprintf(cntbuf, sizeof(cntbuf), "%u ", count); + } + else + { + debugtrace_prd =3D debugtrace_prd_last; + snprintf(cntbuf, sizeof(cntbuf), "%u-%u ", last_count, ++count= ); + } + debugtrace_add_to_buf(cntbuf); + debugtrace_add_to_buf(buf); + } + + spin_unlock_irqrestore(&debugtrace_lock, flags); +} + +static void debugtrace_key(unsigned char key) +{ + debugtrace_toggle(); +} + +static int __init debugtrace_init(void) +{ + int order; + unsigned int kbytes, bytes; + + /* Round size down to next power of two. */ + while ( (kbytes =3D (debugtrace_kilobytes & (debugtrace_kilobytes-1)))= !=3D 0 ) + debugtrace_kilobytes =3D kbytes; + + bytes =3D debugtrace_kilobytes << 10; + if ( bytes =3D=3D 0 ) + return 0; + + order =3D get_order_from_bytes(bytes); + debugtrace_buf =3D alloc_xenheap_pages(order, 0); + ASSERT(debugtrace_buf !=3D NULL); + + memset(debugtrace_buf, '\0', bytes); + + debugtrace_bytes =3D bytes; + + register_keyhandler('T', debugtrace_key, + "toggle debugtrace to console/buffer", 0); + + return 0; +} +__initcall(debugtrace_init); + diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c index 62477a9728..7f29190eaf 100644 --- a/xen/drivers/char/console.c +++ b/xen/drivers/char/console.c @@ -1160,182 +1160,7 @@ int printk_ratelimit(void) =20 /* * ************************************************************** - * *************** Serial console ring buffer ******************* - * ************************************************************** - */ - -#ifdef CONFIG_DEBUG_TRACE - -/* Send output direct to console, or buffer it? */ -static volatile int debugtrace_send_to_console; - -static char *debugtrace_buf; /* Debug-trace buffer */ -static unsigned int debugtrace_prd; /* Producer index */ -static unsigned int debugtrace_prd_last; -static unsigned int debugtrace_kilobytes =3D 128, debugtrace_bytes; -static unsigned int debugtrace_used; -static DEFINE_SPINLOCK(debugtrace_lock); -integer_param("debugtrace", debugtrace_kilobytes); - -static void debugtrace_dump_worker(void) -{ - if ( (debugtrace_bytes =3D=3D 0) || !debugtrace_used ) - return; - - printk("debugtrace_dump() starting\n"); - - /* Print oldest portion of the ring. */ - if ( debugtrace_buf[debugtrace_prd] !=3D '\0' ) - console_serial_puts(&debugtrace_buf[debugtrace_prd], - debugtrace_bytes - debugtrace_prd); - - /* Print youngest portion of the ring. */ - debugtrace_buf[debugtrace_prd] =3D '\0'; - console_serial_puts(&debugtrace_buf[0], debugtrace_prd); - - memset(debugtrace_buf, '\0', debugtrace_bytes); - debugtrace_prd =3D 0; - debugtrace_prd_last =3D 0; - - printk("debugtrace_dump() finished\n"); -} - -static void debugtrace_toggle(void) -{ - unsigned long flags; - - watchdog_disable(); - spin_lock_irqsave(&debugtrace_lock, flags); - - /* - * Dump the buffer *before* toggling, in case the act of dumping the - * buffer itself causes more printk() invocations. - */ - printk("debugtrace_printk now writing to %s.\n", - !debugtrace_send_to_console ? "console": "buffer"); - if ( !debugtrace_send_to_console ) - debugtrace_dump_worker(); - - debugtrace_send_to_console =3D !debugtrace_send_to_console; - - spin_unlock_irqrestore(&debugtrace_lock, flags); - watchdog_enable(); - -} - -void debugtrace_dump(void) -{ - unsigned long flags; - - watchdog_disable(); - spin_lock_irqsave(&debugtrace_lock, flags); - - debugtrace_dump_worker(); - - spin_unlock_irqrestore(&debugtrace_lock, flags); - watchdog_enable(); -} - -static void debugtrace_add_to_buf(char *buf) -{ - char *p; - - for ( p =3D buf; *p !=3D '\0'; p++ ) - { - debugtrace_buf[debugtrace_prd++] =3D *p; - if ( debugtrace_prd =3D=3D debugtrace_bytes ) - debugtrace_prd =3D 0; - } -} - -void debugtrace_printk(const char *fmt, ...) -{ - static char buf[1024], last_buf[1024]; - static unsigned int count, last_count; - - char cntbuf[24]; - va_list args; - unsigned long flags; - unsigned int nr; - - if ( debugtrace_bytes =3D=3D 0 ) - return; - - debugtrace_used =3D 1; - - spin_lock_irqsave(&debugtrace_lock, flags); - - va_start(args, fmt); - nr =3D vscnprintf(buf, sizeof(buf), fmt, args); - va_end(args); - - if ( debugtrace_send_to_console ) - { - unsigned int n =3D scnprintf(cntbuf, sizeof(cntbuf), "%u ", ++coun= t); - - console_serial_puts(cntbuf, n); - console_serial_puts(buf, nr); - } - else - { - if ( strcmp(buf, last_buf) ) - { - debugtrace_prd_last =3D debugtrace_prd; - last_count =3D ++count; - safe_strcpy(last_buf, buf); - snprintf(cntbuf, sizeof(cntbuf), "%u ", count); - } - else - { - debugtrace_prd =3D debugtrace_prd_last; - snprintf(cntbuf, sizeof(cntbuf), "%u-%u ", last_count, ++count= ); - } - debugtrace_add_to_buf(cntbuf); - debugtrace_add_to_buf(buf); - } - - spin_unlock_irqrestore(&debugtrace_lock, flags); -} - -static void debugtrace_key(unsigned char key) -{ - debugtrace_toggle(); -} - -static int __init debugtrace_init(void) -{ - int order; - unsigned int kbytes, bytes; - - /* Round size down to next power of two. */ - while ( (kbytes =3D (debugtrace_kilobytes & (debugtrace_kilobytes-1)))= !=3D 0 ) - debugtrace_kilobytes =3D kbytes; - - bytes =3D debugtrace_kilobytes << 10; - if ( bytes =3D=3D 0 ) - return 0; - - order =3D get_order_from_bytes(bytes); - debugtrace_buf =3D alloc_xenheap_pages(order, 0); - ASSERT(debugtrace_buf !=3D NULL); - - memset(debugtrace_buf, '\0', bytes); - - debugtrace_bytes =3D bytes; - - register_keyhandler('T', debugtrace_key, - "toggle debugtrace to console/buffer", 0); - - return 0; -} -__initcall(debugtrace_init); - -#endif /* !CONFIG_DEBUG_TRACE */ - - -/* - * ************************************************************** - * *************** Debugging/tracing/error-report *************** + * ********************** Error-report ************************** * ************************************************************** */ =20 --=20 2.16.4 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel From nobody Thu Mar 28 21:44:26 2024 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1567604840; cv=none; d=zoho.com; s=zohoarc; b=Q8/9H1Fqa0yZwHO7hgsQ2xyrJ0tGL5JEuGkCwGLPaJckMG48sVwFDd4Q1IopnSaeWqJzYbcN/J8ufc/fIYui1UNYnpLpEf11JBlmXVrl99dOEGW0Y0iLmP8Zz8P8lfnUiwQgcq31RbeAHjm/ZbKalxFOUpxEilKEbpWWD6jHwzE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1567604840; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=ejj43W73NdIl8zCSW55Di0fJUW/7662vrx+azO0qU3Y=; b=X//aUeaqucmGcQg6rq9GXrwrINgSsU7rIUl6DgIBEfEmSDVOWK8xEN/joSo9TPaKIRa4WpCucoB0C3OU/qfl6xSNoOVFFW8huhArAy3p3zb49LtkHKBvTCs7IkxQj92J4Xo7j9o6qqJPnNZDesmq8uKjcOLA+OywL0D53gm1vJo= ARC-Authentication-Results: i=1; mx.zoho.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1567604840525964.9008181300559; Wed, 4 Sep 2019 06:47:20 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1i5Vbz-0003mT-6u; Wed, 04 Sep 2019 13:46:15 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1i5Vbx-0003m9-Mt for xen-devel@lists.xenproject.org; Wed, 04 Sep 2019 13:46:13 +0000 Received: from mx1.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 5b664722-cf1a-11e9-abb6-12813bfff9fa; Wed, 04 Sep 2019 13:46:12 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id C802AAF25; Wed, 4 Sep 2019 13:46:11 +0000 (UTC) X-Inumbo-ID: 5b664722-cf1a-11e9-abb6-12813bfff9fa X-Virus-Scanned: by amavisd-new at test-mx.suse.de From: Juergen Gross To: xen-devel@lists.xenproject.org Date: Wed, 4 Sep 2019 15:46:07 +0200 Message-Id: <20190904134608.18425-4-jgross@suse.com> X-Mailer: git-send-email 2.16.4 In-Reply-To: <20190904134608.18425-1-jgross@suse.com> References: <20190904134608.18425-1-jgross@suse.com> Subject: [Xen-devel] [PATCH v4 3/4] xen: refactor debugtrace data X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , Stefano Stabellini , Wei Liu , Konrad Rzeszutek Wilk , George Dunlap , Andrew Cooper , Ian Jackson , Tim Deegan , Julien Grall , Jan Beulich MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" As a preparation for per-cpu buffers do a little refactoring of the debugtrace data: put the needed buffer admin data into the buffer as it will be needed for each buffer. While at it switch debugtrace_send_to_console and debugtrace_used to bool and delete an empty line. Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich --- V4: - renamed struct debugtrace_data_s (Jan Beulich) - renamed debtr_data (Jan Beulich) - remove unneeded condition (Jan Beulich) - recalc debugtrace_bytes (Jan Beulich) --- xen/common/debugtrace.c | 65 ++++++++++++++++++++++++++++-----------------= ---- 1 file changed, 37 insertions(+), 28 deletions(-) diff --git a/xen/common/debugtrace.c b/xen/common/debugtrace.c index 506aee9418..8fa0e7fb0e 100644 --- a/xen/common/debugtrace.c +++ b/xen/common/debugtrace.c @@ -15,35 +15,41 @@ #include =20 /* Send output direct to console, or buffer it? */ -static volatile int debugtrace_send_to_console; +static volatile bool debugtrace_send_to_console; =20 -static char *debugtrace_buf; /* Debug-trace buffer */ -static unsigned int debugtrace_prd; /* Producer index */ -static unsigned int debugtrace_prd_last; -static unsigned int debugtrace_kilobytes =3D 128, debugtrace_bytes; -static unsigned int debugtrace_used; +struct debugtrace_data { + unsigned long bytes; /* Size of buffer. */ + unsigned long prd; /* Producer index. */ + unsigned long prd_last; + char buf[]; +}; + +static struct debugtrace_data *dt_data; + +static unsigned int debugtrace_kilobytes =3D 128; +static bool debugtrace_used; static DEFINE_SPINLOCK(debugtrace_lock); integer_param("debugtrace", debugtrace_kilobytes); =20 static void debugtrace_dump_worker(void) { - if ( (debugtrace_bytes =3D=3D 0) || !debugtrace_used ) + if ( !debugtrace_used ) return; =20 printk("debugtrace_dump() starting\n"); =20 /* Print oldest portion of the ring. */ - if ( debugtrace_buf[debugtrace_prd] !=3D '\0' ) - console_serial_puts(&debugtrace_buf[debugtrace_prd], - debugtrace_bytes - debugtrace_prd); + if ( dt_data->buf[dt_data->prd] !=3D '\0' ) + console_serial_puts(&dt_data->buf[dt_data->prd], + dt_data->bytes - dt_data->prd); =20 /* Print youngest portion of the ring. */ - debugtrace_buf[debugtrace_prd] =3D '\0'; - console_serial_puts(&debugtrace_buf[0], debugtrace_prd); + dt_data->buf[dt_data->prd] =3D '\0'; + console_serial_puts(&dt_data->buf[0], dt_data->prd); =20 - memset(debugtrace_buf, '\0', debugtrace_bytes); - debugtrace_prd =3D 0; - debugtrace_prd_last =3D 0; + memset(dt_data->buf, '\0', dt_data->bytes); + dt_data->prd =3D 0; + dt_data->prd_last =3D 0; =20 printk("debugtrace_dump() finished\n"); } @@ -68,7 +74,6 @@ static void debugtrace_toggle(void) =20 spin_unlock_irqrestore(&debugtrace_lock, flags); watchdog_enable(); - } =20 void debugtrace_dump(void) @@ -90,9 +95,9 @@ static void debugtrace_add_to_buf(char *buf) =20 for ( p =3D buf; *p !=3D '\0'; p++ ) { - debugtrace_buf[debugtrace_prd++] =3D *p; - if ( debugtrace_prd =3D=3D debugtrace_bytes ) - debugtrace_prd =3D 0; + dt_data->buf[dt_data->prd++] =3D *p; + if ( dt_data->prd =3D=3D dt_data->bytes ) + dt_data->prd =3D 0; } } =20 @@ -106,10 +111,10 @@ void debugtrace_printk(const char *fmt, ...) unsigned long flags; unsigned int nr; =20 - if ( debugtrace_bytes =3D=3D 0 ) + if ( !dt_data ) return; =20 - debugtrace_used =3D 1; + debugtrace_used =3D true; =20 spin_lock_irqsave(&debugtrace_lock, flags); =20 @@ -128,14 +133,14 @@ void debugtrace_printk(const char *fmt, ...) { if ( strcmp(buf, last_buf) ) { - debugtrace_prd_last =3D debugtrace_prd; + dt_data->prd_last =3D dt_data->prd; last_count =3D ++count; safe_strcpy(last_buf, buf); snprintf(cntbuf, sizeof(cntbuf), "%u ", count); } else { - debugtrace_prd =3D debugtrace_prd_last; + dt_data->prd =3D dt_data->prd_last; snprintf(cntbuf, sizeof(cntbuf), "%u-%u ", last_count, ++count= ); } debugtrace_add_to_buf(cntbuf); @@ -153,7 +158,8 @@ static void debugtrace_key(unsigned char key) static int __init debugtrace_init(void) { int order; - unsigned int kbytes, bytes; + unsigned long kbytes, bytes; + struct debugtrace_data *data; =20 /* Round size down to next power of two. */ while ( (kbytes =3D (debugtrace_kilobytes & (debugtrace_kilobytes-1)))= !=3D 0 ) @@ -164,12 +170,15 @@ static int __init debugtrace_init(void) return 0; =20 order =3D get_order_from_bytes(bytes); - debugtrace_buf =3D alloc_xenheap_pages(order, 0); - ASSERT(debugtrace_buf !=3D NULL); + data =3D alloc_xenheap_pages(order, 0); + if ( !data ) + return -ENOMEM; =20 - memset(debugtrace_buf, '\0', bytes); + bytes =3D PAGE_SIZE << order; + memset(data, '\0', bytes); =20 - debugtrace_bytes =3D bytes; + data->bytes =3D bytes - sizeof(*data); + dt_data =3D data; =20 register_keyhandler('T', debugtrace_key, "toggle debugtrace to console/buffer", 0); --=20 2.16.4 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel From nobody Thu Mar 28 21:44:26 2024 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1567604841; cv=none; d=zoho.com; s=zohoarc; b=QIsKF1fXRPDNQ11+d3WFDoFSotXJ1p/HsfbmGvgfTQfItOY3+3dEbGe3JLPl29ioYMhIFpasTsjU1/yFcYP2ik+2Imbrwg7F1BFtRO2dQ9/GEIodtwRvHXGD1Dp5xQ+ggpf5Ac9iMzuxeDsbMJRbAg2WPK5E+3xb3YxWzQwVv78= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1567604841; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=uLNVnRzBqOr3rShFjqdY0FIT+t++EBbVSVeD9/Qls2A=; b=hjMEvJio0JvXahzL/oFmnk2dB1MK34vCyMFWZ5zYro55/JYAydMnPzbwUfoQSG57KQcYSdjPbiJ370GYQmIOdWuzRGv99zyMDP+Z5LE4+vivAMPH81eU6rb/WQruRn6aM7zRnmDm40T5nFVwYXlLXlYzArcKr4Sf/GNzZz8U83k= ARC-Authentication-Results: i=1; mx.zoho.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1567604841717698.1149156613448; Wed, 4 Sep 2019 06:47:21 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1i5Vc4-0003no-7i; Wed, 04 Sep 2019 13:46:20 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1i5Vc2-0003n8-Je for xen-devel@lists.xenproject.org; Wed, 04 Sep 2019 13:46:18 +0000 Received: from mx1.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 5b95284e-cf1a-11e9-abb6-12813bfff9fa; Wed, 04 Sep 2019 13:46:12 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 25A9DAD7B; Wed, 4 Sep 2019 13:46:12 +0000 (UTC) X-Inumbo-ID: 5b95284e-cf1a-11e9-abb6-12813bfff9fa X-Virus-Scanned: by amavisd-new at test-mx.suse.de From: Juergen Gross To: xen-devel@lists.xenproject.org Date: Wed, 4 Sep 2019 15:46:08 +0200 Message-Id: <20190904134608.18425-5-jgross@suse.com> X-Mailer: git-send-email 2.16.4 In-Reply-To: <20190904134608.18425-1-jgross@suse.com> References: <20190904134608.18425-1-jgross@suse.com> Subject: [Xen-devel] [PATCH v4 4/4] xen: add per-cpu buffer option to debugtrace X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , Stefano Stabellini , Wei Liu , Konrad Rzeszutek Wilk , George Dunlap , Andrew Cooper , Ian Jackson , Tim Deegan , Julien Grall , Jan Beulich MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" debugtrace is normally writing trace entries into a single trace buffer. There are cases where this is not optimal, e.g. when hunting a bug which requires writing lots of trace entries and one cpu is stuck. This will result in other cpus filling the trace buffer and finally overwriting the interesting trace entries of the hanging cpu. In order to be able to debug such situations add the capability to use per-cpu trace buffers. This can be selected by specifying the debugtrace boot parameter with the modifier "cpu:", like: debugtrace=3Dcpu:16 At the same time switch the parsing function to accept size modifiers (e.g. 4M or 1G). Printing out the trace entries is done for each buffer in order to minimize the effort needed during printing. As each entry is prefixed with its sequence number sorting the entries can easily be done when analyzing them. Signed-off-by: Juergen Gross --- V2: - only allocate buffer if not already done so V4: - unsigned int -> unsigned long (Jan Beulich) - replace check for bytes < PAGE_SIZE by !bytes (Jan Beulich) - print info which buffer allocation failed (Jan Beulich) - replace switch by if in cpu notifier handler (Jan Beulich) --- docs/misc/xen-command-line.pandoc | 7 +- xen/common/debugtrace.c | 149 ++++++++++++++++++++++++++++------= ---- 2 files changed, 116 insertions(+), 40 deletions(-) diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line= .pandoc index 7c72e31032..832797e2e2 100644 --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -644,12 +644,13 @@ over the PCI busses sequentially) or by PCI device (m= ust be on segment 0). Limits the number lines printed in Xen stack traces. =20 ### debugtrace -> `=3D ` +> `=3D [cpu:]` =20 > Default: `128` =20 -Specify the size of the console debug trace buffer in KiB. The debug -trace feature is only enabled in debugging builds of Xen. +Specify the size of the console debug trace buffer. By specifying `cpu:` +additionally a trace buffer of the specified size is allocated per cpu. +The debug trace feature is only enabled in debugging builds of Xen. =20 ### dma_bits > `=3D ` diff --git a/xen/common/debugtrace.c b/xen/common/debugtrace.c index 8fa0e7fb0e..449406b9b6 100644 --- a/xen/common/debugtrace.c +++ b/xen/common/debugtrace.c @@ -6,6 +6,7 @@ =20 =20 #include +#include #include #include #include @@ -25,33 +26,63 @@ struct debugtrace_data { }; =20 static struct debugtrace_data *dt_data; +static DEFINE_PER_CPU(struct debugtrace_data *, dt_cpu_data); =20 -static unsigned int debugtrace_kilobytes =3D 128; +static unsigned long debugtrace_bytes =3D 128 << 10; +static bool debugtrace_per_cpu; static bool debugtrace_used; static DEFINE_SPINLOCK(debugtrace_lock); -integer_param("debugtrace", debugtrace_kilobytes); =20 -static void debugtrace_dump_worker(void) +static int __init debugtrace_parse_param(const char *s) { - if ( !debugtrace_used ) + if ( !strncmp(s, "cpu:", 4) ) + { + debugtrace_per_cpu =3D true; + s +=3D 4; + } + debugtrace_bytes =3D parse_size_and_unit(s, NULL); + return 0; +} +custom_param("debugtrace", debugtrace_parse_param); + +static void debugtrace_dump_buffer(struct debugtrace_data *data, + const char *which) +{ + if ( !data ) return; =20 - printk("debugtrace_dump() starting\n"); + printk("debugtrace_dump() %s buffer starting\n", which); =20 /* Print oldest portion of the ring. */ - if ( dt_data->buf[dt_data->prd] !=3D '\0' ) - console_serial_puts(&dt_data->buf[dt_data->prd], - dt_data->bytes - dt_data->prd); + if ( data->buf[data->prd] !=3D '\0' ) + console_serial_puts(&data->buf[data->prd], data->bytes - data->prd= ); =20 /* Print youngest portion of the ring. */ - dt_data->buf[dt_data->prd] =3D '\0'; - console_serial_puts(&dt_data->buf[0], dt_data->prd); + data->buf[data->prd] =3D '\0'; + console_serial_puts(&data->buf[0], data->prd); =20 - memset(dt_data->buf, '\0', dt_data->bytes); - dt_data->prd =3D 0; - dt_data->prd_last =3D 0; + memset(data->buf, '\0', data->bytes); + data->prd =3D 0; + data->prd_last =3D 0; =20 - printk("debugtrace_dump() finished\n"); + printk("debugtrace_dump() %s buffer finished\n", which); +} + +static void debugtrace_dump_worker(void) +{ + unsigned int cpu; + char buf[16]; + + if ( !debugtrace_used ) + return; + + debugtrace_dump_buffer(dt_data, "global"); + + for ( cpu =3D 0; cpu < nr_cpu_ids; cpu++ ) + { + snprintf(buf, sizeof(buf), "cpu %u", cpu); + debugtrace_dump_buffer(per_cpu(dt_cpu_data, cpu), buf); + } } =20 static void debugtrace_toggle(void) @@ -91,27 +122,34 @@ void debugtrace_dump(void) =20 static void debugtrace_add_to_buf(char *buf) { + struct debugtrace_data *data; char *p; =20 + data =3D debugtrace_per_cpu ? this_cpu(dt_cpu_data) : dt_data; + for ( p =3D buf; *p !=3D '\0'; p++ ) { - dt_data->buf[dt_data->prd++] =3D *p; - if ( dt_data->prd =3D=3D dt_data->bytes ) - dt_data->prd =3D 0; + data->buf[data->prd++] =3D *p; + if ( data->prd =3D=3D data->bytes ) + data->prd =3D 0; } } =20 void debugtrace_printk(const char *fmt, ...) { static char buf[1024], last_buf[1024]; - static unsigned int count, last_count; + static unsigned int count, last_count, last_cpu; =20 char cntbuf[24]; va_list args; unsigned long flags; unsigned int nr; + struct debugtrace_data *data; + unsigned int cpu; =20 - if ( !dt_data ) + data =3D debugtrace_per_cpu ? this_cpu(dt_cpu_data) : dt_data; + cpu =3D debugtrace_per_cpu ? smp_processor_id() : 0; + if ( !data ) return; =20 debugtrace_used =3D true; @@ -131,16 +169,17 @@ void debugtrace_printk(const char *fmt, ...) } else { - if ( strcmp(buf, last_buf) ) + if ( strcmp(buf, last_buf) || cpu !=3D last_cpu ) { - dt_data->prd_last =3D dt_data->prd; + data->prd_last =3D data->prd; last_count =3D ++count; + last_cpu =3D cpu; safe_strcpy(last_buf, buf); snprintf(cntbuf, sizeof(cntbuf), "%u ", count); } else { - dt_data->prd =3D dt_data->prd_last; + data->prd =3D data->prd_last; snprintf(cntbuf, sizeof(cntbuf), "%u-%u ", last_count, ++count= ); } debugtrace_add_to_buf(cntbuf); @@ -155,34 +194,70 @@ static void debugtrace_key(unsigned char key) debugtrace_toggle(); } =20 -static int __init debugtrace_init(void) +static void debugtrace_alloc_buffer(struct debugtrace_data **ptr, + unsigned int cpu) { int order; - unsigned long kbytes, bytes; struct debugtrace_data *data; =20 - /* Round size down to next power of two. */ - while ( (kbytes =3D (debugtrace_kilobytes & (debugtrace_kilobytes-1)))= !=3D 0 ) - debugtrace_kilobytes =3D kbytes; - - bytes =3D debugtrace_kilobytes << 10; - if ( bytes =3D=3D 0 ) - return 0; + if ( !debugtrace_bytes || *ptr ) + return; =20 - order =3D get_order_from_bytes(bytes); + order =3D get_order_from_bytes(debugtrace_bytes); data =3D alloc_xenheap_pages(order, 0); if ( !data ) - return -ENOMEM; + { + if ( debugtrace_per_cpu ) + printk("failed to allocate debugtrace buffer for cpu %u\n", cp= u); + else + printk("failed to allocate debugtrace buffer\n"); + return; + } =20 - bytes =3D PAGE_SIZE << order; - memset(data, '\0', bytes); + debugtrace_bytes =3D PAGE_SIZE << order; + memset(data, '\0', debugtrace_bytes); + data->bytes =3D debugtrace_bytes - sizeof(*data); =20 - data->bytes =3D bytes - sizeof(*data); - dt_data =3D data; + *ptr =3D data; +} + +static int debugtrace_cpu_callback(struct notifier_block *nfb, + unsigned long action, void *hcpu) +{ + unsigned int cpu =3D (unsigned long)hcpu; + + /* Buffers are only ever allocated, never freed. */ + if ( action =3D=3D CPU_UP_PREPARE ) + debugtrace_alloc_buffer(&per_cpu(dt_cpu_data, cpu), cpu); + + return 0; +} + +static struct notifier_block debugtrace_nfb =3D { + .notifier_call =3D debugtrace_cpu_callback +}; + +static int __init debugtrace_init(void) +{ + unsigned long bytes; + unsigned int cpu; + + /* Round size down to next power of two. */ + while ( (bytes =3D (debugtrace_bytes & (debugtrace_bytes - 1))) !=3D 0= ) + debugtrace_bytes =3D bytes; =20 register_keyhandler('T', debugtrace_key, "toggle debugtrace to console/buffer", 0); =20 + if ( debugtrace_per_cpu ) + { + for_each_online_cpu ( cpu ) + debugtrace_alloc_buffer(&per_cpu(dt_cpu_data, cpu), cpu); + register_cpu_notifier(&debugtrace_nfb); + } + else + debugtrace_alloc_buffer(&dt_data, 0); + return 0; } __initcall(debugtrace_init); --=20 2.16.4 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel