livepatch-build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
... rather than leaving the user with no hint as to where to debug next.
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
CC: Ross Lagerwall <ross.lagerwall@citrix.com>
---
livepatch-build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/livepatch-build b/livepatch-build
index 7068faf..b198c97 100755
--- a/livepatch-build
+++ b/livepatch-build
@@ -140,7 +140,7 @@ function create_patch()
die "no core file found, run 'ulimit -c unlimited' and try to recreate"
fi
# create-diff-object returns 3 if no functional change is found
- [[ $rc -eq 0 ]] || [[ $rc -eq 3 ]] || ERROR=$(expr $ERROR "+" 1)
+ [[ $rc -eq 0 ]] || [[ $rc -eq 3 ]] || { ERROR=$(expr $ERROR "+" 1); warn "create-diff-object $i rc $rc"; }
if [[ $rc -eq 0 ]]; then
CHANGED=1
fi
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
On August 27, 2019 11:38:39 AM EDT, Andrew Cooper <andrew.cooper3@citrix.com> wrote: >... rather than leaving the user with no hint as to where to debug >next. > >Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> >--- >CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> >CC: Ross Lagerwall <ross.lagerwall@citrix.com> >--- > livepatch-build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/livepatch-build b/livepatch-build >index 7068faf..b198c97 100755 >--- a/livepatch-build >+++ b/livepatch-build >@@ -140,7 +140,7 @@ function create_patch() >die "no core file found, run 'ulimit -c unlimited' and try to recreate" > fi > # create-diff-object returns 3 if no functional change is found >- [[ $rc -eq 0 ]] || [[ $rc -eq 3 ]] || ERROR=$(expr $ERROR "+" >1) >+ [[ $rc -eq 0 ]] || [[ $rc -eq 3 ]] || { ERROR=$(expr $ERROR >"+" 1); warn "create-diff-object $i rc $rc"; } > if [[ $rc -eq 0 ]]; then > CHANGED=1 > fi _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
On 08/27/2019 04:38 PM, Andrew Cooper wrote: > ... rather than leaving the user with no hint as to where to debug next. > > Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> > --- > CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> > CC: Ross Lagerwall <ross.lagerwall@citrix.com> Reviewed-by: Ross Lagerwall <ross.lagerwall@citrix.com> Thanks _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
© 2016 - 2024 Red Hat, Inc.