From nobody Sun May 5 13:37:39 2024 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1566237760; cv=none; d=zoho.com; s=zohoarc; b=Qr/YNUKVm9oM2o2oIoXzzNklGPETzhGnJU2vzGyFIMARrDVUkaT+AT6YhqZducqjYGsGAll0mNmRljUlKW7pKI9MrEkmoLZaXpRwVqp9MjT7B4p0vLiL0q/wI1748K6Dpq77rKyucu5uE5KQvPW+nMQWzbW8HHCXTqcP1ceWpJ0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1566237760; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=i3aUsOGqSVUV6u1eXQZLxvjMeWkj/XYVfoVOKhk7l7s=; b=YB58O19tfRX+vSRAyvn5Y+SuYXN95VSSnXxyhFKEpPqf/ugH3nWvvQHL5uJwFjuhyl93Kd6qy4u6rc6ODlmuJTZ3yfEzVlMu6TI+IDZyo3bM0qPgQMx0PWGvGByqC6EinFvuFfmO3jUuFjEMXxaFQkIsadr+sHG/tTiGtAiKLD0= ARC-Authentication-Results: i=1; mx.zoho.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1566237759993921.5788943676337; Mon, 19 Aug 2019 11:02:39 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hzlyG-0001ps-Hk; Mon, 19 Aug 2019 18:01:32 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hzlyF-0001ph-8P for xen-devel@lists.xenproject.org; Mon, 19 Aug 2019 18:01:31 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id 5ee20440-c2ab-11e9-8bf0-12813bfff9fa; Mon, 19 Aug 2019 18:01:30 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3B759360; Mon, 19 Aug 2019 11:01:30 -0700 (PDT) Received: from e108454-lin.cambridge.arm.com (e108454-lin.cambridge.arm.com [10.1.196.50]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DAB6D3F246; Mon, 19 Aug 2019 11:01:28 -0700 (PDT) X-Inumbo-ID: 5ee20440-c2ab-11e9-8bf0-12813bfff9fa From: Julien Grall To: xen-devel@lists.xenproject.org Date: Mon, 19 Aug 2019 19:01:25 +0100 Message-Id: <20190819180125.17504-1-julien.grall@arm.com> X-Mailer: git-send-email 2.11.0 Subject: [Xen-devel] [PATCH] xen/console: Fix build when CONFIG_DEBUG_TRACE=y X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Wei Liu , Konrad Rzeszutek Wilk , George Dunlap , Andrew Cooper , Ian Jackson , Tim Deegan , Julien Grall , Jan Beulich MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Commit b5e6e1ee8da "xen/console: Don't treat NUL character as the end of the buffer" extended sercon_puts to take the number of character to print in argument. Sadly, a couple of couple of the callers in debugtrace_dump_worker() were not converted. This result to a build failure when enabling CONFIG_DEBUG_TRACE. Spotted by Travis using randconfig Signed-off-by: Julien Grall --- xen/drivers/char/console.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c index 2c14c2ca73..924d4971ca 100644 --- a/xen/drivers/char/console.c +++ b/xen/drivers/char/console.c @@ -1185,11 +1185,12 @@ static void debugtrace_dump_worker(void) =20 /* Print oldest portion of the ring. */ ASSERT(debugtrace_buf[debugtrace_bytes - 1] =3D=3D 0); - sercon_puts(&debugtrace_buf[debugtrace_prd]); + sercon_puts(&debugtrace_buf[debugtrace_prd], + strlen(&debugtrace_buf[debugtrace_prd])); =20 /* Print youngest portion of the ring. */ debugtrace_buf[debugtrace_prd] =3D '\0'; - sercon_puts(&debugtrace_buf[0]); + sercon_puts(&debugtrace_buf[0], debugtrace_prd); =20 memset(debugtrace_buf, '\0', debugtrace_bytes); =20 --=20 2.11.0 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel