From nobody Fri May 3 22:50:12 2024 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1565898759; cv=none; d=zoho.com; s=zohoarc; b=HzZFElPx57Z3MTtxMqEXhXiM8UHGmB8ojXo6K/6LaAjiczDbr4xXnDxXCODWO6z0X9bxCYZpos0jzUm3CM76GMsAdOien3dAl+25EHmz0meDoh5Q7iu0Davxhl+HL9CSx1+PIte09Ek0xuCh7kHnpNiiRHz6otQ5aJ4ziaV07oI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1565898759; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=mQdUvx5gJgTNLstjT+D9NZa8lvRWXgEAlwdJfeAEzm8=; b=RJ8eXBqGrbX3Af2jxyRhhjY0RBYp5CHCvd7UwQJgaJCzpga+1dTr7GfaCW+cAdp3MrTKTwkW4XtmNTM7L/a5xwpoRTzXPNRFExfIntubtOvpZQq0IVw3ytRF3Iy4Yo4qMvBVY4VceNgMvC25darzz5R2+9AsWAnUu8Hb1WA6UoM= ARC-Authentication-Results: i=1; mx.zoho.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1565898759239493.5525998052914; Thu, 15 Aug 2019 12:52:39 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hyLmL-0003Hi-Q0; Thu, 15 Aug 2019 19:51:21 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hyLmK-0003Hd-GW for xen-devel@lists.xenproject.org; Thu, 15 Aug 2019 19:51:20 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id 0cdedb7a-bf96-11e9-aee9-bc764e2007e4; Thu, 15 Aug 2019 19:51:19 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 24118344; Thu, 15 Aug 2019 12:51:19 -0700 (PDT) Received: from e108454-lin.cambridge.arm.com (e108454-lin.cambridge.arm.com [10.1.196.50]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 664763F694; Thu, 15 Aug 2019 12:51:18 -0700 (PDT) X-Inumbo-ID: 0cdedb7a-bf96-11e9-aee9-bc764e2007e4 From: Julien Grall To: xen-devel@lists.xenproject.org Date: Thu, 15 Aug 2019 20:51:14 +0100 Message-Id: <20190815195114.31148-1-julien.grall@arm.com> X-Mailer: git-send-email 2.11.0 Subject: [Xen-devel] [PATCH] xen/arm: domain_build: Remove redundant check in make_vpl011_uart_node() X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Julien Grall , Stefano Stabellini , Volodymyr Babchuk MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" None of the code since the last check of res modify the value. So the check can be removed. Coverity-ID: 1476824 Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini --- xen/arch/arm/domain_build.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index cf9ffbc360..173544d8c5 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -1629,8 +1629,7 @@ static int __init make_vpl011_uart_node(const struct = domain *d, void *fdt) dt_child_set_range(&cells, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS, GUEST_PL011_BASE, GUEST_PL011_SIZE); - if ( res ) - return res; + res =3D fdt_property(fdt, "reg", reg, sizeof(reg)); if ( res ) return res; --=20 2.11.0 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel