From nobody Thu May 9 00:57:25 2024 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1564158833; cv=none; d=zoho.com; s=zohoarc; b=ldl1ibIYxnmBUfb7ebeoeBowIe6nDzlMDYOEGtwWFS70Ee40qQQA74oAM+0QClvhBAjLJRzMG4rY9kmE7E8NFPBfHdwb4V+CVIbbFkYETiZKF56+ELZ+vZnWEi+WioB2cPZrV4JIGyOJKITX7u1vq8AMQPlimEf+fIiLBlhxqMc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1564158833; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=kPWBgDujGC012X6eLh5sGGNUNt7BEdeETr3us6vEgmg=; b=RNT82TrGzmAyN8P7JfrqHO+T0ep8ax8HAO9p2gdgVoz01/puODw8ETTBx809RV4kDNCJp3eHiXrt4QFfaAyA6Q4yS2iBcM6NgVbh7jHuNF3V69p1zpdeCVeqwBxNUH12HLGDmOxaBzCuB13nCbW29TRsDHHV2Tq3Rtrh8LwsnBk= ARC-Authentication-Results: i=1; mx.zoho.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 15641588338364.2132481530796895; Fri, 26 Jul 2019 09:33:53 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hr399-0007dR-7O; Fri, 26 Jul 2019 16:32:43 +0000 Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hr397-0007dL-Lq for xen-devel@lists.xenproject.org; Fri, 26 Jul 2019 16:32:41 +0000 Received: from mga03.intel.com (unknown [134.134.136.65]) by us1-rack-dfw2.inumbo.com (Halon) with ESMTPS id fbcccc48-afc2-11e9-8980-bc764e045a96; Fri, 26 Jul 2019 16:32:39 +0000 (UTC) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jul 2019 09:32:39 -0700 Received: from unknown (HELO localhost.localdomain) ([10.239.13.19]) by fmsmga002.fm.intel.com with ESMTP; 26 Jul 2019 09:32:37 -0700 X-Inumbo-ID: fbcccc48-afc2-11e9-8980-bc764e045a96 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,311,1559545200"; d="scan'208";a="198421323" From: Zhang Chen To: Ian Jackson , Wei Liu , Anthony PERARD , xen-devel@lists.xenproject.org Date: Sat, 27 Jul 2019 00:27:23 +0800 Message-Id: <20190726162723.7443-1-chen.zhang@intel.com> X-Mailer: git-send-email 2.17.GIT Subject: [Xen-devel] [PATCH V4] tools/libxl: Add iothread support for COLO X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Zhang Chen , Zhang Chen MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Zhang Chen Xen COLO and KVM COLO shared lots of code in Qemu. The colo-compare object in Qemu now requires an 'iothread' property since Q= EMU 2.11. Detail: https://wiki.qemu.org/Features/COLO Signed-off-by: Zhang Chen Reviewed-by: Anthony PERARD --- tools/libxl/libxl_dm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c index f4fc96415d..839c5ac2cd 100644 --- a/tools/libxl/libxl_dm.c +++ b/tools/libxl/libxl_dm.c @@ -1634,8 +1634,10 @@ static int libxl__build_device_model_args_new(libxl_= _gc *gc, nics[i].colo_compare_out && nics[i].colo_compare_notify_dev) { flexarray_append(dm_args, "-object"); + flexarray_append(dm_args, "iothread,id=3Dcolo-comp= are-iothread-1"); + flexarray_append(dm_args, "-object"); flexarray_append(dm_args, - GCSPRINTF("colo-compare,id=3Dc1,primary_in=3D%s= ,secondary_in=3D%s,outdev=3D%s,notify_dev=3D%s", + GCSPRINTF("colo-compare,id=3Dc1,primary_in=3D%s= ,secondary_in=3D%s,outdev=3D%s,notify_dev=3D%s,iothread=3Dcolo-compare-ioth= read-1", nics[i].colo_compare_pri_in, nics[i].colo_compare_sec_in, nics[i].colo_compare_out, --=20 2.17.GIT _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel