From nobody Wed May 8 10:15:29 2024 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1564123796; cv=none; d=zoho.com; s=zohoarc; b=V7QX76MuF5sTfPHT6Ht+/sOl3Ji+7zlsnSGQGT7vZu1b4QflinqRetdy8KJ/tWvjq4wTqcXv3WDWm018RU89S0fPqJbUD4qFODNyDc0LNg1XAC134wiJUfCZsqRZBBYpi2l3OoESqHiMZQ6PcVWTO5/p/r0Vr2ZYi38y5NV4Pms= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1564123796; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=JB6+8vEeK0pFhwkXjApNXcmf1qvcugw4FCQHl6PEYpk=; b=QzAaircPjr+H+rz5sBhqg/VvQFR7A5XvhY11hnzA1jbezjkXzfwBVQYiezsmkn2v634wj0mgmkn+ukaKJhzq6v5/dVZEV3PeunthMWOKHhAHDDgN9YL38J539ms4hi9h16KvJp3EpL9ekbLp9QrBLNWLMPSvXBWHvaUnpY2kpvg= ARC-Authentication-Results: i=1; mx.zoho.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1564123796235561.1541254523908; Thu, 25 Jul 2019 23:49:56 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hqu1p-0004tj-6l; Fri, 26 Jul 2019 06:48:33 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hqu1n-0004te-Nr for xen-devel@lists.xenproject.org; Fri, 26 Jul 2019 06:48:31 +0000 Received: from mga11.intel.com (unknown [192.55.52.93]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 60645d5e-af71-11e9-808a-dbaa9afa509b; Fri, 26 Jul 2019 06:48:30 +0000 (UTC) Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Jul 2019 23:48:28 -0700 Received: from unknown (HELO localhost.localdomain) ([10.239.13.19]) by orsmga006.jf.intel.com with ESMTP; 25 Jul 2019 23:48:27 -0700 X-Inumbo-ID: 60645d5e-af71-11e9-808a-dbaa9afa509b X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,309,1559545200"; d="scan'208";a="175510243" From: Zhang Chen To: Ian Jackson , Wei Liu , Anthony PERARD , xen-devel@lists.xenproject.org Date: Fri, 26 Jul 2019 14:43:00 +0800 Message-Id: <20190726064300.27530-1-chen.zhang@intel.com> X-Mailer: git-send-email 2.17.GIT Subject: [Xen-devel] [PATCH V2] tools/libxl: Add iothread support for COLO X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Zhang Chen , Zhang Chen MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Zhang Chen Xen COLO and KVM COLO shared lots of code in Qemu. KVM COLO has added the iothread support, so we add it on Xen. Detail: https://wiki.qemu.org/Features/COLO Signed-off-by: Zhang Chen --- tools/libxl/libxl_dm.c | 14 +++++++++++--- tools/libxl/libxl_types.idl | 1 + tools/xl/xl_parse.c | 2 ++ 3 files changed, 14 insertions(+), 3 deletions(-) diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c index f4fc96415d..95cb30f9e6 100644 --- a/tools/libxl/libxl_dm.c +++ b/tools/libxl/libxl_dm.c @@ -1629,17 +1629,25 @@ static int libxl__build_device_model_args_new(libxl= __gc *gc, nics[i].colo_filter_redirector1_queue, nics[i].colo_filter_redirector1_outde= v)); } + if (nics[i].colo_iothread) { + flexarray_append(dm_args, "-object"); + flexarray_append(dm_args, + GCSPRINTF("iothread,id=3D%s", + nics[i].colo_iothread)); + } if (nics[i].colo_compare_pri_in && nics[i].colo_compare_sec_in && nics[i].colo_compare_out && - nics[i].colo_compare_notify_dev) { + nics[i].colo_compare_notify_dev && + nics[i].colo_iothread) { flexarray_append(dm_args, "-object"); flexarray_append(dm_args, - GCSPRINTF("colo-compare,id=3Dc1,primary_in=3D%s= ,secondary_in=3D%s,outdev=3D%s,notify_dev=3D%s", + GCSPRINTF("colo-compare,id=3Dc1,primary_in=3D%s= ,secondary_in=3D%s,outdev=3D%s,notify_dev=3D%s,iothread=3D%s", nics[i].colo_compare_pri_in, nics[i].colo_compare_sec_in, nics[i].colo_compare_out, - nics[i].colo_compare_notify_dev)); + nics[i].colo_compare_notify_dev, + nics[i].colo_iothread)); } } ioemu_nics++; diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl index b61399ce36..eda958eb4b 100644 --- a/tools/libxl/libxl_types.idl +++ b/tools/libxl/libxl_types.idl @@ -727,6 +727,7 @@ libxl_device_nic =3D Struct("device_nic", [ ("colo_filter_redirector1_queue", string), ("colo_filter_redirector1_indev", string), ("colo_filter_redirector1_outdev", string), + ("colo_iothread", string), ("colo_compare_pri_in", string), ("colo_compare_sec_in", string), ("colo_compare_out", string), diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c index e105bda2bb..0b8189f375 100644 --- a/tools/xl/xl_parse.c +++ b/tools/xl/xl_parse.c @@ -521,6 +521,8 @@ int parse_nic_config(libxl_device_nic *nic, XLU_Config = **config, char *token) replace_string(&nic->colo_filter_redirector1_indev, oparg); } else if (MATCH_OPTION("colo_filter_redirector1_outdev", token, oparg= )) { replace_string(&nic->colo_filter_redirector1_outdev, oparg); + } else if (MATCH_OPTION("colo_iothread", token, oparg)) { + replace_string(&nic->colo_iothread, oparg); } else if (MATCH_OPTION("colo_compare_pri_in", token, oparg)) { replace_string(&nic->colo_compare_pri_in, oparg); } else if (MATCH_OPTION("colo_compare_sec_in", token, oparg)) { --=20 2.17.GIT _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel