From nobody Tue May 7 20:19:08 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1563990271; cv=none; d=zoho.com; s=zohoarc; b=PWF+yCmxDCxtkAqrW4Jj7MkrR1U3jHofrSQWJmSduIPpDCZcPiLrwCidsZzs10h5mADDE2dEYr830N4+FobHryElB/hvtmUbJWAfKAuBXnB4COGXBpG18p+jCwLZjCLvUEi19wl6b+gHNHZwHkgqg51iJynEQujXWMuQvVgr/cA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1563990271; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=rYlzQM42nNrMpQ4e5ErbkU4aByJwDlDETphuWOOuE8M=; b=K0zlKuMu1JppQN73xL/pHVuWWrdxjYp7/fgCx9bXSn5JnB8VhnGZHiVkz9r+XSyl+/hWMNdoiLI7CAjhKjKvJKAOLytRhNq1bnyk0cAvjC1jiu796CiztElRg+3CwTcmzbWw2p1LNjWB/Xtr5Nb4Z5Zpu+2FcpESLWOTZ9TwtFs= ARC-Authentication-Results: i=1; mx.zoho.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1563990271607240.86142243736924; Wed, 24 Jul 2019 10:44:31 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hqLIH-0007ly-O2; Wed, 24 Jul 2019 17:43:13 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hqLIG-0007lP-Ag for xen-devel@lists.xenproject.org; Wed, 24 Jul 2019 17:43:12 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 7f6a1348-ae3a-11e9-982c-a73c5ac53a78; Wed, 24 Jul 2019 17:43:08 +0000 (UTC) X-Inumbo-ID: 7f6a1348-ae3a-11e9-982c-a73c5ac53a78 Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=andrew.cooper3@citrix.com; spf=Pass smtp.mailfrom=Andrew.Cooper3@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of andrew.cooper3@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="andrew.cooper3@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa2.hc3370-68.iphmx.com: domain of Andrew.Cooper3@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="Andrew.Cooper3@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ~all" Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: v7Ms+EyEfea2oxGN5QbO6fjXG7JdIH1aLDupw5c5rDLgxk6csQfyixPsIvxJSBwVosh6iyHINj MXNlvIh6sv9v4m+bg+9nIvbs5ymCR2gP61V3mGptQJzxhKofL4VlDreulwHGdTcB9d4P11aCHd IQUHPmC7nI4XvILjDj+sUppG+dhQoTXhvchH3Egog7XLXI1f/kX7dWG0nU72GrkwVl8MTTjy+M 4CGpmsM2+SLvJyDLRArsCv8bIo0W6VHCvQDp3fW/HHchzFlclPn6nkxaPExuzUBgznByrcIr0J UGo= X-SBRS: 2.7 X-MesageID: 3383300 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.64,303,1559534400"; d="scan'208";a="3383300" From: Andrew Cooper To: Xen-devel Date: Wed, 24 Jul 2019 18:42:54 +0100 Message-ID: <20190724174256.5295-2-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190724174256.5295-1-andrew.cooper3@citrix.com> References: <20190724174256.5295-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Subject: [Xen-devel] [PATCH 1/3] x86: Drop CONFIG_ACPI_SLEEP X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Wei Liu , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" This option is hardcoded to 1, and the #ifdef-ary doesn't exclude wakeup.S, which makes it useless code noise. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich --- CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monn=C3=A9 An alternative would be to wire it into Kconfig properly and properly exclu= de wakeup.S, but that is more complicated than I have time for. Thoughts? --- xen/arch/x86/acpi/boot.c | 4 ---- xen/arch/x86/dmi_scan.c | 7 ++----- xen/include/asm-x86/acpi.h | 4 ---- xen/include/asm-x86/config.h | 1 - 4 files changed, 2 insertions(+), 14 deletions(-) diff --git a/xen/arch/x86/acpi/boot.c b/xen/arch/x86/acpi/boot.c index 1382b4dcd0..15542a9bdf 100644 --- a/xen/arch/x86/acpi/boot.c +++ b/xen/arch/x86/acpi/boot.c @@ -332,7 +332,6 @@ static int __init acpi_invalidate_bgrt(struct acpi_tabl= e_header *table) return 0; } =20 -#ifdef CONFIG_ACPI_SLEEP #define acpi_fadt_copy_address(dst, src, len) do { \ if (fadt->header.revision >=3D FADT2_REVISION_ID && \ fadt->header.length >=3D ACPI_FADT_V2_SIZE) \ @@ -457,7 +456,6 @@ acpi_fadt_parse_sleep_info(struct acpi_table_fadt *fadt) memset(&acpi_sinfo.sleep_status + 1, 0, (long)(&acpi_sinfo + 1) - (long)(&acpi_sinfo.sleep_status + 1)); } -#endif =20 static int __init acpi_parse_fadt(struct acpi_table_header *table) { @@ -501,9 +499,7 @@ static int __init acpi_parse_fadt(struct acpi_table_hea= der *table) acpi_enable_value =3D fadt->acpi_enable; acpi_disable_value =3D fadt->acpi_disable; =20 -#ifdef CONFIG_ACPI_SLEEP acpi_fadt_parse_sleep_info(fadt); -#endif =20 return 0; } diff --git a/xen/arch/x86/dmi_scan.c b/xen/arch/x86/dmi_scan.c index 31caad133e..7063c2c799 100644 --- a/xen/arch/x86/dmi_scan.c +++ b/xen/arch/x86/dmi_scan.c @@ -488,14 +488,12 @@ static int __init ich10_bios_quirk(struct dmi_system_= id *d) return 0; } =20 -#ifdef CONFIG_ACPI_SLEEP static __init int reset_videomode_after_s3(struct dmi_blacklist *d) { - /* See acpi_wakeup.S */ + /* See wakeup.S */ acpi_video_flags |=3D 2; return 0; } -#endif =20 static __init int dmi_disable_acpi(struct dmi_blacklist *d)=20 {=20 @@ -541,12 +539,11 @@ static __initdata struct dmi_blacklist dmi_blacklist[= ]=3D{ MATCH(DMI_PRODUCT_NAME, "S4030CDT/4.3"), NO_MATCH, NO_MATCH, NO_MATCH } }, -#ifdef CONFIG_ACPI_SLEEP + { reset_videomode_after_s3, "Toshiba Satellite 4030cdt", { /* Reset video= mode after returning from ACPI S3 sleep */ MATCH(DMI_PRODUCT_NAME, "S4030CDT/4.3"), NO_MATCH, NO_MATCH, NO_MATCH } }, -#endif =20 { ich10_bios_quirk, "Intel board & BIOS", /* diff --git a/xen/include/asm-x86/acpi.h b/xen/include/asm-x86/acpi.h index a105d1186c..7032f3a001 100644 --- a/xen/include/asm-x86/acpi.h +++ b/xen/include/asm-x86/acpi.h @@ -105,8 +105,6 @@ extern s8 acpi_numa; extern int acpi_scan_nodes(u64 start, u64 end); #define NR_NODE_MEMBLKS (MAX_NUMNODES*2) =20 -#ifdef CONFIG_ACPI_SLEEP - extern struct acpi_sleep_info acpi_sinfo; #define acpi_video_flags bootsym(video_flags) struct xenpf_enter_acpi_sleep; @@ -134,8 +132,6 @@ struct acpi_sleep_info { bool_t sleep_extended; }; =20 -#endif /* CONFIG_ACPI_SLEEP */ - #define MAX_MADT_ENTRIES MAX(256, 2 * NR_CPUS) extern u32 x86_acpiid_to_apicid[]; #define MAX_LOCAL_APIC MAX(256, 4 * NR_CPUS) diff --git a/xen/include/asm-x86/config.h b/xen/include/asm-x86/config.h index 9ef9d03ca7..6e4f28d934 100644 --- a/xen/include/asm-x86/config.h +++ b/xen/include/asm-x86/config.h @@ -34,7 +34,6 @@ /* Intel P4 currently has largest cache line (L2 line size is 128 bytes). = */ #define CONFIG_X86_L1_CACHE_SHIFT 7 =20 -#define CONFIG_ACPI_SLEEP 1 #define CONFIG_ACPI_NUMA 1 #define CONFIG_ACPI_SRAT 1 #define CONFIG_ACPI_CSTATE 1 --=20 2.11.0 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel From nobody Tue May 7 20:19:08 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1563990266; cv=none; d=zoho.com; s=zohoarc; b=MBQJYXQ/5WI/XHN02Svixe37fGLZX3MJ4IHuMLprprEpFWs8fyDYgEVFfVWKU2bcLDpbakyGCA8ygkWe7L4K8whDluZlqacxHw2vUMo9STAZd0rGB225evr4cgsA62eI/v2/AU/Hkcr+HN0iUHICRe/+e+RoPrB1x1dMjJG+FZg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1563990266; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=mKTzRu8/qRWMciBBCDqp7zGZina+i45dBTBUiVA4yqc=; b=QEBKrZp/L8nh4IJto5F44MOECNeIb9ElQ0UfleLjB1/snfC3izUHbc2kx6VXVjL4oQ9Zd5nW8MHG2DWN9dJg2GERl+mtlOI0YUVgKMO4afsaSGqyi/fMnRDv3MCWTRseiYFKGxMkyafxtdBE7mLetHnCoSR2OnF/TfWCiWI/qrA= ARC-Authentication-Results: i=1; mx.zoho.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1563990266605591.0245953440954; Wed, 24 Jul 2019 10:44:26 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hqLIF-0007kX-9i; Wed, 24 Jul 2019 17:43:11 +0000 Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hqLID-0007jt-UK for xen-devel@lists.xenproject.org; Wed, 24 Jul 2019 17:43:09 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-rack-dfw2.inumbo.com (Halon) with ESMTPS id 7fd5dcd2-ae3a-11e9-8980-bc764e045a96; Wed, 24 Jul 2019 17:43:09 +0000 (UTC) X-Inumbo-ID: 7fd5dcd2-ae3a-11e9-8980-bc764e045a96 Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=andrew.cooper3@citrix.com; spf=Pass smtp.mailfrom=Andrew.Cooper3@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: None (esa4.hc3370-68.iphmx.com: no sender authenticity information available from domain of andrew.cooper3@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa4.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="andrew.cooper3@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa4.hc3370-68.iphmx.com: domain of Andrew.Cooper3@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa4.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="Andrew.Cooper3@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ~all" Received-SPF: None (esa4.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa4.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: 9zN1ffo3l/mw6vzOgEN4J1vYMsbwjRiFdBFDLGfrJHQaXtPvm29/RqESSeQVAozmiDzY5/lJ2A HJcQrhAQtdQ8cxiyTw1Yviqod5RFdAnwgSxqW6fxLl585i1ytBg7NG67ny5uyqvuWMbxWtW/qt vg39uXkiuLg5aGZwKT/3qIjuVpFnSJHn0boty8hajf+a7TH4Gi4g9gF57y1LCHe9I0BOgpCmmN 2qz5XTAM3Q//moRGY/aORZ8gT6PMczmtz7t38K6lm4kuP9cSrDP2K8Q5VP04LVHwbJP2+4yH7F Kus= X-SBRS: 2.7 X-MesageID: 3510257 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.64,303,1559534400"; d="scan'208";a="3510257" From: Andrew Cooper To: Xen-devel Date: Wed, 24 Jul 2019 18:42:55 +0100 Message-ID: <20190724174256.5295-3-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190724174256.5295-1-andrew.cooper3@citrix.com> References: <20190724174256.5295-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Subject: [Xen-devel] [PATCH 2/3] x86/dmi: Drop trivial callback functions X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Wei Liu , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" dmi_check_system() returns the number of matches. This being nonzero is mo= re efficient than calling into a trivial function to modify a variable. No functional change, but this results in less compiled code, which is also (fractionally) quicker to run. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich --- CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monn=C3=A9 --- xen/arch/x86/ioport_emulate.c | 18 +++--------------- xen/arch/x86/x86_64/mmconf-fam10h.c | 10 ++-------- 2 files changed, 5 insertions(+), 23 deletions(-) diff --git a/xen/arch/x86/ioport_emulate.c b/xen/arch/x86/ioport_emulate.c index c2aded7668..504bc513e2 100644 --- a/xen/arch/x86/ioport_emulate.c +++ b/xen/arch/x86/ioport_emulate.c @@ -33,12 +33,6 @@ static bool ioemul_handle_proliant_quirk( return true; } =20 -static int __init proliant_quirk(struct dmi_system_id *d) -{ - ioemul_handle_quirk =3D ioemul_handle_proliant_quirk; - return 0; -} - /* This table is the set of system-specific I/O emulation hooks. */ static struct dmi_system_id __initdata ioport_quirks_tbl[] =3D { /* @@ -46,7 +40,6 @@ static struct dmi_system_id __initdata ioport_quirks_tbl[= ] =3D { * 'special' SMM goodness. */ { - .callback =3D proliant_quirk, .ident =3D "HP ProLiant DL3xx", .matches =3D { DMI_MATCH(DMI_BIOS_VENDOR, "HP"), @@ -54,7 +47,6 @@ static struct dmi_system_id __initdata ioport_quirks_tbl[= ] =3D { }, }, { - .callback =3D proliant_quirk, .ident =3D "HP ProLiant DL5xx", .matches =3D { DMI_MATCH(DMI_BIOS_VENDOR, "HP"), @@ -62,7 +54,6 @@ static struct dmi_system_id __initdata ioport_quirks_tbl[= ] =3D { }, }, { - .callback =3D proliant_quirk, .ident =3D "HP ProLiant DL7xx", .matches =3D { DMI_MATCH(DMI_BIOS_VENDOR, "HP"), @@ -70,7 +61,6 @@ static struct dmi_system_id __initdata ioport_quirks_tbl[= ] =3D { }, }, { - .callback =3D proliant_quirk, .ident =3D "HP ProLiant ML3xx", .matches =3D { DMI_MATCH(DMI_BIOS_VENDOR, "HP"), @@ -78,7 +68,6 @@ static struct dmi_system_id __initdata ioport_quirks_tbl[= ] =3D { }, }, { - .callback =3D proliant_quirk, .ident =3D "HP ProLiant ML5xx", .matches =3D { DMI_MATCH(DMI_BIOS_VENDOR, "HP"), @@ -86,7 +75,6 @@ static struct dmi_system_id __initdata ioport_quirks_tbl[= ] =3D { }, }, { - .callback =3D proliant_quirk, .ident =3D "HP ProLiant BL2xx", .matches =3D { DMI_MATCH(DMI_BIOS_VENDOR, "HP"), @@ -94,7 +82,6 @@ static struct dmi_system_id __initdata ioport_quirks_tbl[= ] =3D { }, }, { - .callback =3D proliant_quirk, .ident =3D "HP ProLiant BL4xx", .matches =3D { DMI_MATCH(DMI_BIOS_VENDOR, "HP"), @@ -102,7 +89,6 @@ static struct dmi_system_id __initdata ioport_quirks_tbl= [] =3D { }, }, { - .callback =3D proliant_quirk, .ident =3D "HP ProLiant BL6xx", .matches =3D { DMI_MATCH(DMI_BIOS_VENDOR, "HP"), @@ -114,7 +100,9 @@ static struct dmi_system_id __initdata ioport_quirks_tb= l[] =3D { =20 static int __init ioport_quirks_init(void) { - dmi_check_system(ioport_quirks_tbl); + if ( dmi_check_system(ioport_quirks_tbl) ) + ioemul_handle_quirk =3D ioemul_handle_proliant_quirk; + return 0; } __initcall(ioport_quirks_init); diff --git a/xen/arch/x86/x86_64/mmconf-fam10h.c b/xen/arch/x86/x86_64/mmco= nf-fam10h.c index f997688ad4..fa2f5b4881 100644 --- a/xen/arch/x86/x86_64/mmconf-fam10h.c +++ b/xen/arch/x86/x86_64/mmconf-fam10h.c @@ -185,15 +185,8 @@ void fam10h_check_enable_mmcfg(void) wrmsrl(MSR_FAM10H_MMIO_CONF_BASE, val); } =20 -static int __init set_check_enable_amd_mmconf(struct dmi_system_id *d) -{ - pci_probe |=3D PCI_CHECK_ENABLE_AMD_MMCONF; - return 0; -} - static struct dmi_system_id __initdata mmconf_dmi_table[] =3D { { - .callback =3D set_check_enable_amd_mmconf, .ident =3D "Sun Microsystems Machine", .matches =3D { DMI_MATCH(DMI_SYS_VENDOR, "Sun Microsystems"), @@ -204,5 +197,6 @@ static struct dmi_system_id __initdata mmconf_dmi_table= [] =3D { =20 void __init check_enable_amd_mmconf_dmi(void) { - dmi_check_system(mmconf_dmi_table); + if (dmi_check_system(mmconf_dmi_table)) + pci_probe |=3D PCI_CHECK_ENABLE_AMD_MMCONF; } --=20 2.11.0 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel From nobody Tue May 7 20:19:08 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1563990261; cv=none; d=zoho.com; s=zohoarc; b=Plx/p55TZpWCr1yQsjD7NMmiu6Mx1vwrP7EpmCwIhDy4LslWVdsVqdGxHhwf81DSktECvmp2oQ0nqV9LcD06aLUG6KvXd7XZFI144NTf+DnabE+WpDjGuo5ehOpgQN9rZNWGB2xe0UdRuf6KLXbBgxWHfx8AflILx8+d+Pk4nXA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1563990261; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=n/OJyGe4G5RAA8BBmByYTjVmYuxtUiOxkjHEzEjRrWk=; b=iH5kXlwXV8oIMEIUhaZvTzxiia0Q+P3BqJmW9f3BXSCdojfcxtNvNlbrmVXiFpzTzyiTg19s+BlW9SBGA87kOGbPugf8DNy5EvNzO7B34XOu2TaWCcMl65JcXUawdrytVpdqbbOBp8kBhuh0hfw9F58tGT7/zIFJh6oEs2R6eIs= ARC-Authentication-Results: i=1; mx.zoho.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1563990261892315.99001077316257; Wed, 24 Jul 2019 10:44:21 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hqLIE-0007jv-1K; Wed, 24 Jul 2019 17:43:10 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hqLID-0007jf-1R for xen-devel@lists.xenproject.org; Wed, 24 Jul 2019 17:43:09 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 7d820db0-ae3a-11e9-a97c-53c606eea54a; Wed, 24 Jul 2019 17:43:05 +0000 (UTC) X-Inumbo-ID: 7d820db0-ae3a-11e9-a97c-53c606eea54a Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=andrew.cooper3@citrix.com; spf=Pass smtp.mailfrom=Andrew.Cooper3@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: None (esa3.hc3370-68.iphmx.com: no sender authenticity information available from domain of andrew.cooper3@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa3.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="andrew.cooper3@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa3.hc3370-68.iphmx.com: domain of Andrew.Cooper3@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa3.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="Andrew.Cooper3@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ~all" Received-SPF: None (esa3.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa3.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: Z7r6putUKzAQFE0ZPcdflW8v8uurE2p6y/VjR5c6doNar6bYBdS0W52IjAkkLwLvJaa0c8Abx4 LUyXeqYlkRd8OOv+i35XKZhRXEF3Cp5kQaBK50TfkmHFAA9qfesew8wMnHCpyNh3PgBEB1nlU0 7mYiC1pjDTir5qzUa4b7XHKWSl5EILjShHv1MyBvtiqqNlKoziHWwnXP6sClX5HzuuxglmRCYa oYK/tuSCyx08TNV5kYXE0+0j8Utbf2N/kpKdc1lHq2wD5Bvyd3oNGddoeYRi6xvcdjh5CvpmnA WXs= X-SBRS: 2.7 X-MesageID: 3400782 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.64,303,1559534400"; d="scan'208";a="3400782" From: Andrew Cooper To: Xen-devel Date: Wed, 24 Jul 2019 18:42:56 +0100 Message-ID: <20190724174256.5295-4-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190724174256.5295-1-andrew.cooper3@citrix.com> References: <20190724174256.5295-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Subject: [Xen-devel] [PATCH 3/3] x86/dmi: Constify quirks data X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Wei Liu , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" All DMI quirks tables are mutable, but are only ever read. Update dmi_check_system() and dmi_system_id.callback to pass a const pointe= r, and move all quirks tables into __initconst. No functional change. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich --- CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monn=C3=A9 --- xen/arch/x86/dmi_scan.c | 16 ++++++++-------- xen/arch/x86/genapic/bigsmp.c | 4 ++-- xen/arch/x86/hvm/quirks.c | 4 ++-- xen/arch/x86/ioport_emulate.c | 2 +- xen/arch/x86/shutdown.c | 4 ++-- xen/arch/x86/x86_64/mmconf-fam10h.c | 2 +- xen/include/xen/dmi.h | 4 ++-- 7 files changed, 18 insertions(+), 18 deletions(-) diff --git a/xen/arch/x86/dmi_scan.c b/xen/arch/x86/dmi_scan.c index 7063c2c799..808fa7f10e 100644 --- a/xen/arch/x86/dmi_scan.c +++ b/xen/arch/x86/dmi_scan.c @@ -459,13 +459,13 @@ static void __init dmi_save_ident(struct dmi_header *= dm, int slot, int string) * Toshiba keyboard likes to repeat keys when they are not repeated. */ =20 -static __init int broken_toshiba_keyboard(struct dmi_blacklist *d) +static __init int broken_toshiba_keyboard(const struct dmi_blacklist *d) { printk(KERN_WARNING "Toshiba with broken keyboard detected. If your keybo= ard sometimes generates 3 keypresses instead of one, see http://davyd.ucc.a= sn.au/projects/toshiba/README\n"); return 0; } =20 -static int __init ich10_bios_quirk(struct dmi_system_id *d) +static int __init ich10_bios_quirk(const struct dmi_system_id *d) { u32 port, smictl; =20 @@ -488,14 +488,14 @@ static int __init ich10_bios_quirk(struct dmi_system_= id *d) return 0; } =20 -static __init int reset_videomode_after_s3(struct dmi_blacklist *d) +static __init int reset_videomode_after_s3(const struct dmi_blacklist *d) { /* See wakeup.S */ acpi_video_flags |=3D 2; return 0; } =20 -static __init int dmi_disable_acpi(struct dmi_blacklist *d)=20 +static __init int dmi_disable_acpi(const struct dmi_blacklist *d) {=20 if (!acpi_force) {=20 printk(KERN_NOTICE "%s detected: acpi off\n",d->ident); @@ -510,7 +510,7 @@ static __init int dmi_disable_acpi(struct dmi_blacklist= *d) /* * Limit ACPI to CPU enumeration for HT */ -static __init int force_acpi_ht(struct dmi_blacklist *d)=20 +static __init int force_acpi_ht(const struct dmi_blacklist *d) {=20 if (!acpi_force) {=20 printk(KERN_NOTICE "%s detected: force use of acpi=3Dht\n", d->ident); @@ -533,7 +533,7 @@ static __init int force_acpi_ht(struct dmi_blacklist *d) * interrupt mask settings according to the laptop */ =20 -static __initdata struct dmi_blacklist dmi_blacklist[]=3D{ +static const struct dmi_blacklist __initconst dmi_blacklist[]=3D{ =20 { broken_toshiba_keyboard, "Toshiba Satellite 4030cdt", { /* Keyboard gen= erates spurious repeats */ MATCH(DMI_PRODUCT_NAME, "S4030CDT/4.3"), @@ -708,10 +708,10 @@ void __init dmi_scan_machine(void) * returns non zero or we hit the end. Callback function is called for * each successfull match. Returns the number of matches. */ -int __init dmi_check_system(struct dmi_system_id *list) +int __init dmi_check_system(const struct dmi_system_id *list) { int i, count =3D 0; - struct dmi_system_id *d =3D list; + const struct dmi_system_id *d =3D list; =20 while (d->ident) { for (i =3D 0; i < ARRAY_SIZE(d->matches); i++) { diff --git a/xen/arch/x86/genapic/bigsmp.c b/xen/arch/x86/genapic/bigsmp.c index 91a973ac16..2ed1cb8f49 100644 --- a/xen/arch/x86/genapic/bigsmp.c +++ b/xen/arch/x86/genapic/bigsmp.c @@ -11,7 +11,7 @@ #include #include =20 -static __init int force_bigsmp(struct dmi_system_id *d) +static __init int force_bigsmp(const struct dmi_system_id *d) { printk(KERN_NOTICE "%s detected: force use of apic=3Dbigsmp\n", d->ident); def_to_bigsmp =3D true; @@ -19,7 +19,7 @@ static __init int force_bigsmp(struct dmi_system_id *d) } =20 =20 -static struct dmi_system_id __initdata bigsmp_dmi_table[] =3D { +static const struct dmi_system_id __initconst bigsmp_dmi_table[] =3D { { force_bigsmp, "UNISYS ES7000-ONE", { DMI_MATCH(DMI_PRODUCT_NAME, "ES7000-ONE") }}, diff --git a/xen/arch/x86/hvm/quirks.c b/xen/arch/x86/hvm/quirks.c index a298ccdbb9..906bf80cc3 100644 --- a/xen/arch/x86/hvm/quirks.c +++ b/xen/arch/x86/hvm/quirks.c @@ -24,7 +24,7 @@ s8 __read_mostly hvm_port80_allowed =3D -1; boolean_param("hvm_port80", hvm_port80_allowed); =20 -static int __init dmi_hvm_deny_port80(/*const*/ struct dmi_system_id *id) +static int __init dmi_hvm_deny_port80(const struct dmi_system_id *id) { printk(XENLOG_WARNING "%s: port 0x80 access %s allowed for HVM guests\= n", id->ident, hvm_port80_allowed > 0 ? "forcibly" : "not"); @@ -41,7 +41,7 @@ static int __init check_port80(void) * Quirk table for systems that misbehave (lock up, etc.) if port * 0x80 is used: */ - static struct dmi_system_id __initdata hvm_no_port80_dmi_table[] =3D + static const struct dmi_system_id __initconst hvm_no_port80_dmi_table[= ] =3D { { .callback =3D dmi_hvm_deny_port80, diff --git a/xen/arch/x86/ioport_emulate.c b/xen/arch/x86/ioport_emulate.c index 504bc513e2..626533b66c 100644 --- a/xen/arch/x86/ioport_emulate.c +++ b/xen/arch/x86/ioport_emulate.c @@ -34,7 +34,7 @@ static bool ioemul_handle_proliant_quirk( } =20 /* This table is the set of system-specific I/O emulation hooks. */ -static struct dmi_system_id __initdata ioport_quirks_tbl[] =3D { +static const struct dmi_system_id __initconst ioport_quirks_tbl[] =3D { /* * I/O emulation hook for certain HP ProLiant servers with * 'special' SMM goodness. diff --git a/xen/arch/x86/shutdown.c b/xen/arch/x86/shutdown.c index 69b82542b3..3af7b5b023 100644 --- a/xen/arch/x86/shutdown.c +++ b/xen/arch/x86/shutdown.c @@ -157,7 +157,7 @@ static void default_reboot_type(void) reboot_type =3D BOOT_ACPI; } =20 -static int __init override_reboot(struct dmi_system_id *d) +static int __init override_reboot(const struct dmi_system_id *d) { enum reboot_type type =3D (long)d->driver_data; =20 @@ -181,7 +181,7 @@ static int __init override_reboot(struct dmi_system_id = *d) return 0; } =20 -static struct dmi_system_id __initdata reboot_dmi_table[] =3D { +static const struct dmi_system_id __initconst reboot_dmi_table[] =3D { { /* Handle problems with rebooting on Dell E520's */ .callback =3D override_reboot, .driver_data =3D (void *)(long)BOOT_KBD, diff --git a/xen/arch/x86/x86_64/mmconf-fam10h.c b/xen/arch/x86/x86_64/mmco= nf-fam10h.c index fa2f5b4881..5af6f22c9f 100644 --- a/xen/arch/x86/x86_64/mmconf-fam10h.c +++ b/xen/arch/x86/x86_64/mmconf-fam10h.c @@ -185,7 +185,7 @@ void fam10h_check_enable_mmcfg(void) wrmsrl(MSR_FAM10H_MMIO_CONF_BASE, val); } =20 -static struct dmi_system_id __initdata mmconf_dmi_table[] =3D { +static const struct dmi_system_id __initconst mmconf_dmi_table[] =3D { { .ident =3D "Sun Microsystems Machine", .matches =3D { diff --git a/xen/include/xen/dmi.h b/xen/include/xen/dmi.h index eba2c27b2f..fa25f6cd38 100644 --- a/xen/include/xen/dmi.h +++ b/xen/include/xen/dmi.h @@ -24,7 +24,7 @@ struct dmi_strmatch { }; =20 struct dmi_system_id { - int (*callback)(struct dmi_system_id *); + int (*callback)(const struct dmi_system_id *); char *ident; struct dmi_strmatch matches[4]; void *driver_data; @@ -32,7 +32,7 @@ struct dmi_system_id { =20 #define DMI_MATCH(a,b) { a, b } =20 -extern int dmi_check_system(struct dmi_system_id *list); +extern int dmi_check_system(const struct dmi_system_id *list); extern void dmi_scan_machine(void); extern const char *dmi_get_table(paddr_t *base, u32 *len); extern void dmi_efi_get_table(const void *smbios, const void *smbios3); --=20 2.11.0 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel From nobody Tue May 7 20:19:08 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1563991040; cv=none; d=zoho.com; s=zohoarc; b=COHuF4HG9O+LV/HnUU8DnRnOe09fqKuRpqGsllgVjdPs1o0X3wLY2SpLRjHhHBKdZqCsGAd8mep8eJhvI7xNVIAolcYutbzT2ASjvErAKUkZbEoOpTHtrwemdfpWuGEfFOccXoEYkPzSigH85qw7OD16xLkKtdGWHFYpVYpqtWQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1563991040; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=bUdRwmDXGrd33UgS0N4ERV+omsJPJVz0c7aizzLgpuk=; b=n8Y2MVKGYjCKCICsoHXDWZTk8Kq/me+AlQmsQ3y1fMH1oHFWTcyze3ipw3zEnL87q59SQ/iFLxRHmWe+lC3EytGy8YtmGfzgW2xUpcNCMSU6Mq5mwCF8fhdedrNAt5Hi9fkXeZgP0DZPi0aUGWhWi9jXeuI4HPln15rmMR2aC1g= ARC-Authentication-Results: i=1; mx.zoho.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1563991040788171.56951335115343; Wed, 24 Jul 2019 10:57:20 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hqLUU-0000YB-8X; Wed, 24 Jul 2019 17:55:50 +0000 Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hqLUS-0000Y6-Mm for xen-devel@lists.xenproject.org; Wed, 24 Jul 2019 17:55:48 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-rack-dfw2.inumbo.com (Halon) with ESMTPS id 4398aa13-ae3c-11e9-8980-bc764e045a96; Wed, 24 Jul 2019 17:55:46 +0000 (UTC) X-Inumbo-ID: 4398aa13-ae3c-11e9-8980-bc764e045a96 Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=andrew.cooper3@citrix.com; spf=Pass smtp.mailfrom=Andrew.Cooper3@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: None (esa4.hc3370-68.iphmx.com: no sender authenticity information available from domain of andrew.cooper3@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa4.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="andrew.cooper3@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa4.hc3370-68.iphmx.com: domain of Andrew.Cooper3@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa4.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="Andrew.Cooper3@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ~all" Received-SPF: None (esa4.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa4.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: 0B4maToHIbWQDQ0w5GjuzOK1K29vQFlO9wfIyCQH2A+FgLWDpIqfdjxBBWtqVka+L7eivhmRQf R9zCgu97FPCV8/s/yikmcQmvn6MpE+Y4wmS1JRbVwbIrwy16678gZkYF+PZHacC4Q3t30Iig2X zlZX91nxtqBptYxfzBGh2sbXvh1zyyTLPt+UrwCv7WKh/hBh6NIKgbfo5dZ1oPHAr2dsknwE5z NJYQb8FuD7V936G8wC4+O0EiBtxTnvY6h65H+AvFPEV9pH1+I/g8FS8WbCgKFqC9CrObtaHmeQ Tr4= X-SBRS: 2.7 X-MesageID: 3511983 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.64,303,1559534400"; d="scan'208";a="3511983" From: Andrew Cooper To: Xen-devel Date: Wed, 24 Jul 2019 18:55:38 +0100 Message-ID: <20190724175538.6098-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190724174256.5295-1-andrew.cooper3@citrix.com> References: <20190724174256.5295-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Subject: [Xen-devel] [PATCH 4/3] x86/dmi: Drop warning with an obsolete URL X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Wei Liu , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" This quirk doesn't change anything in Xen, and the web page doesn't exist. The wayback machine confirms that the link disappeared somewhere between 2003-06-14 and 2004-07-07. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich --- CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monn=C3=A9 --- xen/arch/x86/dmi_scan.c | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/xen/arch/x86/dmi_scan.c b/xen/arch/x86/dmi_scan.c index 808fa7f10e..053f0598cc 100644 --- a/xen/arch/x86/dmi_scan.c +++ b/xen/arch/x86/dmi_scan.c @@ -455,16 +455,6 @@ static void __init dmi_save_ident(struct dmi_header *d= m, int slot, int string) #define NO_MATCH { DMI_NONE, NULL} #define MATCH DMI_MATCH =20 -/* - * Toshiba keyboard likes to repeat keys when they are not repeated. - */ - -static __init int broken_toshiba_keyboard(const struct dmi_blacklist *d) -{ - printk(KERN_WARNING "Toshiba with broken keyboard detected. If your keybo= ard sometimes generates 3 keypresses instead of one, see http://davyd.ucc.a= sn.au/projects/toshiba/README\n"); - return 0; -} - static int __init ich10_bios_quirk(const struct dmi_system_id *d) { u32 port, smictl; @@ -535,11 +525,6 @@ static __init int force_acpi_ht(const struct dmi_black= list *d) =20 static const struct dmi_blacklist __initconst dmi_blacklist[]=3D{ =20 - { broken_toshiba_keyboard, "Toshiba Satellite 4030cdt", { /* Keyboard gen= erates spurious repeats */ - MATCH(DMI_PRODUCT_NAME, "S4030CDT/4.3"), - NO_MATCH, NO_MATCH, NO_MATCH - } }, - { reset_videomode_after_s3, "Toshiba Satellite 4030cdt", { /* Reset video= mode after returning from ACPI S3 sleep */ MATCH(DMI_PRODUCT_NAME, "S4030CDT/4.3"), NO_MATCH, NO_MATCH, NO_MATCH --=20 2.11.0 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel