From nobody Fri May 3 15:20:04 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1563809633; cv=none; d=zoho.com; s=zohoarc; b=SlRmeKW7xEOkkz4CIZ+woy396kcu5I9g/82HWAXIThskj0ZZmXAKsWStvhxSC0hlUaV+nx/7MMHqEa1nMB4aSYXlIcCjdPYv8Zf1xJT6AhHyndN4CbdMee0LgQzgc9fhqYvuzK6Uk1L2BB5N99xPn0CxUKyK/EDXUHicmeVjxXg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1563809633; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=f8Y4z2qhTktYKfk49rVn1ERuEUCxMdEFvHLodWeXZv0=; b=l+frqHPU31vi/ANJGh1vbWPjlwFhdMDLW3SBtp2Df8qXxuToNl2VmmXBjzac4EJaPeMFV4nbPpi+qbXI5sYbZjcuMQHeWjlVq9HNlUdKB33/aX53sfcf3Xgut80Hp0SXl8n3SyhNHLUfc8HFBQQOkPk8czPyG3woKzVcrvfORNo= ARC-Authentication-Results: i=1; mx.zoho.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 156380963315225.607892967156545; Mon, 22 Jul 2019 08:33:53 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hpaIi-0000yd-E3; Mon, 22 Jul 2019 15:32:32 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hpaIh-0000yY-56 for xen-devel@lists.xenproject.org; Mon, 22 Jul 2019 15:32:31 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e921aad6-ac95-11e9-be2b-93a2cec446b9; Mon, 22 Jul 2019 15:32:27 +0000 (UTC) X-Inumbo-ID: e921aad6-ac95-11e9-be2b-93a2cec446b9 Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=roger.pau@citrix.com; spf=Pass smtp.mailfrom=roger.pau@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: None (esa6.hc3370-68.iphmx.com: no sender authenticity information available from domain of roger.pau@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="roger.pau@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa6.hc3370-68.iphmx.com: domain of roger.pau@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="roger.pau@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ~all" Received-SPF: None (esa6.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: oibxTNG5m7SdrtCLa9M+3ZNokdBWEzCvfmEHZRnweS1YWBFys7t08nKgNVP8tvTWgIbMH5yyUU f2GoJ8lW1jxmpwDfP/RZ1q2NUM/AGXYKD4ZpcTcD0gbqhkyEBbyX1yAKl35N73AajBTQV7jrsY L1ogwmfxgAxxr3RL+2dUAjssQr4+8zoQ2Y74vw8OZysuo1g4TunrUl8Ev2tvGOuNYWlOxXyobe MTDevnZ6ZMAa5TlIsw0tqoqX9K5XTeZTiKxqGSfoq6TMV7aDq44Y+qitdiktkNBiKMJSEl7AfR 4Jc= X-SBRS: 2.7 X-MesageID: 3367546 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.64,295,1559534400"; d="scan'208";a="3367546" From: Roger Pau Monne To: Date: Mon, 22 Jul 2019 17:32:09 +0200 Message-ID: <20190722153209.73107-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.20.1 (Apple Git-117) MIME-Version: 1.0 Subject: [Xen-devel] [PATCH] x86/p2m: fix non-translated handling of iommu mappings X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Wei Liu , George Dunlap , Andrew Cooper , Paul Durrant , Jan Beulich , Roger Pau Monne Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" The current usage of need_iommu_pt_sync in p2m for non-translated guests is wrong because it doesn't correctly handle a relaxed PV hardware domain, that has need_sync set to false, but still need entries to be added from calls to {set/clear}_identity_p2m_entry. Adjust the code in guest_physmap_add_page to also check whether the domain has an iommu instead of whether it needs syncing or not in order to take a reference to a page to be mapped. Signed-off-by: Roger Pau Monn=C3=A9 Reviewed-by: Paul Durrant Tested-by: Roman Shaposhnik --- Cc: George Dunlap Cc: Jan Beulich Cc: Andrew Cooper Cc: Wei Liu Cc: Paul Durrant --- xen/arch/x86/mm/p2m.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/mm/p2m.c b/xen/arch/x86/mm/p2m.c index fef97c82f6..88a2430c8c 100644 --- a/xen/arch/x86/mm/p2m.c +++ b/xen/arch/x86/mm/p2m.c @@ -836,7 +836,7 @@ guest_physmap_add_page(struct domain *d, gfn_t gfn, mfn= _t mfn, */ for ( i =3D 0; i < (1UL << page_order); ++i, ++page ) { - if ( !need_iommu_pt_sync(d) ) + if ( !has_iommu_pt(d) ) /* nothing */; else if ( get_page_and_type(page, d, PGT_writable_page) ) put_page_and_type(page); @@ -1341,7 +1341,7 @@ int set_identity_p2m_entry(struct domain *d, unsigned= long gfn_l, =20 if ( !paging_mode_translate(p2m->domain) ) { - if ( !need_iommu_pt_sync(d) ) + if ( !has_iommu_pt(d) ) return 0; return iommu_legacy_map(d, _dfn(gfn_l), _mfn(gfn_l), PAGE_ORDER_4K, IOMMUF_readable | IOMMUF_writable); @@ -1432,7 +1432,7 @@ int clear_identity_p2m_entry(struct domain *d, unsign= ed long gfn_l) =20 if ( !paging_mode_translate(d) ) { - if ( !need_iommu_pt_sync(d) ) + if ( !has_iommu_pt(d) ) return 0; return iommu_legacy_unmap(d, _dfn(gfn_l), PAGE_ORDER_4K); } --=20 2.20.1 (Apple Git-117) _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel