From nobody Mon May 6 11:13:55 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1563485702; cv=none; d=zoho.com; s=zohoarc; b=ZS3uTtBBMSD/tJumPc6JddCV9klHQqfpNdlMB6DwzkkIvgrjzAVKjSpezjzs/Q6sxVgLeYwkRpBWgfYPxZnRiR2kaMzLScapRqcbX+Pc9y4R7xVBN7LZIpVIdaBFN6W8Lu1jYobe+J4ei6WViFNtTqb3q5Viakxd02NWhuWi+1o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1563485702; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=ilgi4XPSmxFSPZ2co3jX+fYdSOAJsmhXSDtKQkdUZxY=; b=LrdEQFHrqZjYnP97i9FF+TAMGJeScAEL8+R7R9dG7DZpL3gDIbhqUl3DDd05wmMapObWrhMP15y8WCY5F5K5hjaVDdPzpYrj9Zng22hhtifB0NR3Tu+VrpHviNBP9CM6Gc2Pa9ioE8rNS+5YGBDI9xdNifiKzRwbEozBH1vUTaE= ARC-Authentication-Results: i=1; mx.zoho.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1563485702248610.9700789636923; Thu, 18 Jul 2019 14:35:02 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hoE1q-0006vr-4F; Thu, 18 Jul 2019 21:33:30 +0000 Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hoE1o-0006vm-5P for xen-devel@lists.xenproject.org; Thu, 18 Jul 2019 21:33:28 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-dfw2.inumbo.com (Halon) with ESMTPS id ace65e75-a9a3-11e9-8980-bc764e045a96; Thu, 18 Jul 2019 21:33:26 +0000 (UTC) X-Inumbo-ID: ace65e75-a9a3-11e9-8980-bc764e045a96 Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=george.dunlap@citrix.com; spf=Pass smtp.mailfrom=George.Dunlap@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of george.dunlap@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="George.Dunlap@citrix.com"; x-sender="george.dunlap@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa2.hc3370-68.iphmx.com: domain of George.Dunlap@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="George.Dunlap@citrix.com"; x-sender="George.Dunlap@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ~all" Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="George.Dunlap@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: UpJpJM9TVJ3ubxxb0mCwMaOjnHMPhYroATuk2zdVbXurVUS3qllwAr8wo0CZL/ugRjhLJprkot f7CHVXnmQZ9Rv5I8KXTxdd9FYJV80EWppz+iRnK+/OIwUrowz0TtIWJKb2HKc0c8AEcazdVdxA NjT/uGo9rzL+1mKGO6fiLp2OHDtRtdXU0foc1XV0PCX+A0S+fDhp3UjjEjNMu4VWH5Maypp1l5 KV6nmliYthdhJV9jeB3lQywZGrZaueKpcc/F3TRIjT1GsVGOr5XjDFGykyu/ZNaYn5ERYmCwRs PvM= X-SBRS: 2.7 X-MesageID: 3149880 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.64,279,1559534400"; d="scan'208";a="3149880" From: George Dunlap To: Date: Thu, 18 Jul 2019 22:33:19 +0100 Message-ID: <20190718213319.4036-1-george.dunlap@citrix.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Subject: [Xen-devel] [PATCH] golang/xenlight: Use the most generic pointer for xennoollog X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Ian Jackson , Nicolas Belouin , George Dunlap , Wei Liu Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Nicolas Belouin It makes more sense for Ctx to contain the generic C.xentoollog_logger type, rather than the specific type we end up assigning to it. This also allows one fewer cast. Signed-off-by: Nicolas Belouin Signed-off-by: George Dunlap --- Nicolas' submitted a patch fixing casts as well as making this change, at my suggestion; but I ended up checking in an earlier patch that fixed casts but didn't make this change. CC: Ian Jackson CC: Wei Liu CC: Nicolas Belouin --- tools/golang/xenlight/xenlight.go | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tools/golang/xenlight/xenlight.go b/tools/golang/xenlight/xenl= ight.go index f5d171c2d5..a2af6f6ef9 100644 --- a/tools/golang/xenlight/xenlight.go +++ b/tools/golang/xenlight/xenlight.go @@ -122,7 +122,7 @@ type Uuid C.libxl_uuid =20 type Context struct { ctx *C.libxl_ctx - logger *C.xentoollog_logger_stdiostream + logger *C.xentoollog_logger } =20 type Hwcap []C.uint32_t @@ -847,14 +847,15 @@ func (Ctx *Context) Open() (err error) { return } =20 - Ctx.logger =3D C.xtl_createlogger_stdiostream(C.stderr, C.XTL_ERROR, 0) + Ctx.logger =3D (*C.xentoollog_logger)(unsafe.Pointer( + C.xtl_createlogger_stdiostream(C.stderr, C.XTL_ERROR, 0))) if Ctx.logger =3D=3D nil { err =3D fmt.Errorf("Cannot open stdiostream") return } =20 ret :=3D C.libxl_ctx_alloc(&Ctx.ctx, C.LIBXL_VERSION, - 0, (*C.xentoollog_logger)(unsafe.Pointer(Ctx.logger))) + 0, Ctx.logger) =20 if ret !=3D 0 { err =3D Error(-ret) @@ -869,7 +870,7 @@ func (Ctx *Context) Close() (err error) { if ret !=3D 0 { err =3D Error(-ret) } - C.xtl_logger_destroy((*C.xentoollog_logger)(unsafe.Pointer(Ctx.logger))) + C.xtl_logger_destroy(Ctx.logger) return } =20 --=20 2.20.1 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel