From nobody Thu Apr 25 04:06:52 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1562678616; cv=none; d=zoho.com; s=zohoarc; b=SJGS/AaS6/M5nbsdRVKuWuV8ScR5u2+sokQbEd82LB8QNdQZaD/jheeXZdz8kJJgsBVN9KntQGw+M+zo/y3zhyLDEjPdAdD6m4ooP7Y3SX8xC7AO2fO3F6ahw3qEceDkhXHHICJYK1qeCpHUgipu1MQUWuZ5VyupaiIlqJzotnI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1562678616; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=0iXr0NBd3pDtqL8z30ybDorqoEyV2C0N5cyB+0nAEA8=; b=FxmtlweUP4jFmbaFHQaqh36yvu6/TIG5D3RFPhsFRGwfv4H9ErMyT+6qWH7sLNqogkq10hyFfxrG8nJHSUpxi+8Ys2DtbjAsO5XvG1tdz4925vwkgvTXmrBPoJ5/EbQ9fOnbfDCzo47TNrKeYLLM9/DQEbJUmaD321pok8bX9CM= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1562678616701739.2653488866484; Tue, 9 Jul 2019 06:23:36 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hkq4i-0002Iz-Qz; Tue, 09 Jul 2019 13:22:28 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hkq4i-0002Iu-7N for xen-devel@lists.xenproject.org; Tue, 09 Jul 2019 13:22:28 +0000 Received: from GCC01-DM2-obe.outbound.protection.outlook.com (unknown [40.107.84.115]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 97e62bb8-a24c-11e9-86cf-dbae6dc6fa96; Tue, 09 Jul 2019 13:22:26 +0000 (UTC) Received: from BL0PR0901MB3203.namprd09.prod.outlook.com (20.177.243.158) by BL0PR0901MB4434.namprd09.prod.outlook.com (52.135.44.200) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2052.19; Tue, 9 Jul 2019 13:22:23 +0000 Received: from BL0PR0901MB3203.namprd09.prod.outlook.com ([fe80::317f:a059:9fd3:dcf]) by BL0PR0901MB3203.namprd09.prod.outlook.com ([fe80::317f:a059:9fd3:dcf%5]) with mapi id 15.20.2052.020; Tue, 9 Jul 2019 13:22:23 +0000 X-Inumbo-ID: 97e62bb8-a24c-11e9-86cf-dbae6dc6fa96 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=starlab.io; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yx4wNshjT3qkHBehHQcIDLnOJ1GECceMcL1gR9TcUSE=; b=lU6EgoqVmp8HedL41Nr3YTLlJXtUz+4ERbqqVP+707HrZGuIfkG+HUT9ETO6hXNdJzULUOYYC0ZeQWZ+d0pzMeiu0RgT2uZYrNov6Au29urHdcVrhl5rwR3u3X3hAVZClpcxriO8KM+wAZdWIu2+DZS3DjUGkgH72HwqTyAe3+c= From: Will Abele To: "xen-devel@lists.xenproject.org" Thread-Topic: [PATCH v2] xen/arm: use correct device tree root node name Thread-Index: AQHVNllYmcbZdJKG8kKVhIvh9//pFg== Date: Tue, 9 Jul 2019 13:22:23 +0000 Message-ID: <20190709132145.9060-1-will.abele@starlab.io> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: BN7PR06CA0039.namprd06.prod.outlook.com (2603:10b6:408:34::16) To BL0PR0901MB3203.namprd09.prod.outlook.com (2603:10b6:208:8e::30) authentication-results: spf=none (sender IP is ) smtp.mailfrom=will.abele@starlab.io; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.22.0 x-originating-ip: [207.229.155.139] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8b3691a0-6dfc-4aeb-5997-08d704707a78 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(7021145)(8989299)(4534185)(7022145)(4603075)(4627221)(201702281549075)(8990200)(7048125)(7024125)(7027125)(7023125)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:BL0PR0901MB4434; x-ms-traffictypediagnostic: BL0PR0901MB4434: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 0093C80C01 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(366004)(396003)(346002)(136003)(376002)(39830400003)(189003)(199004)(186003)(256004)(73956011)(102836004)(6506007)(66946007)(5640700003)(2906002)(7736002)(305945005)(386003)(54906003)(36756003)(486006)(2351001)(8936002)(508600001)(66446008)(64756008)(6436002)(5660300002)(26005)(66476007)(52116002)(316002)(53936002)(66556008)(3846002)(81156014)(74482002)(1076003)(81166006)(6916009)(4326008)(2616005)(476003)(6486002)(2501003)(25786009)(99286004)(44832011)(8676002)(14454004)(66066001)(68736007)(86362001)(71190400001)(71200400001)(6116002)(6512007)(50226002); DIR:OUT; SFP:1102; SCL:1; SRVR:BL0PR0901MB4434; H:BL0PR0901MB3203.namprd09.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; received-spf: None (protection.outlook.com: starlab.io does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: HJ7EoGkHRDJT14YqGpN+9Mz1vQYASUpO9V5xe+WFo7CFO0H79goDVd+4cyNCgcvLCObgvIw9PpYdpBJtyr3t1TkHX2Qkww6UClqsVAITRXrFuGDsMnVDmSuD7yaJMCqvIr6k16KsjqSuDD5R7tqatOldviADQfZtmHIHindzj+btf4JqsSkWe4tvmeeyF2J5GByOIjn+BYS3P/i15RWXDQBQ4lKbf5zr5uzC9wo5n1IvzWqJ8ihSAgXPbTh3CR3N1vNrMJLg10ZMfNg+3qObrByqRCLWw3VbJ6ItoJZLG1JCQ/FRah3feGJ8jN4eASrt9B16mZQYNULmQuYrRZ3O/CSrDfBZzRkS9avMcIJMEXHvb+dH5YidmFVcEyXIQzC0leKMyyT8ffnLu7E5I+Ht9sfbM+B2RSzTLWxiq/9fZH4= MIME-Version: 1.0 X-OriginatorOrg: starlab.io X-MS-Exchange-CrossTenant-Network-Message-Id: 8b3691a0-6dfc-4aeb-5997-08d704707a78 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jul 2019 13:22:23.4879 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 5e611933-986f-4838-a403-4acb432ce224 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: will.abele@starlab.io X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR0901MB4434 Subject: [Xen-devel] [PATCH v2] xen/arm: use correct device tree root node name X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Will Abele Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Will Abele The root node of a device tree should not have a node name. This is specified in section 2.2.1 of version 0.2 of the device tree specification, available from devicetree.org. Linux Kernel versions prior to 4.15 misinterpret flattened device trees with a "/" as the name of the root node as an FDT version older than 16. Linux then fails to parse the FDT. Signed-off-by: Will Abele Reviewed-by: Julien Grall --- xen/arch/arm/acpi/domain_build.c | 2 +- xen/arch/arm/domain_build.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/arch/arm/acpi/domain_build.c b/xen/arch/arm/acpi/domain_bu= ild.c index 5aae32ac20..1b1cfabb00 100644 --- a/xen/arch/arm/acpi/domain_build.c +++ b/xen/arch/arm/acpi/domain_build.c @@ -145,7 +145,7 @@ static int __init create_acpi_dtb(struct kernel_info *k= info, if ( ret < 0 ) goto err; =20 - ret =3D fdt_begin_node(kinfo->fdt, "/"); + ret =3D fdt_begin_node(kinfo->fdt, ""); if ( ret < 0 ) goto err; =20 diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index d9836779d1..af936b4c3a 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -1697,7 +1697,7 @@ static int __init prepare_dtb_domU(struct domain *d, = struct kernel_info *kinfo) if ( ret < 0 ) goto err; =20 - ret =3D fdt_begin_node(kinfo->fdt, "/"); + ret =3D fdt_begin_node(kinfo->fdt, ""); if ( ret < 0 ) goto err; =20 --=20 2.22.0 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel