From nobody Sat Apr 20 08:23:00 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1562624247; cv=none; d=zoho.com; s=zohoarc; b=oroFwFZ7MgdL9XzkZJrnNOp2lqw9jZm3ryfGEBdU/hML9tcOImtgrV6KcASMcIjln7gvJEeCdZGn0+CP0m6IoV2YF/7RXXu45VjeaHHM52zp+93tYzFfUHbMyE0JOBN69NRBxAyirpO70HPj0kuPnmYt/Ne6/mcV/wTZshSoiAA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1562624247; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=qz/XGwwtsHg1RmperqmubNjqEC1ILC5SOz2YUI/K7sI=; b=kxdn/RS2+RchlFOwvQRdg3Ktv3Pi8NBvSsn+oFqzhXKuOR98lm3ZWYcJeLvw+rgafrtH4P7dFlq/PsCNS9NMqu++divN/payxQxmRwvKd9fxLenMEepvGVqy1lKMMSTUCphZUjNiG5LpA4fG9XdFj+OpATo4uKmADvvTQJnVeok= ARC-Authentication-Results: i=1; mx.zoho.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1562624247671225.11232727419133; Mon, 8 Jul 2019 15:17:27 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hkbv4-0004Bq-7R; Mon, 08 Jul 2019 22:15:34 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hkbv3-0004Bj-Dc for xen-devel@lists.xenproject.org; Mon, 08 Jul 2019 22:15:33 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e356ed46-a1cd-11e9-9468-4381ec70f449; Mon, 08 Jul 2019 22:15:27 +0000 (UTC) X-Inumbo-ID: e356ed46-a1cd-11e9-9468-4381ec70f449 Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=andrew.cooper3@citrix.com; spf=Pass smtp.mailfrom=Andrew.Cooper3@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of andrew.cooper3@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="andrew.cooper3@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa2.hc3370-68.iphmx.com: domain of Andrew.Cooper3@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="Andrew.Cooper3@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ~all" Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: RUOcOUU8Jo5a/CCphOFSgBuDOYWbmFjBR6yu/bpeaNINxWa0LWwSGntgQJjJCS6fLuwnEdDsJv A9Bi1pqZO+f+JIaweOTg4LW3KW+E87/Ng90xk+upd904+BOWiuXm8A0D5MThvr8EVwPRDAvpui mbEwGcQL2nQP7NCAlfvz7VmM7nkVh36VlTflLD0Fwaz/6+L08wlUi3kyfyplos5Nqlh3CfElg7 ed2htKEhrvLri6AGbpJ219mehcrwKJYq1P85y1t+UppovK4KfeYJhtIXJjQkU9ouqEX1PzXWEA 05s= X-SBRS: 2.7 X-MesageID: 2704810 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.63,468,1557201600"; d="scan'208";a="2704810" From: Andrew Cooper To: Xen-devel Date: Mon, 8 Jul 2019 23:15:22 +0100 Message-ID: <20190708221522.967-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Subject: [Xen-devel] [PATCH] x86/grant: Use explicit instruction size in gnttab_clear_flags() X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Wei Liu , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" The OpenSUSE Leap compilers complain about ambiguity: In file included from grant_table.c:33: In file included from ...xen/include/xen/grant_table.h:30: ...xen/include/asm/grant_table.h:67:19: error: ambiguous instructions requi= re an explicit suffix (could be 'andb', 'andw', 'andl', or 'andq') asm volatile ("lock and %1,%0" : "+m" (*addr) : "ir" ((uint16_t)~mask)); ^ :1:2: note: instantiated into assembly here lock and $-17,(%rsi) ^ Full logs: https://gitlab.com/xen-project/people/andyhhp/xen/-/jobs/2476002= 84 Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich --- CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monn=C3=A9 --- xen/include/asm-x86/grant_table.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/include/asm-x86/grant_table.h b/xen/include/asm-x86/grant_= table.h index 568a6bb57c..61c889b297 100644 --- a/xen/include/asm-x86/grant_table.h +++ b/xen/include/asm-x86/grant_table.h @@ -64,7 +64,7 @@ static inline void gnttab_clear_flags(struct domain *d, unsigned int mask, uint16_t *addr) { /* Access must be confined to the specified 2 bytes. */ - asm volatile ("lock and %1,%0" : "+m" (*addr) : "ir" ((uint16_t)~mask)= ); + asm volatile ("lock andw %1,%0" : "+m" (*addr) : "ir" ((uint16_t)~mask= )); } =20 /* Foreign mappings of HVM-guest pages do not modify the type count. */ --=20 2.11.0 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel