From nobody Fri Mar 29 00:14:46 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1561978218; cv=none; d=zoho.com; s=zohoarc; b=gW/3RvloPDDUOzxJRdSujrEF0aADbGVWaOnuzqlgNApK0FnR/k89qitdGyDJG4v5CtQq6H+Qh9rWQcSMh4diVf0Zoyx24y2ZFZrJO5/poNVyhIimu0y+I4eIhbWY6mFPhrJGCjCP5fIy9R8O0M6SAXrIVYeTtdA9jux0iAD4Cz8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1561978218; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=18k/ltziPkhmVwdN2xytZhIgIKccAvHm3N8bAgyEXw8=; b=nzQ1zich1RMq/aE/EB1Zl/UddSd2ZhpgVrPqqWUeS0Pq8PGOKNA53wsQkR89/uz0An2BA5H0dO9Z68yL6EZleF9JBgmxUHBR5SRg6RNJXDM/r4PJZ5NP6BCToLTtddaD88uKsoKp7AAuVtoub0Ev1tzEVVNNwcIy29lO7u4tW5U= ARC-Authentication-Results: i=1; mx.zoho.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1561978218307622.7664734185267; Mon, 1 Jul 2019 03:50:18 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hhts2-00062j-4o; Mon, 01 Jul 2019 10:49:14 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hhts1-00062Y-FC for xen-devel@lists.xenproject.org; Mon, 01 Jul 2019 10:49:13 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id da26f382-9bed-11e9-ac92-4723d51b6d21; Mon, 01 Jul 2019 10:49:08 +0000 (UTC) X-Inumbo-ID: da26f382-9bed-11e9-ac92-4723d51b6d21 Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=roger.pau@citrix.com; spf=Pass smtp.mailfrom=roger.pau@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: None (esa1.hc3370-68.iphmx.com: no sender authenticity information available from domain of roger.pau@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa1.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="roger.pau@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa1.hc3370-68.iphmx.com: domain of roger.pau@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa1.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="roger.pau@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ~all" Received-SPF: None (esa1.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa1.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: IlpH73wbgUqHqUYN2A8SgtXBCHo8FkY1Qz3mtGYfmsQVTtnmcC4HvqHoG6269nLHakLa3lve44 aWEH3+wHN/jtlTfWIgZx/ZcnYx4yIOCmmmT4hCHncj0FpgvXGT4pkRkc4lt3hFvX4L6nTfnW3J mK79rgi4l2e8lN2iYbyT7La2+EeKKPgDUbwl/y3tE/e9hnZd2apkQZ8o5H17JN5bgHY5Uco+UP sC/c4N9D0QULwbie6bLLuy540RIQ9Kqc/X79PXywMuUPi4o0iTJUojJCQssmQgZWYrXNmDMYy1 cGs= X-SBRS: 2.7 X-MesageID: 2454098 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.63,439,1557201600"; d="scan'208";a="2454098" From: Roger Pau Monne To: Date: Mon, 1 Jul 2019 12:49:03 +0200 Message-ID: <20190701104903.72364-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.20.1 (Apple Git-117) MIME-Version: 1.0 Subject: [Xen-devel] [PATCH] xstate: make use_xsave non-init X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Wei Liu , Jan Beulich , Roger Pau Monne Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" LLVM code generation can attempt to load from a variable in the next condition of an expression under certain circumstances, thus attempting to load use_xsave regardless of the value of the bsp variable, which leads to a page fault when the init section has already been unmapped. Fix this by making use_xsave non-init, thus preventing the page fault. The LLVM bug with the discussion about this issue can be found at: https://bugs.llvm.org/show_bug.cgi?id=3D39707 Signed-off-by: Roger Pau Monn=C3=A9 --- Cc: Jan Beulich Cc: Andrew Cooper Cc: Wei Liu --- xen/arch/x86/xstate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/xstate.c b/xen/arch/x86/xstate.c index 3293ef834f..6a7353109b 100644 --- a/xen/arch/x86/xstate.c +++ b/xen/arch/x86/xstate.c @@ -577,7 +577,7 @@ unsigned int xstate_ctxt_size(u64 xcr0) /* Collect the information of processor's extended state */ void xstate_init(struct cpuinfo_x86 *c) { - static bool __initdata use_xsave =3D true; + static bool use_xsave =3D true; boolean_param("xsave", use_xsave); =20 bool bsp =3D c =3D=3D &boot_cpu_data; --=20 2.20.1 (Apple Git-117) _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel