From nobody Mon Feb 9 23:00:15 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1560786137; cv=none; d=zoho.com; s=zohoarc; b=RO5H+Hym70P89MaeKDwNzkfv7qWcGzB5tXr9H771l4ct3YN+DABrNXuqGulcMIzLINltS4l/t42rMh1c4dJnT/m96F2n9blIQDwujWWEYzzEsF0mi8epRNr27h/SUNvrpO9c4KateA4wENHljvQxV6wgMn+lhr6DelPdWxVvCTk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1560786137; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=vI47rhbnIQwhu5wr4acKoiUH41JcuusN087wPGuLa4o=; b=KOAlKQFOfJZixswZRhQOefZvpTSsCs75TJCLagskddRtu8I5CcSQF/IqT5qpavI1UzS0t5u/9ETkIoD5qOFWwC+seFqxuQ9VCF/ZL3fQJpX6DCSv7QClEtn6EZX0QAqKT/toOFVaCIP9qdC3cMwmqf+zxbdQDgtspQXVE0UAnNQ= ARC-Authentication-Results: i=1; mx.zoho.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1560786137531581.7818987358968; Mon, 17 Jun 2019 08:42:17 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hctky-0008M6-HG; Mon, 17 Jun 2019 15:41:16 +0000 Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hctkw-0008LU-Va for xen-devel@lists.xenproject.org; Mon, 17 Jun 2019 15:41:15 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-rack-dfw2.inumbo.com (Halon) with ESMTPS id 561209d7-9116-11e9-8980-bc764e045a96; Mon, 17 Jun 2019 15:41:13 +0000 (UTC) X-Inumbo-ID: 561209d7-9116-11e9-8980-bc764e045a96 Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=anthony.perard@citrix.com; spf=Pass smtp.mailfrom=anthony.perard@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: None (esa4.hc3370-68.iphmx.com: no sender authenticity information available from domain of anthony.perard@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa4.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa4.hc3370-68.iphmx.com: domain of anthony.perard@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa4.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ~all" Received-SPF: None (esa4.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa4.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: m8p7QSPWyD6XAlP0UCvQs8rrSZpRFRITJnOmdhyixFTQF+HI+KTQhyUcxt3Wzbd7aww30IHafu PM5jGuamTqsXMfNgjC99ipQShn66hGYE8f+KNXYQGtgGZVaRFmHSrH+ae4Dre9+jkV9DC+LWt6 JrBm9ctvIIWM+cZRKH8V2TqzoaUlO2KVzqrzfkOrO+e/KOBKtTkpsyAQ1v0P/qHm02McQ3MEwM Nhx3hbhykEwGGG6ukfgPV9rLzbAfAVcMH5YwFtVkW2x9S/i9zwxBEBNmVfaxHfFd31t0mJLB6N 9Lc= X-SBRS: 2.7 X-MesageID: 1846122 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.63,385,1557201600"; d="scan'208";a="1846122" From: Anthony PERARD To: Date: Mon, 17 Jun 2019 16:41:05 +0100 Message-ID: <20190617154105.32323-5-anthony.perard@citrix.com> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190617154105.32323-1-anthony.perard@citrix.com> References: <20190617154105.32323-1-anthony.perard@citrix.com> MIME-Version: 1.0 Subject: [Xen-devel] [PATCH 4/4] xen: Avoid VLA X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Anthony PERARD , xen-devel@lists.xenproject.org, Stefano Stabellini , Paul Durrant Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Avoid using a variable length array. Signed-off-by: Anthony PERARD --- Notes: Was suggested by Peter here: "should we try to stop using variable length arrays?" hw/i386/xen/xen-hvm.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c index 725f9c2278..10d73b55b4 100644 --- a/hw/i386/xen/xen-hvm.c +++ b/hw/i386/xen/xen-hvm.c @@ -615,7 +615,8 @@ static void xen_sync_dirty_bitmap(XenIOState *state, { hwaddr npages =3D size >> TARGET_PAGE_BITS; const int width =3D sizeof(unsigned long) * 8; - unsigned long bitmap[DIV_ROUND_UP(npages, width)]; + unsigned long *bitmap =3D NULL; + size_t bitmap_size =3D DIV_ROUND_UP(npages, width); int rc, i, j; const XenPhysmap *physmap =3D NULL; =20 @@ -632,6 +633,8 @@ static void xen_sync_dirty_bitmap(XenIOState *state, return; } =20 + bitmap =3D g_new0(unsigned long, bitmap_size); + rc =3D xen_track_dirty_vram(xen_domid, start_addr >> TARGET_PAGE_BITS, npages, bitmap); if (rc < 0) { @@ -644,10 +647,10 @@ static void xen_sync_dirty_bitmap(XenIOState *state, ", 0x" TARGET_FMT_plx "): %s\n", start_addr, start_addr + size, strerror(errno)); } - return; + goto out; } =20 - for (i =3D 0; i < ARRAY_SIZE(bitmap); i++) { + for (i =3D 0; i < bitmap_size; i++) { unsigned long map =3D bitmap[i]; while (map !=3D 0) { j =3D ctzl(map); @@ -657,6 +660,8 @@ static void xen_sync_dirty_bitmap(XenIOState *state, TARGET_PAGE_SIZE); }; } +out: + g_free(bitmap); } =20 static void xen_log_start(MemoryListener *listener, --=20 Anthony PERARD _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel